All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] tests/functional: fix pylint false positives for cv2 module
Date: Mon, 17 Aug 2026 13:01:54 +0200	[thread overview]
Message-ID: <d6fa2176-7cf2-4955-8dc8-a79ca34ef568@redhat.com> (raw)
In-Reply-To: <CAJ+F1CL7VVXBa5jJKxaKQ-ZV4Yf=uoz3SSLPCcxmRH6duvnYMQ@mail.gmail.com>

On 17/08/2026 12.54, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Aug 17, 2026 at 12:39 PM Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 17/08/2026 09.57, Marc-André Lureau wrote:
>>> Hi
>>>
>>> On Mon, Aug 17, 2026 at 11:19 AM Thomas Huth <thuth@redhat.com> wrote:
>>>>
>>>> On 15/08/2026 09.24, marcandre.lureau@redhat.com wrote:
>>>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>>>
>>>>> Add generated-members=cv2.* to pylintrc so pylint skips member
>>>>> checking on the cv2 C extension module, whose members are not
>>>>> visible to static analysis.
>>>>>
>>>>> Silence:
>>>>> 2026-08-15 10:42:08,710 - INFO: qemu-test.test_pylint Checking files in /home/elmarco/src/qemu.qom-qapi/tests/functional/arm with pylint
>>>>> 2026-08-15 10:42:10,941 - ERROR: qemu-test.test_pylint "/home/elmarco/src/qemu.qom-qapi/tests/functional/arm/test_integratorcp.py:83: E1101: Module 'cv2' has no 'imread' member (no-member)"
>>>>
>>>> Alex recently already sent a patch for that error here:
>>>>
>>>>     https://gitlab.com/qemu-project/qemu/-/commit/dd14a21b9dc1
>>>>
>>>> Didn't that help to silence the message in your case, too?
>>>
>>> Ah I missed that, but it doesn't help:
>>>
>>> pylint --rcfile ../tests/functional/pylintrc ../tests/functional/arm/
>>> ************* Module test_integratorcp
>>> /home/elmarco/src/qemu.nohmp/tests/functional/arm/test_integratorcp.py:83:25:
>>> E1101: Module 'cv2' has no 'imread' member (no-member)
>>> /home/elmarco/src/qemu.nohmp/tests/functional/arm/test_integratorcp.py:84:26:
>>> E1101: Module 'cv2' has no 'cvtColor' member (no-member)
>>> /home/elmarco/src/qemu.nohmp/tests/functional/arm/test_integratorcp.py:84:55:
>>> E1101: Module 'cv2' has no 'COLOR_BGR2GRAY' member (no-member)
>>> /home/elmarco/src/qemu.nohmp/tests/functional/arm/test_integratorcp.py:85:17:
>>> E1101: Module 'cv2' has no 'matchTemplate' member (no-member)
>>> /home/elmarco/src/qemu.nohmp/tests/functional/arm/test_integratorcp.py:85:52:
>>> E1101: Module 'cv2' has no 'imread' member (no-member)
>>> /home/elmarco/src/qemu.nohmp/tests/functional/arm/test_integratorcp.py:86:35:
>>> E1101: Module 'cv2' has no 'TM_CCOEFF_NORMED' member (no-member)
>>>
>>> My understanding:
>>>
>>> I1101 (c-extension-no-member) - disable: silence if pylint can't
>>> introspect the module
>>>
>>> E1101 (no-member) - but we need to tell pylint to trust any member
>>> access on cv2 if it can
>> Ok, but could you then add it to the "disable=..." list instead, so that we
>> disable this for all other modules, too? ... otherwise we'll be busy adding
>> an entry for all other modules where this pops up in the course of time.
>>
> 
> I see your point, but disabling "no-member" globally means pylint
> won't catch typos like self.naem or obj.nonexistent_method() anywhere.
Ok, then let's go with your patch here.

Reviewed-by: Thomas Huth <thuth@redhat.com>



      reply	other threads:[~2026-08-17 11:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15  7:24 [PATCH] tests/functional: fix pylint false positives for cv2 module marcandre.lureau
2026-08-17  7:18 ` Thomas Huth
2026-08-17  7:57   ` Marc-André Lureau
2026-08-17  8:38     ` Thomas Huth
2026-08-17 10:54       ` Marc-André Lureau
2026-08-17 11:01         ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6fa2176-7cf2-4955-8dc8-a79ca34ef568@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.