Re: [RFC PATCH dlm/next 1/4] dlm: mask sk_shutdown value

[Heming Zhao <heming.zhao@suse.com>]

On 4/30/25 04:29, Alexander Aring wrote:
> The sk->sk_shutdown value is flag value so use masking to check if
> RCV_SHUTDOWN is set as other possible values like SEND_SHUTDOWN can set
> as well.
> 
> Signed-off-by: Alexander Aring <aahringo@redhat.com>

Tested-by: Heming zhao <heming.zhao@suse.com>
Reviewed-by: Heming zhao <heming.zhao@suse.com>

> ---
>   fs/dlm/lowcomms.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 70abd4da17a6..50c42b368c83 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -533,7 +533,7 @@ static void lowcomms_state_change(struct sock *sk)
>   	/* SCTP layer is not calling sk_data_ready when the connection
>   	 * is done, so we catch the signal through here.
>   	 */
> -	if (sk->sk_shutdown == RCV_SHUTDOWN)
> +	if (sk->sk_shutdown & RCV_SHUTDOWN)
>   		lowcomms_data_ready(sk);
>   }
>