All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-net 1/3] selftests: mptcp: close server file descriptor
Date: Tue, 2 Sep 2025 10:44:51 +0200	[thread overview]
Message-ID: <d712d30d-b0d9-491d-ae54-9c71cb20bbbf@kernel.org> (raw)
In-Reply-To: <8e614206c3e57d7d87e983f8f8c157387052a595.1756776801.git.tanggeliang@kylinos.cn>

Hi Geliang,

On 02/09/2025 03:38, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> The server file descriptor ('fd') is opened in server() but never closed.
> While accepted connections are properly closed in process_one_client(),
> the main listening socket remains open, causing a resource leak.
> 
> This patch ensures the server fd is properly closed after processing
> clients, bringing the sockopt and inq test cases in line with proper
> resource cleanup practices.

Thanks!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2025-09-02  8:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02  1:38 [PATCH mptcp-net 0/3] misc fixes for sockopt selftests Geliang Tang
2025-09-02  1:38 ` [PATCH mptcp-net 1/3] selftests: mptcp: close server file descriptor Geliang Tang
2025-09-02  8:44   ` Matthieu Baerts [this message]
2025-09-02  1:38 ` [PATCH mptcp-net 2/3] selftests: mptcp: avoid double closing pipe descriptor Geliang Tang
2025-09-02  8:45   ` Matthieu Baerts
2025-09-02  1:38 ` [PATCH mptcp-net 3/3] selftests: mptcp: sockopt: fix variable check in error reporting Geliang Tang
2025-09-02  8:45   ` Matthieu Baerts
2025-09-02  3:39 ` [PATCH mptcp-net 0/3] misc fixes for sockopt selftests MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d712d30d-b0d9-491d-ae54-9c71cb20bbbf@kernel.org \
    --to=matttbe@kernel.org \
    --cc=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=tanggeliang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.