From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Simek <michal.simek@xilinx.com>
Date: Tue, 21 Jul 2020 15:18:56 +0200
Subject: [PATCH v6 3/3] gpio: search for gpio label if gpio is not found
 through bank name
In-Reply-To: <4af17601-f95f-c5a4-5a24-1c84c3581fd3@denx.de>
References: <20200522090858.2569904-1-hs@denx.de>
 <20200522090858.2569904-4-hs@denx.de>
 <CAHTX3dJX7p0hS=LwRxcXg6Oqyr2YcG=gPsP6xO74xgepiaL2Aw@mail.gmail.com>
 <4af17601-f95f-c5a4-5a24-1c84c3581fd3@denx.de>
Message-ID: <d71e803f-ff16-b88e-c78a-a9873ad6bf56@xilinx.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



On 21. 07. 20 8:40, Heiko Schocher wrote:
> Hi Michal,
> 
> Am 20.07.2020 um 10:30 schrieb Michal Simek:
>> Hi Heiko,
>>
>> p? 22. 5. 2020 v 11:10 odes?latel Heiko Schocher <hs@denx.de> napsal:
>>>
>>> dm_gpio_lookup_name() searches for a gpio through
>>> the bank name. But we have also gpio labels, and it
>>> makes sense to search for a gpio also in the labels
>>> we have defined, if no gpio is found through the
>>> bank name definition.
>>>
>>> This is useful for example if you have a wp pin on
>>> different gpios on different board versions.
>>>
>>> If dm_gpio_lookup_name() searches also for the gpio labels,
>>> you can give the gpio an unique label name and search
>>> for this label, and do not need to differ between
>>> board revisions.
>>>
>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>> ---
>>>
>>> Example on the aristainetos board:
>>>
>>> => gpio clear wp_spi_nor.gpio-hog
>>> gpio: pin wp_spi_nor.gpio-hog (gpio 47) value is 0
>>> =>
>>>
>>> before this patch, you need to know where your
>>> pin is:
>>>
>>> => gpio clear GPIO2_15
>>> gpio: pin GPIO2_15 (gpio 47) value is 0
>>> =>
>>
>> I spotted this patch and I am curious if you have thought about also
>> supporting gpio-line-names.
> 
> Yes, that would be a good extension!
> 
> searching for "gpio-line-names" in u-boot source shows only an entry in
> 
> ./doc/device-tree-bindings/gpio/gpio.txt
> 
> and some DTS files in arch/arm
> 
> but no driver code, which handles the property, so there is some
> work to do.
> 
> Currently I have no project (and time) to give this a chance...
> 
> But if the code, which handle "gpio-line-names" saves the name in
> "struct gpio_dev_priv name", DM_GPIO_LOOKUP_LABEL based code should
> work with it.

I have sent a patch for it. Please take a look.

Thanks,
Michal