From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Add Lenovo ThinkPad T14s Gen 6
Date: Tue, 23 Jul 2024 00:40:53 +0200 [thread overview]
Message-ID: <d73036be-e357-4e4e-b12e-334a5f5cfc49@linaro.org> (raw)
In-Reply-To: <20240722212434.GA112051-robh@kernel.org>
On 22.07.2024 11:24 PM, Rob Herring wrote:
> On Fri, Jul 19, 2024 at 10:16:36PM +0200, Konrad Dybcio wrote:
>> Document the X1E78100-based ThinkPad.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index f08e13b61172..8af56b602de3 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1038,6 +1038,12 @@ properties:
>> - qcom,sm8650-qrd
>> - const: qcom,sm8650
>>
>> + - items:
>> + - enum:
>> + - lenovo,thinkpad-t14s
>> + - const: qcom,x1e78100
>> + - const: qcom,x1e80100
>
> Why 2 chip compatibles? Please explain in the commit msg.
Just like other entries in this yaml, the one in the middle is a
fuse variant of the latter one. I'll mention this.
Konrad
next prev parent reply other threads:[~2024-07-22 22:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 20:16 [PATCH 0/3] ThinkPad T14s Gen 6 support Konrad Dybcio
2024-07-19 20:16 ` [PATCH 1/3] dt-bindings: arm: qcom: Add Lenovo ThinkPad T14s Gen 6 Konrad Dybcio
2024-07-21 10:22 ` Krzysztof Kozlowski
2024-07-22 21:24 ` Rob Herring
2024-07-22 22:40 ` Konrad Dybcio [this message]
2024-07-19 20:16 ` [PATCH 2/3] firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s Konrad Dybcio
2024-07-21 16:40 ` Abel Vesa
2024-07-19 20:16 ` [PATCH 3/3] arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6 Konrad Dybcio
2024-07-21 16:40 ` Abel Vesa
2024-07-22 8:42 ` Konrad Dybcio
2024-07-22 10:08 ` Abel Vesa
2024-07-22 15:00 ` Rob Clark
2024-07-22 16:03 ` Dmitry Baryshkov
2024-07-23 18:55 ` Bjorn Andersson
2024-07-23 21:28 ` Mark Kettenis
2024-07-29 20:42 ` Rob Clark
2024-07-22 10:04 ` Johan Hovold
2024-07-23 2:57 ` [PATCH 0/3] ThinkPad T14s Gen 6 support Rob Herring (Arm)
2024-07-29 3:58 ` (subset) " Bjorn Andersson
2024-08-16 16:30 ` Rob Herring
2024-08-26 17:05 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d73036be-e357-4e4e-b12e-334a5f5cfc49@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.