All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Magnus Karlsson <magnus.karlsson@intel.com>
Cc: <magnus.karlsson@gmail.com>, <intel-wired-lan@lists.osuosl.org>,
	<anthony.l.nguyen@intel.com>, <maciej.fijalkowski@intel.com>,
	<przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-net] ice: use the queue pair's XDP ring in ice_qp_{dis, ena}()
Date: Thu, 19 Nov 2026 12:10:20 +0100	[thread overview]
Message-ID: <d736c9f0-ffd6-4232-8bf5-06a8c7c4addd@intel.com> (raw)
In-Reply-To: <20261118135952.1063685-1-magnus.karlsson@intel.com>

From: Karlsson, Magnus <magnus.karlsson@intel.com>
Date: Wed, 18 Nov 2026 14:59:52 +0100

> Since commit 9ead7e74bfd6 ("ice: xsk: use Rx ring's XDP ring when picking
> NAPI context"), an Rx ring uses the XDP ring that is first on its queue
> vector's Tx ring list, both for XDP_TX and for AF_XDP zero-copy Tx. With
> fewer queue vectors than CPUs, a vector carries several XDP rings, so Rx
> ring N then does not use XDP ring N. ice_qp_dis(), ice_qp_ena() and the
> ring cleaning and stats reset they call still operate on
> vsi->xdp_rings[q_idx].

Breh, I've had this for some time already on my GitHub ([0], BTW you can
cross-check with my version) and have been planning to send this soon,
but you were first :D
Thanks!

> 
> As a result, a zero-copy pool is attached to and detached from an XDP ring
> that is never stopped, cleaned or reconfigured. At the same time, another
> XDP ring is stopped and cleaned, possibly while it is in use from another
> queue vector whose NAPI context keeps running.
[0]
https://github.com/alobakin/linux/commit/9fcdb9c92bf241254679c247b401c6500e21dddf

Thanks,
Olek

      parent reply	other threads:[~2026-11-19 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:59 [PATCH iwl-net] ice: use the queue pair's XDP ring in ice_qp_{dis, ena}() Magnus Karlsson
2026-11-18 14:26 ` [PATCH iwl-net] ice: use the queue pair's XDP ring in ice_qp_{dis,ena}() Maciej Fijalkowski
2026-11-18 14:35 ` [PATCH iwl-net] ice: use the queue pair's XDP ring in ice_qp_{dis, ena}() sashiko-bot
2026-11-19 10:30   ` Karlsson, Magnus
2026-11-19 11:10 ` Alexander Lobakin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d736c9f0-ffd6-4232-8bf5-06a8c7c4addd@intel.com \
    --to=aleksander.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@gmail.com \
    --cc=magnus.karlsson@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.