All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>,
	sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
	Andrea Righi <arighi@nvidia.com>,
	Changwoo Min <changwoo@igalia.com>
Cc: Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
	Chia-Ping Tsai <chia7712@gmail.com>,
	Emil Tsalapatis <emil@etsalapatis.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg
Date: Sun, 19 Apr 2026 06:04:34 -1000	[thread overview]
Message-ID: <d74d5225acada39582429be8da2ff0cf@kernel.org> (raw)
In-Reply-To: <20260418092247.1541377-1-yphbchou0911@gmail.com>

Hello,

-d is dead code - it just sets dump_cgrps which is only echoed in the
status-line printf, nothing actually dumps the cgroup hierarchy. The
right thing to do is remove the whole thing - the 'd' in getopt(), case
'd':, the dump_cgrps variable and its printf - rather than document dead
code as a feature.

Want to spin a removal patch?

Thanks.

-- 
tejun

  reply	other threads:[~2026-04-19 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18  9:22 [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg Cheng-Yang Chou
2026-04-19 16:04 ` Tejun Heo [this message]
2026-04-19 16:08   ` Cheng-Yang Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d74d5225acada39582429be8da2ff0cf@kernel.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=chia7712@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=void@manifault.com \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.