From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CADAC001B0 for ; Mon, 24 Jul 2023 11:48:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A46466C1; Mon, 24 Jul 2023 13:47:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A46466C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690199286; bh=nkkTQMhHmzPV4+XcvmoQCvwm0WloI83UVn8Oj3behns=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qunCtkE4wvrHb+s1ArEyUrOa5gZ26Hc5PiaMFYJ/Xd7EqIY471s5vpaX4iGNx2xDJ GqvUDpvOn38jo1ZfftWtJYEPfhRWNI/cKsmwhi4W0L192LDeWqX5f2qt2owSJKAAFj MP2xaMpFKJ8WqYmkQAlEdQrvzJzadlzmyU8beI8k= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8ABFEF80578; Mon, 24 Jul 2023 13:46:32 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A5836F80558; Mon, 24 Jul 2023 13:46:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4BB37F80552; Mon, 24 Jul 2023 13:46:27 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9505BF80153; Mon, 24 Jul 2023 13:46:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9505BF80153 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jYIz0a5h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690199177; x=1721735177; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nkkTQMhHmzPV4+XcvmoQCvwm0WloI83UVn8Oj3behns=; b=jYIz0a5hrn2hZFbekRlZQQ4fmTF3618NciiVC5/Vpzy6T4cRsIIwIobw yBrfgQPfSJJxGnFONs/hIu0OWTSdfKcUpxmh+7l5mr3tWlCENUfYcphK1 WlUObX+R3W9w1ls/1NmFQcv9zEI84XVkAk5fTOGc5G7gMQ119xYIUeIzA NHqDFAhspiNKaAHu6/2bhAeCpQX7WSqu+BqIpmeiWT33xPg/0zLKkij09 QS0Yu32h5K2WqNRBIFHH65OuV2EcDirMwTX4C0JSyJ/eGpt7dsxVmm5A4 GO5oA4KsNAIeZ/DBMIGtAA+NR/9WNmy15+nurWBK9brhDW1F+qigQ1xJx Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="398322183" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="398322183" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 04:46:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="760761952" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="760761952" Received: from sosterlu-mobl.ger.corp.intel.com (HELO [10.249.37.56]) ([10.249.37.56]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 04:46:08 -0700 Message-ID: Date: Mon, 24 Jul 2023 12:25:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/9] ALSA: hda/i915: Allow override of gpu binding. Content-Language: en-US To: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= , Maarten Lankhorst , alsa-devel@alsa-project.org Cc: sound-open-firmware@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Liam Girdwood , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta References: <20230719164141.228073-1-maarten.lankhorst@linux.intel.com> <20230719164141.228073-3-maarten.lankhorst@linux.intel.com> <9b285ede-eaeb-40a2-086d-30cf74185784@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: <9b285ede-eaeb-40a2-086d-30cf74185784@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID-Hash: 37K6SEMNVFW3WZ6IDI2MCD7LSRDVE3GI X-Message-ID-Hash: 37K6SEMNVFW3WZ6IDI2MCD7LSRDVE3GI X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/21/23 14:19, Péter Ujfalusi wrote: > > > On 19/07/2023 19:41, Maarten Lankhorst wrote: >> Selecting CONFIG_DRM selects CONFIG_VIDEO_NOMODESET, which exports >> video_firmware_drivers_only(). This can be used as a first >> approximation on whether i915 will be available. It's safe to use as >> this is only built when CONFIG_SND_HDA_I915 is selected by CONFIG_I915. >> >> It's not completely fool proof, as you can boot with "nomodeset >> i915.modeset=1" to make i915 load regardless, or use >> "i915.force_probe=!*" to never load i915, but the common case of >> booting with nomodeset to disable all GPU drivers this will work as >> intended. >> >> Because of this, we add an extra module parameter, >> snd_hda_core.gpu_bind that can be used to signal users intent. >> -1 follows nomodeset, 0 disables binding, 1 forces wait/-EPROBE_DEFER >> on binding. > > Reviewed-by: Peter Ujfalusi > >> Signed-off-by: Maarten Lankhorst >> --- >> sound/hda/hdac_i915.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c >> index 161a9711cd63e..c32709fa4115f 100644 >> --- a/sound/hda/hdac_i915.c >> +++ b/sound/hda/hdac_i915.c >> @@ -11,6 +11,13 @@ >> #include >> #include >> >> +#include