From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 38/40] drm/i915/execlists: Flush the CS events before unpinning Date: Mon, 1 Oct 2018 11:51:23 +0100 Message-ID: References: <20180919195544.1511-1-chris@chris-wilson.co.uk> <20180919195544.1511-38-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8023089EA9 for ; Mon, 1 Oct 2018 10:51:25 +0000 (UTC) In-Reply-To: <20180919195544.1511-38-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA5LzIwMTggMjA6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbnNpZGUgdGhlIGV4 ZWNsaXN0cyBzdWJtaXNzaW9uIHRhc2tsZXQsIHdlIG9mdGVuIG1ha2UgdGhlIG1pc3Rha2Ugb2YK PiBhc3N1bWluZyB0aGF0IGV2ZXJ5dGhpbmcgYmVuZWF0aCB0aGUgcmVxdWVzdCBpcyBhdmFpbGFi bGUgZm9yIHVzZS4KPiBIb3dldmVyLCB0aGUgc3VibWlzc2lvbiBhbmQgdGhlIHJlcXVlc3QgbGl2 ZSBvbiB0d28gc2VwYXJhdGUgdGltZWxpbmVzLAo+IGFuZCB0aGUgcmVxdWVzdCBjb250ZW50cyBt YXkgYmUgZnJlZWQgZnJvbSBhbiBlYXJseSByZXRpcmVtZW50IGJlZm9yZSB3ZQo+IGhhdmUgaGFk IGEgY2hhbmNlIHRvIHJ1biB0aGUgc3VibWlzc2lvbiB0YXNrbGV0ICh0aGluayBrc29mdGlycWQp LiBUbwo+IHNhZmVndWFyZCBvdXJzZWx2ZXMgYWdhaW5zdCBhbnkgbWlzdGFrZXMsIGZsdXNoIHRo ZSB0YXNrbGV0IGJlZm9yZSB3ZQo+IHVucGluIHRoZSBjb250ZXh0IGlmIGV4ZWNsaXN0cyBzdGls bCBoYXMgYSByZWZlcmVuY2UgdG8gdGhpcyBjb250ZXh0Lgo+IAo+IFJlZmVyZW5jZXM6IDYwMzY3 MTMyYTIxNCAoImRybS9pOTE1OiBBdm9pZCB1c2UtYWZ0ZXItZnJlZSBvZiBjdHggaW4gcmVxdWVz dCB0cmFjZXBvaW50cyIpCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRl bC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0Lmgg fCAgMSArCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCAzMiAr KysrKysrKysrKysrKysrKysrKysrKystCj4gICAyIGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fY29udGV4dC5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29u dGV4dC5oCj4gaW5kZXggOWY4OTExOWE2NTY2Li4xZmQ3MWRmZGZhNjIgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5oCj4gQEAgLTE3MCw2ICsxNzAsNyBAQCBzdHJ1 Y3QgaTkxNV9nZW1fY29udGV4dCB7Cj4gICAJLyoqIGVuZ2luZTogcGVyLWVuZ2luZSBsb2dpY2Fs IEhXIHN0YXRlICovCj4gICAJc3RydWN0IGludGVsX2NvbnRleHQgewo+ICAgCQlzdHJ1Y3QgaTkx NV9nZW1fY29udGV4dCAqZ2VtX2NvbnRleHQ7Cj4gKwkJc3RydWN0IGludGVsX2VuZ2luZV9jcyAq YWN0aXZlOwo+ICAgCQlzdHJ1Y3QgaTkxNV92bWEgKnN0YXRlOwo+ICAgCQlzdHJ1Y3QgaW50ZWxf cmluZyAqcmluZzsKPiAgIAkJdTMyICpscmNfcmVnX3N0YXRlOwo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4gaW5kZXggNDhhMmJjYTdmZWMzLi5iZTdkYmRkN2ZjMmMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9scmMuYwo+IEBAIC0yODIsNiArMjgyLDggQEAgc3RhdGljIHZvaWQgX191bndp bmRfaW5jb21wbGV0ZV9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4g ICAJCV9faTkxNV9yZXF1ZXN0X3Vuc3VibWl0KHJxKTsKPiAgIAkJdW53aW5kX3dhX3RhaWwocnEp Owo+ICAgCj4gKwkJR0VNX0JVR19PTihycS0+aHdfY29udGV4dC0+YWN0aXZlKTsKPiArCj4gICAJ CUdFTV9CVUdfT04ocnFfcHJpbyhycSkgPT0gSTkxNV9QUklPUklUWV9JTlZBTElEKTsKPiAgIAkJ aWYgKHJxX3ByaW8ocnEpICE9IHByaW8pIHsKPiAgIAkJCXByaW8gPSBycV9wcmlvKHJxKTsKPiBA QCAtNDI3LDggKzQyOSwxMSBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfc3VibWl0X3BvcnRzKHN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkJcnEgPSBwb3J0X3VucGFjaygmcG9y dFtuXSwgJmNvdW50KTsKPiAgIAkJaWYgKHJxKSB7Cj4gICAJCQlHRU1fQlVHX09OKGNvdW50ID4g IW4pOwo+IC0JCQlpZiAoIWNvdW50KyspCj4gKwkJCWlmICghY291bnQrKykgewo+ICsJCQkJR0VN X0JVR19PTihycS0+aHdfY29udGV4dC0+YWN0aXZlKTsKPiAgIAkJCQlleGVjbGlzdHNfY29udGV4 dF9zY2hlZHVsZV9pbihycSk7Cj4gKwkJCQlycS0+aHdfY29udGV4dC0+YWN0aXZlID0gZW5naW5l OwoKUHV0IGl0IGluIGV4ZWNsaXN0c19jb250ZXh0X3NjaGVkdWxlX2luL291dD8KCldoeSBkb2Vz IGl0IGhhdmUgdG8gYmUgdGhlIGVuZ2luZSBwb2ludGVyIGFuZCBub3QganVzdCBhIGJvb2xlYW4/ IApCZWNhdXNlIHdlIGRvbid0IGhhdmUgYW4gZW5naW5lIGJhY2twb2ludGVyIGluIGh3X2NvbnRl eHQ/IFNob3VsZCB3ZSBhZGQgCml0PyBJIHRoaW5rIEkgaGFkIG9jY2FzaW9uYWxseSB3aXNoZWQg d2UgaGFkIGl0Li4gbWF5YmUgdG9vIG11Y2ggd29yayB0byAKZXZhbHVhdGUgd2hhdCBmdW5jdGlv biBwcm90b3R5cGVzIHdlIGNvdWxkIGNsZWFuIHVwIHdpdGggaXQgYW5kIHdoZXRoZXIgCml0IHdv dWxkIGJlIGFuIG92ZXJhbGwgZ2Fpbi4KCj4gKwkJCX0KPiAgIAkJCXBvcnRfc2V0KCZwb3J0W25d LCBwb3J0X3BhY2socnEsIGNvdW50KSk7Cj4gICAJCQlkZXNjID0gZXhlY2xpc3RzX3VwZGF0ZV9j b250ZXh0KHJxKTsKPiAgIAkJCUdFTV9ERUJVR19FWEVDKHBvcnRbbl0uY29udGV4dF9pZCA9IHVw cGVyXzMyX2JpdHMoZGVzYykpOwo+IEBAIC03MzQsNiArNzM5LDggQEAgZXhlY2xpc3RzX2NhbmNl bF9wb3J0X3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhl Y2xpc3RzKQo+ICAgCQkJICBpbnRlbF9lbmdpbmVfZ2V0X3NlcW5vKHJxLT5lbmdpbmUpKTsKPiAg IAo+ICAgCQlHRU1fQlVHX09OKCFleGVjbGlzdHMtPmFjdGl2ZSk7Cj4gKwo+ICsJCXJxLT5od19j b250ZXh0LT5hY3RpdmUgPSBOVUxMOwo+ICAgCQlleGVjbGlzdHNfY29udGV4dF9zY2hlZHVsZV9v dXQocnEsCj4gICAJCQkJCSAgICAgICBpOTE1X3JlcXVlc3RfY29tcGxldGVkKHJxKSA/Cj4gICAJ CQkJCSAgICAgICBJTlRFTF9DT05URVhUX1NDSEVEVUxFX09VVCA6Cj4gQEAgLTk3MSw2ICs5Nzgs NyBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX2NzYihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUpCj4gICAJCQkgKi8KPiAgIAkJCUdFTV9CVUdfT04oIWk5MTVfcmVxdWVzdF9jb21wbGV0ZWQo cnEpKTsKPiAgIAo+ICsJCQlycS0+aHdfY29udGV4dC0+YWN0aXZlID0gTlVMTDsKPiAgIAkJCWV4 ZWNsaXN0c19jb250ZXh0X3NjaGVkdWxlX291dChycSwKPiAgIAkJCQkJCSAgICAgICBJTlRFTF9D T05URVhUX1NDSEVEVUxFX09VVCk7Cj4gICAJCQlpOTE1X3JlcXVlc3RfcHV0KHJxKTsKPiBAQCAt MTA4MCw2ICsxMDg4LDI4IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19jb250ZXh0X2Rlc3Ryb3ko c3RydWN0IGludGVsX2NvbnRleHQgKmNlKQo+ICAgCj4gICBzdGF0aWMgdm9pZCBleGVjbGlzdHNf Y29udGV4dF91bnBpbihzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UpCj4gICB7Cj4gKwlzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gKwo+ICsJLyoKPiArCSAqIFRoZSB0YXNrbGV0IG1h eSBzdGlsbCBiZSB1c2luZyBhIHBvaW50ZXIgdG8gb3VyIHN0YXRlLCB2aWEgYW4KPiArCSAqIG9s ZCByZXF1ZXN0LiBIb3dldmVyLCBzaW5jZSB3ZSBrbm93IHdlIG9ubHkgdW5waW4gdGhlIGNvbnRl eHQKPiArCSAqIG9uIHJldGlyZW1lbnQgb2YgdGhlIGZvbGxvd2luZyByZXF1ZXN0LCB3ZSBrbm93 IHRoYXQgdGhlIGxhc3QKPiArCSAqIHJlcXVlc3QgcmVmZXJlbmNpbmcgdXMgd2lsbCBoYXZlIGhh ZCBhIGNvbXBsZXRpb24gQ1MgaW50ZXJydXB0LgoKSG0gaG0gaG0uLi4gbXkgaW5pdGlhbCB0aG91 Z2h0IHdhcyB0aGF0IGludGVycnVwdHMgY291bGQgYmUgbW9yZSBkZWxheWVkIAp0aGFuIGJyZWFk Y3J1bWIgd3JpdGVzIChtb3JlIHRoYW4gb25lIGNvbnRleHQgYWhlYWQpLCBpbiB3aGljaCBjYXNl IHRoZSAKcHJvY2Vzc19jc2IgYmVsb3cgY291bGQgYmUgcHJlbWF0dXJlIGFuZCB0aGUgYXNzZXJ0 IHdvdWxkIHRyaWdnZXIuIEJ1dCBJIAptdXN0IGJlIGZvcmdldHRpbmcgc29tZXRoaW5nIHNpbmNl IHRoYXQgd291bGQgYWxzbyBtZWFuIHdlIHdvdWxkIApwcmVtYXR1cmVseSB1bnBpbiB0aGUgY29u dGV4dC4gU28gSSBtdXN0IGJlIGZvcmdldHRpbmcgc29tZXRoaW5nLi4KClJlZ2FyZHMsCgpUdnJ0 a28KCj4gKwkgKiBJZiB3ZSBzZWUgdGhhdCBpdCBpcyBzdGlsbCBhY3RpdmUsIGl0IG1lYW5zIHRo YXQgdGhlIHRhc2tsZXQgaGFzbid0Cj4gKwkgKiBoYWQgdGhlIGNoYW5jZSB0byBydW4geWV0OyBs ZXQgaXQgcnVuIGJlZm9yZSB3ZSB0ZWFyZG93biB0aGUKPiArCSAqIHJlZmVyZW5jZSBpdCBtYXkg dXNlLgo+ICsJICovCj4gKwllbmdpbmUgPSBSRUFEX09OQ0UoY2UtPmFjdGl2ZSk7Cj4gKwlpZiAo dW5saWtlbHkoZW5naW5lKSkgewo+ICsJCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gKwo+ICsJCXNw aW5fbG9ja19pcnFzYXZlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsKPiArCQlwcm9j ZXNzX2NzYihlbmdpbmUpOwo+ICsJCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmVuZ2luZS0+dGlt ZWxpbmUubG9jaywgZmxhZ3MpOwo+ICsKPiArCQlHRU1fQlVHX09OKFJFQURfT05DRShjZS0+YWN0 aXZlKSk7Cj4gKwl9Cj4gKwo+ICAgCWk5MTVfZ2VtX2NvbnRleHRfdW5waW5faHdfaWQoY2UtPmdl bV9jb250ZXh0KTsKPiAgIAo+ICAgCWludGVsX3JpbmdfdW5waW4oY2UtPnJpbmcpOwo+IAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==