From: Hannes Reinecke <hare@suse.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
brauner@kernel.org, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, mcgrof@kernel.org,
gost.dev@samsung.com
Subject: Re: [RFC 0/4] convert create_page_buffers to create_folio_buffers
Date: Fri, 14 Apr 2023 15:56:19 +0200 [thread overview]
Message-ID: <d7bc4553-05c7-f4db-e38a-19980cec90d6@suse.de> (raw)
In-Reply-To: <ZDlaaJxjXFbh+xSI@casper.infradead.org>
On 4/14/23 15:51, Matthew Wilcox wrote:
> On Fri, Apr 14, 2023 at 03:47:13PM +0200, Hannes Reinecke wrote:
>> BTW; I've got another patch replacing 'writepage' with 'write_folio'
>> (and the corresponding argument update). Is that a direction you want to go?
>
> No; ->writepage is being deleted. It's already gone from ext4 and xfs.
Aw.
And here's me having converted block/fops over to using iomap w/
iomap_writepage(). Tough.
Oh well.
Wasn't a great fit anyway as for a sb_bread() replacement we would need
a sub-page access for iomap.
Question is whether we really need that or shouldn't read PAGE_SIZE
sectors always. Surely would make life easier. And would save us all the
logic with bh_lru etc as we can rely on the page cache.
But probably an item for the iomap discussion at LSF.
Unless you got plans already ...
Cheers,
Hannes
next prev parent reply other threads:[~2023-04-14 13:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230414110825eucas1p1ed4d16627889ef8542dfa31b1183063d@eucas1p1.samsung.com>
2023-04-14 11:08 ` [RFC 0/4] convert create_page_buffers to create_folio_buffers Pankaj Raghav
2023-04-14 11:08 ` [RFC 1/4] fs/buffer: add set_bh_folio helper Pankaj Raghav
2023-04-14 11:08 ` [RFC 2/4] buffer: add alloc_folio_buffers() helper Pankaj Raghav
2023-04-14 13:06 ` Matthew Wilcox
2023-04-14 15:01 ` Pankaj Raghav
2023-04-14 14:04 ` kernel test robot
2023-04-14 14:45 ` kernel test robot
2023-04-14 11:08 ` [RFC 3/4] fs/buffer: add folio_create_empty_buffers helper Pankaj Raghav
2023-04-14 13:16 ` Matthew Wilcox
2023-04-14 11:08 ` [RFC 4/4] fs/buffer: convert create_page_buffers to create_folio_buffers Pankaj Raghav
2023-04-14 13:21 ` Matthew Wilcox
2023-04-14 13:47 ` [RFC 0/4] " Hannes Reinecke
2023-04-14 13:51 ` Matthew Wilcox
2023-04-14 13:56 ` Hannes Reinecke [this message]
2023-04-14 15:00 ` Pankaj Raghav
2023-04-15 1:01 ` Luis Chamberlain
2023-04-15 2:31 ` Matthew Wilcox
2023-04-15 3:24 ` Luis Chamberlain
2023-04-15 3:44 ` Matthew Wilcox
2023-04-15 13:14 ` Hannes Reinecke
2023-04-15 17:09 ` Matthew Wilcox
2023-04-16 1:28 ` Luis Chamberlain
2023-04-16 3:40 ` Matthew Wilcox
2023-04-16 5:26 ` Luis Chamberlain
2023-04-16 14:07 ` Matthew Wilcox
2023-04-17 15:40 ` Darrick J. Wong
2023-04-16 22:57 ` Dave Chinner
2023-04-17 2:27 ` Luis Chamberlain
2023-04-17 6:04 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7bc4553-05c7-f4db-e38a-19980cec90d6@suse.de \
--to=hare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=gost.dev@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.