From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96580C001DE for ; Fri, 11 Aug 2023 02:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=at85l/74BDy3GzgiSunXsCZ4nxZlb4MQQvSFSBoStEM=; b=FAdls/sw9L2Rn7 5GsUckaG2aXNlnqnyvGQnTL2WNTTtnVzESek383dkU5RSw8NV4QKUb7+nL9fiPghxqMQX88c21P6m QU9w1oLnyiQlSPiABZ8AmD3PoNbikryWBFjKO4PFpjIEfngZsTmbaMQF92CHDQK/DRznyVu/+6SRs HeUDdE91P2W/UKle/AAGpd9CQpzlpvztZNbt33QY/Bq/cJ7Gdq4zHX3xix6aWp7K3V1GtJwuwc9Fm i3HCLlGiMWTlMnfzDyHsumwVpOCJeOs5GGTnGJ6V+ssRulPkKBf1ZQXPcVhuA9hL0ZUrUqIPo3nLm x5OHdfjPMu0cWLkNC1Dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUI3G-009Bid-0i; Fri, 11 Aug 2023 02:38:58 +0000 Received: from out-118.mta0.migadu.com ([91.218.175.118]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUI3D-009Bhf-0R for linux-arm-kernel@lists.infradead.org; Fri, 11 Aug 2023 02:38:57 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691721531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f0UWXP0oSE67vFnh9XOEDFZVA8Iyap9YePKn5P2Rhhw=; b=ThcjeZnfx8DIGxXHHN4A1Vixa/7OFrsqcjxoMNsz6gw1jf8Gy5bzrLWBpHvkLj9/pyp6Hg 3P/edRVUySdVUYBvRue5gOxVM5FfP6iL6HNMwcnUp1Lch9NdDLzwW80pa07b6DPYfy9NEp ImydhBaWsOb9/SvnwjKSxkTPFYibm1Q= Date: Fri, 11 Aug 2023 10:38:39 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] arm64: mm: use ptep_clear() instead of pte_clear() in clear_flush() Content-Language: en-US To: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, pasha.tatashin@soleen.com, muchun.song@linux.dev, wangkefeng.wang@huawei.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230810093241.1181142-1-qi.zheng@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: <20230810093241.1181142-1-qi.zheng@linux.dev> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_193855_600529_DC1F3ABC X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I wrote wrong Kefeng's email address before, correct it now. On 2023/8/10 17:32, Qi Zheng wrote: > From: Qi Zheng > > In clear_flush(), the original pte may be a present entry, so we should > use ptep_clear() to let page_table_check track the pte clearing operation, > otherwise it may cause false positive in subsequent set_pte_at(). > > Fixes: 42b2547137f5 ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK") > Signed-off-by: Qi Zheng > --- > arch/arm64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 21716c940682..9c52718ea750 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -236,7 +236,7 @@ static void clear_flush(struct mm_struct *mm, > unsigned long i, saddr = addr; > > for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) > - pte_clear(mm, addr, ptep); > + ptep_clear(mm, addr, ptep); > > flush_tlb_range(&vma, saddr, addr); > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F679C001DE for ; Fri, 11 Aug 2023 02:38:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229831AbjHKCi4 (ORCPT ); Thu, 10 Aug 2023 22:38:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjHKCiy (ORCPT ); Thu, 10 Aug 2023 22:38:54 -0400 Received: from out-106.mta0.migadu.com (out-106.mta0.migadu.com [91.218.175.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41F432D48 for ; Thu, 10 Aug 2023 19:38:53 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691721531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f0UWXP0oSE67vFnh9XOEDFZVA8Iyap9YePKn5P2Rhhw=; b=ThcjeZnfx8DIGxXHHN4A1Vixa/7OFrsqcjxoMNsz6gw1jf8Gy5bzrLWBpHvkLj9/pyp6Hg 3P/edRVUySdVUYBvRue5gOxVM5FfP6iL6HNMwcnUp1Lch9NdDLzwW80pa07b6DPYfy9NEp ImydhBaWsOb9/SvnwjKSxkTPFYibm1Q= Date: Fri, 11 Aug 2023 10:38:39 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] arm64: mm: use ptep_clear() instead of pte_clear() in clear_flush() Content-Language: en-US To: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, pasha.tatashin@soleen.com, muchun.song@linux.dev, wangkefeng.wang@huawei.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230810093241.1181142-1-qi.zheng@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: <20230810093241.1181142-1-qi.zheng@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I wrote wrong Kefeng's email address before, correct it now. On 2023/8/10 17:32, Qi Zheng wrote: > From: Qi Zheng > > In clear_flush(), the original pte may be a present entry, so we should > use ptep_clear() to let page_table_check track the pte clearing operation, > otherwise it may cause false positive in subsequent set_pte_at(). > > Fixes: 42b2547137f5 ("arm64/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK") > Signed-off-by: Qi Zheng > --- > arch/arm64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 21716c940682..9c52718ea750 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -236,7 +236,7 @@ static void clear_flush(struct mm_struct *mm, > unsigned long i, saddr = addr; > > for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) > - pte_clear(mm, addr, ptep); > + ptep_clear(mm, addr, ptep); > > flush_tlb_range(&vma, saddr, addr); > }