All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stiffler, Jacob" <j-stiffler@ti.com>
To: "meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: [master/zeus/thud][PATCH] docker: install init script if sysvinit
Date: Mon, 10 Feb 2020 13:13:18 +0000	[thread overview]
Message-ID: <d7c77ce1fe3543b78c0e9022ea3ae2ef@ti.com> (raw)
In-Reply-To: <1581339695-31008-1-git-send-email-j-stiffler@ti.com>

I checked again, and this is only applicable for thud.

Based on inspection, the issue has persisted into zeus and master, but the recipe names have changed.

- Jake

> -----Original Message-----
> From: Stiffler, Jacob
> Sent: Monday, February 10, 2020 8:02 AM
> To: meta-arago@arago-project.org
> Cc: Stiffler, Jacob
> Subject: [master/zeus/thud][PATCH] docker: install init script if sysvinit
> 
> The docker recipe in meta-virtualization has conflicting logic for
> when to install and when to enable the docker initscript. When both
> systemd and sysvinit are in DISTRO_FEATURES, this causes the docker
> postinst to fail, which now fails the rootfs task.
> 
> Here we install the initscript only based on if sysvinit is in the
> DISTRO_FEATURES.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
>  meta-arago-distro/recipes-containers/docker/docker_git.bbappend | 8
> ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 meta-arago-distro/recipes-
> containers/docker/docker_git.bbappend
> 
> diff --git a/meta-arago-distro/recipes-
> containers/docker/docker_git.bbappend b/meta-arago-distro/recipes-
> containers/docker/docker_git.bbappend
> new file mode 100644
> index 0000000..dbb7b04
> --- /dev/null
> +++ b/meta-arago-distro/recipes-containers/docker/docker_git.bbappend
> @@ -0,0 +1,8 @@
> +PR_append = ".tisdk0"
> +
> +do_install_append() {
> +	if
> ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
> +		install -d ${D}${sysconfdir}/init.d
> +		install -m 0755 ${WORKDIR}/docker.init
> ${D}${sysconfdir}/init.d/docker.init
> +	fi
> +}
> --
> 1.9.1



      reply	other threads:[~2020-02-10 13:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10 13:01 [master/zeus/thud][PATCH] docker: install init script if sysvinit Jacob Stiffler
2020-02-10 13:13 ` Stiffler, Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7c77ce1fe3543b78c0e9022ea3ae2ef@ti.com \
    --to=j-stiffler@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.