From: Ping-Ke Shih <pkshih@realtek.com>
To: Enver Ikromov <owner@ph4ntom-rev.uz>
Cc: Zong-Zhe Yang <kevin_yang@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v7 1/5] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx()
Date: Thu, 19 Nov 2026 07:08:49 +0000 [thread overview]
Message-ID: <d7e6871d86014de2a27f2d09dbb5b0fc@realtek.com> (raw)
In-Reply-To: <20261118180435.904-2-owner@ph4ntom-rev.uz>
Enver Ikromov <owner@ph4ntom-rev.uz> wrote:
> Injecting a raw frame on a passive monitor interface while a station or
> AP interface is also up causes a kernel NULL pointer dereference,
> because mac80211 has no virtual monitor vif in concurrent mode and
> passes a NULL vif to the driver TX path.
>
> Check the vif pointer with vif_to_rtwvif_safe() and drop frames without
> a vif.
>
> Fixes: a0e97ae3f332 ("wifi: rtw89: add ieee80211::remain_on_channel ops")
I think this problem is existing from initial commit:
Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Enver Ikromov <owner@ph4ntom-rev.uz>
Otherwise, looks good to me:
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2026-11-19 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 18:04 [PATCH rtw-next v7 0/5] wifi: rtw89: monitor mode and raw frame injection fixes Enver Ikromov
2026-11-18 18:04 ` [PATCH rtw-next v7 1/5] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
2026-11-19 7:08 ` Ping-Ke Shih [this message]
2026-11-18 18:04 ` [PATCH rtw-next v7 2/5] wifi: rtw89: handle negative rate index for injected frames Enver Ikromov
2026-11-19 7:11 ` Ping-Ke Shih
2026-11-18 18:04 ` [PATCH rtw-next v7 3/5] wifi: rtw89: restore channel when leaving idle on non-chanctx devices Enver Ikromov
2026-11-19 5:13 ` Zong-Zhe Yang
2026-11-19 7:14 ` Ping-Ke Shih
2026-11-18 18:04 ` [PATCH rtw-next v7 4/5] wifi: rtw89: avoid reading seq_ctrl on control frames Enver Ikromov
2026-11-19 7:17 ` Ping-Ke Shih
2026-11-19 7:35 ` Ping-Ke Shih
2026-11-18 18:04 ` [PATCH rtw-next v7 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames Enver Ikromov
2026-11-19 7:27 ` Ping-Ke Shih
2026-11-19 8:02 ` Enver Ikromov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7e6871d86014de2a27f2d09dbb5b0fc@realtek.com \
--to=pkshih@realtek.com \
--cc=kevin_yang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=owner@ph4ntom-rev.uz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.