From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MHhTR-0001gL-B0 for mharc-grub-devel@gnu.org; Fri, 19 Jun 2009 13:01:57 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHhTO-0001fj-Ap for grub-devel@gnu.org; Fri, 19 Jun 2009 13:01:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHhTJ-0001fW-Qf for grub-devel@gnu.org; Fri, 19 Jun 2009 13:01:54 -0400 Received: from [199.232.76.173] (port=51302 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHhTJ-0001fT-LZ for grub-devel@gnu.org; Fri, 19 Jun 2009 13:01:49 -0400 Received: from mail-fx0-f224.google.com ([209.85.220.224]:43505) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MHhTI-00055s-W9 for grub-devel@gnu.org; Fri, 19 Jun 2009 13:01:49 -0400 Received: by fxm24 with SMTP id 24so2594369fxm.42 for ; Fri, 19 Jun 2009 10:01:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=Q/p2lvD8ZG8PZtBr3JbMcp3tRirTdUkymNcRilBtRhk=; b=Xi5klqMKJE3rbnf2XUkR9/wx6FbmwsnIWX854mDZjfN6uOvdJ4hEj+hfAqnQgDZw7u fHOm8mAbY9Y82P9r6O8KCVnsNZrlaMA/q0ioRy5L6wHe1eFFV5q0A4re94x5KFNNC20m 4xeysAIqx5SWt3cNmcTMkTYr3MD+uF4d4zu1c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=SohCGanEIO2Q//W9LmlNLQHgFYN3OE+hP2WfyT/FeNF99qrKY2AZ8tt8fDQSZ2wrSz QjWqiuj3GA5TCBPbJMFh08CJeLBV3fpRFq8ef9VNWhmLh7HOb1w3AwFsS2t6FPRWa4tZ Gau6PyWdBdtwgszbf2xqf6U9lfJHKmy0wGqjY= MIME-Version: 1.0 Received: by 10.204.116.9 with SMTP id k9mr2723727bkq.164.1245430907745; Fri, 19 Jun 2009 10:01:47 -0700 (PDT) In-Reply-To: <1245429440.28417.29.camel@mj> References: <1245429440.28417.29.camel@mj> Date: Fri, 19 Jun 2009 19:01:47 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: multipart/alternative; boundary=0016368e2b1dd936f9046cb67a3b X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Proposal for GNU indent compatibility X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2009 17:01:54 -0000 --0016368e2b1dd936f9046cb67a3b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Fri, Jun 19, 2009 at 6:37 PM, Pavel Roskin wrote: > Hello! > > In order to encourage developers to use proper indentation on the newly > added code, I suggest that we accept the default style of GNU indent. I agree with proposition > > That is, the space after "!" should not be needed. That's the only > difference I'm aware of. > I ran indent on whole codebase. It failed on ./lib/LzmaDec.c and ./script/lua/lvm.c and issued warnings on ./script/lua/ldump.c and ./script/lua/lundump.c It made following changes. 1) Cut long lines. Not always in a sensible place 2) Added a space before parenthesis in __attribute__ ((...)) 3) Put newlines after ^L, not around 4) Removed space after ! 5) Fixed spaces 6) Added spaces before comment if comment shares a line with code 7) Merged short lines in arguments 8) Removed spaces before labels 9) Added a space after & 10) in initializations like a = { .. }; it has put { on new line and without spacing Perhaps something more. The patch would be 77280 lines. If someone there would be a way to check indent doen't introduce bugs we could run it sometimes on all .c files. > > Running indent on the code and then adding spaces after "!" is > ridiculous, in my opinion. GRUB and indent are both GNU programs, it > should not be needed to do such things. > > That doesn't mean that we should start reformatting the existing code. > Neither does it mean that it's acceptable to submit code that GNU indent > failed to format nicely. > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git --0016368e2b1dd936f9046cb67a3b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Fri, Jun 19, 2009 at 6:37 PM, Pavel R= oskin <proski@gnu.or= g> wrote:
Hello!

In order to encourage developers to use proper indentation on the newly
added code, I suggest that we accept the default style of GNU indent.
I agree with proposition

That is, the space after "!" should not be needed. =A0That's = the only
difference I'm aware of.
I ran indent on whole codebase. It failed on ./lib/LzmaD= ec.c and ./script/lua/lvm.c and issued warnings on=A0 ./script/lua/ldump.c = and=A0 ./script/lua/lundump.c
It made following changes.
1) Cut long = lines. Not always in a sensible place
2) Added a space before parenthesis in __attribute__ ((...))
3) Put newl= ines after ^L, not around
4) Removed space after !
5) Fixed spaces6) Added spaces before comment if comment shares a line with code
7) Merged short lines in arguments
8) Removed spaces before labels
9)= Added a space after &
10) in initializations like
a =3D {
..<= br>};
it has put { on new line and without spacing
Perhaps something = more. The patch would be 77280 lines. If someone there would be a way to ch= eck indent doen't introduce bugs we could run it sometimes on all .c fi= les.

Running indent on the code and then adding spaces after "!" is ridiculous, in my opinion. =A0GRUB and indent are both GNU programs, it
should not be needed to do such things.

That doesn't mean that we should start reformatting the existing code.<= br> Neither does it mean that it's acceptable to submit code that GNU inden= t
failed to format nicely.

--
Regards,
Pavel Roskin


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel



--
Regards
Vladimir = 9;phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git<= br> --0016368e2b1dd936f9046cb67a3b--