From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MXiz5-0000O4-6j for mharc-grub-devel@gnu.org; Sun, 02 Aug 2009 17:52:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXiz3-0000Kh-1x for grub-devel@gnu.org; Sun, 02 Aug 2009 17:52:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXiyy-0000Fq-Ii for grub-devel@gnu.org; Sun, 02 Aug 2009 17:52:48 -0400 Received: from [199.232.76.173] (port=46528 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXiyy-0000Fn-G0 for grub-devel@gnu.org; Sun, 02 Aug 2009 17:52:44 -0400 Received: from mail-bw0-f222.google.com ([209.85.218.222]:63122) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXiyy-0008RS-1v for grub-devel@gnu.org; Sun, 02 Aug 2009 17:52:44 -0400 Received: by bwz22 with SMTP id 22so2777963bwz.42 for ; Sun, 02 Aug 2009 14:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=/Zej63tQRboJJwuNcCU4Ji60WhrmWPkCcs9HRVf3kl4=; b=xp23haFJRDAlo0DSzP3wRY34rAxqOOo2+DK6FCfeLoxwTyx7B4clLrHhT3zcdYVEW5 vStY9IxboxSW5Ghfw2Muj2nJjWvjq/ZAjfQiCWWgRZOIrjYZEQ8BFIBzRx446OwcWZsl aIS45apjxdBAcAYQsknVq2e8j80ugEmTpbJXg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=W5mvXaCDlK7SfrUi9bNE1ZCt1bTFRFH0UevoMX334r9Xsmnj8lYp1FgRAqYXtzkPwC 4J3fHNurPSHhNXcFmsvP1gvSO3rVQm+WJn7zvo0SblVOORG5hKHGL+fxlRu/iNxKhrqL 4vUwWDGpYI3zSnsBV6K7u+bpr4Wcmi7OH2mK4= MIME-Version: 1.0 Received: by 10.204.118.12 with SMTP id t12mr6369671bkq.158.1249249963035; Sun, 02 Aug 2009 14:52:43 -0700 (PDT) In-Reply-To: <20090802214352.GF15139@thorin> References: <1248392495.2661.208.camel@mj> <20090801150118.GB23133@thorin> <20090802214352.GF15139@thorin> Date: Sun, 2 Aug 2009 23:52:42 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Fwd: [PATCH 1/2] Framebuffer split X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Aug 2009 21:52:49 -0000 >> >> +#define grub_video_render_target grub_video_fbrender_target >> > >> > If we want to rename this function, I'd rather do it all the way than >> > keeping a compatibility macro. =A0But then, I'd also prefer if this is >> > done separately from the rest (either before or after). >> > >> It's not about renaming but to inform includes that >> grub_video_render_target is in fact grub_video_fbrender_target and so >> avoid warnings and casts. > > I don't understand this. =A0If we want to settle with grub_video_render_t= arget > why don't we just provide that function directly? =A0Or is this making ro= om > for an additional layer later on? It's for abstraction we already have. Most of video subsystem doesn't care whether render_target is framebuffer, OpenGL or network commands. In this particular case we know that we're rendering to a framebuffer and so function do_something (grub_video_render_target *my_render_target); like it's used by upper layers is inded the same as do_something (grub_video_fbrender_target *my_render_target); and not e.g. do_something (grub_video_glrender_target *my_render_target); > > -- > Robert Millan > > =A0The DRM opt-in fallacy: "Your data belongs to us. We will decide when = (and > =A0how) you may access your data; but nobody's threatening your freedom: = we > =A0still allow you to remove your data and not access it at all." > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git