From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MabQO-0000RR-Kf for mharc-grub-devel@gnu.org; Mon, 10 Aug 2009 16:24:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MabQM-0000QQ-5N for grub-devel@gnu.org; Mon, 10 Aug 2009 16:24:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MabQH-0000Oe-9i for grub-devel@gnu.org; Mon, 10 Aug 2009 16:24:53 -0400 Received: from [199.232.76.173] (port=38432 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MabQH-0000Oa-56 for grub-devel@gnu.org; Mon, 10 Aug 2009 16:24:49 -0400 Received: from mail-bw0-f222.google.com ([209.85.218.222]:44051) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MabQG-0005dx-J0 for grub-devel@gnu.org; Mon, 10 Aug 2009 16:24:48 -0400 Received: by bwz22 with SMTP id 22so3094215bwz.42 for ; Mon, 10 Aug 2009 13:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=pGQGyG5Gi2Gt6x8QKNFMA6V+LTWcB0HdYPY8hIuuHgg=; b=UDnapBK+IcCXG8TeDpIsu/2v/f7m9V56PhFsY3d60U9+HCeuDpwp3wpcH1Q4lVbWYb DkZC/QGDzZBGEXKG8nDyGouRB/2TtAPUQHtzMrf1m2f9e3oleyL4L8dF8PxlaPs8GKIe ZDgDiVXm4thpSgIdnQwnCp8ZkYb20tV0fkyl8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=mMoX0yaRB6MbNRrwNMCzDWTHjI26wKW/X/kru1wT8qXy+jpfNgvvy9WMm8yGIUcey3 70eVdIcrp+x9pkajTF5es0I6B0Www2xYBYi5pYWr8iyitG7Zr+e0FEcUL3ISDewEkibh YJohBJU4XlU5zNGrGjDGzSp4syLvIQ0LE/l9M= MIME-Version: 1.0 Received: by 10.204.123.77 with SMTP id o13mr3384279bkr.92.1249935887542; Mon, 10 Aug 2009 13:24:47 -0700 (PDT) In-Reply-To: <20090810201655.GG11691@riva.ucam.org> References: <20090810110102.GP11691@riva.ucam.org> <20090810152725.GC11134@thorin> <20090810161841.GB11691@riva.ucam.org> <20090810201655.GG11691@riva.ucam.org> Date: Mon, 10 Aug 2009 22:24:47 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Improve handling of "keep" in gfxpayload X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2009 20:24:54 -0000 On Mon, Aug 10, 2009 at 10:16 PM, Colin Watson wrote: > On Mon, Aug 10, 2009 at 10:01:06PM +0200, Vladimir 'phcoder' Serbinenko w= rote: >> If these numbers are still needed it needs to be uniform between >> gfxpayload=3D1024x768 or gfxpayload=3Dkeep + gfxmode=3D1024x768. Derive = the >> number from video mode information if you really need it > > I couldn't find terribly clear documentation of "keep". Isn't the point > that if you say "keep" then the mode is carried over to the booted > kernel, and if you don't then it isn't? If my understanding is correct > then that would mean that there's no point setting up vid_mode to match > gfxpayload unless "keep" is given. > "keep" is a GRUB directive and mean "try to use the mode already set to boot kernel". Kernel has no need to know if video mode was set specifically for it or kept from grub operation, only what the mode is. So kernel shouldn't be able to distinguish between: insmod vbe set gfxmode=3D1024x768 terminal_output.gfxterm set gfxpayload=3Dkeep linux /vmlinuz and insmod vbe set gfxpayload=3D1024x768 linux /vmlinuz > -- > Colin Watson =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 [cjwatson@ubuntu.com] > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git