From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mbh2V-0007oK-01 for mharc-grub-devel@gnu.org; Thu, 13 Aug 2009 16:36:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mbh2T-0007mL-Gg for grub-devel@gnu.org; Thu, 13 Aug 2009 16:36:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mbh2O-0007dU-Ku for grub-devel@gnu.org; Thu, 13 Aug 2009 16:36:44 -0400 Received: from [199.232.76.173] (port=50053 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mbh2O-0007d9-G5 for grub-devel@gnu.org; Thu, 13 Aug 2009 16:36:40 -0400 Received: from mail-bw0-f218.google.com ([209.85.218.218]:37607) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mbh2O-0006Nc-13 for grub-devel@gnu.org; Thu, 13 Aug 2009 16:36:40 -0400 Received: by bwz18 with SMTP id 18so812550bwz.31 for ; Thu, 13 Aug 2009 13:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=hvRUj2oMvfWLtI7tbCx0KcjFiNTjItXpICH4OJls76c=; b=anHjP8reSYQNR9EKGeQpa/03lzizmS7iQTu1zjrIXyPuSWy0CH+mcRLFnnVEEdHL4Y Q4nMoUgaj6WTX9w0x4NiKeDyLCV/5B3dHTGhNL7kwv0fOdaIwaSoZjPqpD49v6dvhaps xnSJere6TxOqwchVNrJcY6tsXkHmxRpLwyjQg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=n8iobCWCQGkP8uPyHPzwkcPkYjs2hMteZE/mj5eWYfQ6Z2Vs0UCEN95idUGZp3LsO+ f2KwIgdnDmLVG52HQ0CV9hkkYWOHuZX3wWz2Au0xAMS8iPY8xxRXLxR0AjL9pbrbQErv reT0c+vL3CLMLtCdBFt9up3D2htr6uU6n/IA8= MIME-Version: 1.0 Received: by 10.204.34.14 with SMTP id j14mr837950bkd.55.1250195797361; Thu, 13 Aug 2009 13:36:37 -0700 (PDT) In-Reply-To: <20090813194103.GA22130@thorin> References: <20090813194103.GA22130@thorin> Date: Thu, 13 Aug 2009 22:36:37 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Fwd: [PATCH 1/2] Framebuffer split X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 20:36:45 -0000 > Please go ahead (I assume it raises no warnings and it's well tested). I tested the latest version with gfxterm and xnu loader. I use previous version in my daily bootloader. I'll run another series of tests before comitting. > > One small detail: > >> + =A0grub_free (mode_list); >> + =A0mode_list =3D 0; > > I would prefer if we used NULL for pointers. =A0I know we don't do that > everywhere, but it makes code easier to understand. >From GCS: "Zero without a cast is perfectly fine as a null pointer constant, except when calling a varargs function. " > > -- > Robert Millan > > =A0The DRM opt-in fallacy: "Your data belongs to us. We will decide when = (and > =A0how) you may access your data; but nobody's threatening your freedom: = we > =A0still allow you to remove your data and not access it at all." > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git