From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MbwlZ-0006rp-2X for mharc-grub-devel@gnu.org; Fri, 14 Aug 2009 09:24:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbwlX-0006rE-Jp for grub-devel@gnu.org; Fri, 14 Aug 2009 09:24:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbwlS-0006p5-Q2 for grub-devel@gnu.org; Fri, 14 Aug 2009 09:24:19 -0400 Received: from [199.232.76.173] (port=40129 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbwlS-0006ov-J7 for grub-devel@gnu.org; Fri, 14 Aug 2009 09:24:14 -0400 Received: from mail-fx0-f219.google.com ([209.85.220.219]:42205) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MbwlR-0005n6-Vy for grub-devel@gnu.org; Fri, 14 Aug 2009 09:24:14 -0400 Received: by fxm19 with SMTP id 19so1134560fxm.2 for ; Fri, 14 Aug 2009 06:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=J11LNXhJGFBnLRrvIoRRASvOz/nEyK/YRadHiGkd/Kc=; b=sQYrMYZF/j8Qu94a7psnlsdF3cTZ0j+7WrMo0vaQ8DIS2R0ucHiIC03/Sf5wbUhsvI Gifk8CweFYy7hVKug/4D40hgWwU7/GG4GUMrf78UvdNdiC40FFtowVaBWxFU0zx3wBog VYKr23FYJPDCJPMJstOJAmTOX9dELByzedxMQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=ntX7BOeSnUYQvkD2bKfR+YjB0heF/Xy/aSJV/iBGK3sFcradfNhGw7IWYgcf7jwmL3 z0B9/N/OmivPSATJwDV4oB61XgDGaPoWYemlSVuMEKsG1hSdJrLOCxYnvpG0z3/mA+PO NROah6siZC+lXnS4K9qedbbjWltr4n2FTwRxE= MIME-Version: 1.0 Received: by 10.204.18.145 with SMTP id w17mr1190883bka.42.1250256252611; Fri, 14 Aug 2009 06:24:12 -0700 (PDT) In-Reply-To: References: Date: Fri, 14 Aug 2009 15:24:12 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Fwd: [PATCH 1/2] Framebuffer split X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Aug 2009 13:24:19 -0000 On Fri, Aug 14, 2009 at 3:23 PM, Vladimir 'phcoder' Serbinenko wrote: > Framebuffer patch comitted and I removed framebuf branch on my repo. >> >> OK, I did not get why fbfill.h of the three private headers. >> >> Perhaps fbutil.h which already declares blit_info would be a better plac= e then. >> > I haven't looked in depth how private headers were organised, I just > moved the same layout to fb*. Perhaps we need only one framebuffer > private header now >>>> In grub_video_vbe_setup function in vbe.c the default palette is >>>> loaded before the created render target is set as active. I guess this >>>> would be a problem if the palette was actually needed/supported. >>>> Changing the order to create, set_active, set_palette makes the code >>>> fail for me,though. >>> Works for me. Have you forgotten about 'return' ? >> >> Yes, perhaps I did something wrong when reordering the calls for the fir= st time. >> > It's already reordered in comitted version >>>> >>>> In this same code struct grub_video_mode_info mode_info is added in >>>> the last round of patches but I cannot find where the changed code >>>> touches the variable. This is somewhat odd. >>> grep is your friend: >>> =A0 =A0 =A0framebuffer.mode_info.width =3D active_mode_info.x_resolutio= n; >>> and follows. Since now vbe.c can't manipulate directly the target. >>> Again, you're the one who requested encapsulation. >> >> Sorry, I just confused the >> grub_video_mode_info mode_info >> with the >> grub_vbe_mode_info_block mode_info >> >> Perhaps a more distinctive name for the latter would be helpful, though. >> > I'm ok with rename. >> This is a patch against the current (as far as git knows) framebuf branc= h: > This branch doesn't exist anymore since it's upstream ;) >> >> =A0 =A0* move video_fb_fender_target structure declaration to fbutil.h > Requires me to looks at how three headers are organised. >> =A0 =A0* remove duplicate assignment in create_render_target_from_pointe= r >> =A0 =A0 =A0 + quiet warning > Is already done in committed version >> =A0 =A0* rename local variable in grub_video_vbe_setup > Good >> =A0 =A0* remove grub_video_fb_get_video_ptr from video_fb.c (dup in fbut= il.c) > Good patch too >> >> Take which you want >> > Could you send them as separate patches with changelogs? It's > especially important in your case since you have no copyright > assignment yet and we have to decide which patches can go in without > such. I'm not maintainer so I need explicit consent from them to apply > your patches before you sign copyright assignment And please consider this thread closed and post your patches in a new threa= d >> Thanks >> >> Michal >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> http://lists.gnu.org/mailman/listinfo/grub-devel >> >> > > > > -- > Regards > Vladimir 'phcoder' Serbinenko > > Personal git repository: http://repo.or.cz/w/grub2/phcoder.git > --=20 Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git