From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MdT1B-0004C9-Gi for mharc-grub-devel@gnu.org; Tue, 18 Aug 2009 14:02:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdT19-0004BX-KU for grub-devel@gnu.org; Tue, 18 Aug 2009 14:02:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdT14-00049d-LF for grub-devel@gnu.org; Tue, 18 Aug 2009 14:02:43 -0400 Received: from [199.232.76.173] (port=39425 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdT14-00049X-Fv for grub-devel@gnu.org; Tue, 18 Aug 2009 14:02:38 -0400 Received: from mail-bw0-f218.google.com ([209.85.218.218]:46927) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MdT13-0008Im-Lq for grub-devel@gnu.org; Tue, 18 Aug 2009 14:02:37 -0400 Received: by bwz18 with SMTP id 18so3017006bwz.31 for ; Tue, 18 Aug 2009 11:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=7Jys21KRw5Z5tMkULJmHOjZlQbaYdlu6LhNraYF1fhQ=; b=dplqbXFdGF33KTC/oHx7vO7NZM7wwSNL5yHYo77NCSy+qLRu8jWny7caGagKXHc1Ka 7Ls36n8vlKTppCzh8yodU1gXQVju6cTaNRxJodxFLrqGfFXF/A3L2sFAavU0FeLXTqJr /9eqzY4vy1gdSVq39m7eWu9tL8thl0MDbAyCE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=iHl2D/Vr02nCP5FmpkGxh7lhRWDDbasv93PokLM0vMTjPYmUxkI8ZZqqORUEh2UcG0 tKP99gFUK/i9qIhfnf4mjvFyotZP2qQeSCXvfDh10CtB0uBznzCm+ka03JPHeP/z92YP TLdCn6UMOBouQ7Gd0QJumr3BmidJBAHB616tU= MIME-Version: 1.0 Received: by 10.204.30.195 with SMTP id v3mr4002296bkc.46.1250618555336; Tue, 18 Aug 2009 11:02:35 -0700 (PDT) In-Reply-To: References: <20090817134639.GJ32551@thorin> Date: Tue, 18 Aug 2009 20:02:35 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [GITGRUB] FB driver for EFI X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2009 18:02:44 -0000 +grub_uint32_t uga_fb; +grub_uint32_t uga_pitch; + Why are these variables global? They should be either static or properly prefixed. Have you tried linux_video_setup as present in i386/linux.c in i386/efi/linux.c ? It would be nice if we could share more code between these 2 files. If it works and you judge that i386/linux.c and i386/efi/linux.c are similar enough you can merge them using ifdef's when needed -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git