All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kamlesh Gurudasani <kamlesh@ti.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator
Date: Mon, 17 Jun 2024 17:51:49 +0200	[thread overview]
Message-ID: <d7eb6b3b-13b5-4587-a2f1-83fe3b30dc21@kernel.org> (raw)
In-Reply-To: <20240617-crytpo-am62a-v1-1-ddb719aed71b@ti.com>

On 17/06/2024 12:22, Kamlesh Gurudasani wrote:
> Add the node for sa3ul crypto accelerator.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index ce4a2f105630..298d0c91fc0a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -216,6 +216,18 @@ k3_reset: reset-controller {
>  		};
>  	};
>  
> +	crypto: crypto@40900000 {
> +		compatible = "ti,am62-sa3ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;

Why do you need ranges? No children here.

Anyway, keep the order as in DTS coding style.


Best regards,
Krzysztof



  reply	other threads:[~2024-06-17 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 10:22 [PATCH] arm64: dts: ti: k3-am62a-main: Enable crypto accelerator Kamlesh Gurudasani
2024-06-17 15:51 ` Krzysztof Kozlowski [this message]
2024-06-18 11:15   ` Kamlesh Gurudasani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7eb6b3b-13b5-4587-a2f1-83fe3b30dc21@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=kamlesh@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.