From: Derrick Stolee <derrickstolee@github.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 4/4] dir.c: avoid "exceeds maximum object size" error with GCC v12.x
Date: Wed, 25 May 2022 09:39:53 -0400 [thread overview]
Message-ID: <d7ee0bf0-22bc-d494-2699-7075fc92f28a@github.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2205242302020.352@tvgsbejvaqbjf.bet>
On 5/24/2022 5:05 PM, Johannes Schindelin wrote:> On Tue, 24 May 2022, Ævar Arnfjörð Bjarmason wrote:
>> On Tue, May 24 2022, Johannes Schindelin via GitGitGadget wrote:
>>> + /*
>>> + * It should not be possible to overflow `ptrdiff_t` by passing in an
>>> + * insanely long URL, but GCC does not know that and will complain
>>> + * without this check.
>>> + */
>>> + if (end - start < 0)
>>> + die(_("No directory name could be guessed.\n"
>>
>> This should start with a lower-case letter, see CodingGuidelines.
>
> This message is copied from existing code later in the same function.
> Since it is a translateable message, I do not want to edit it because that
> would cause unnecessary work of the translators. Especially given that we
> do not even expect this message to be shown, ever, but we only add this
> hunk for GCC's benefit.
Perhaps this should be a BUG() statement, then? Without any
translation?
Thanks,
-Stolee
next prev parent reply other threads:[~2022-05-25 13:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 0:23 [PATCH 0/4] ci: fix windows-build with GCC v12.x Johannes Schindelin via GitGitGadget
2022-05-24 0:23 ` [PATCH 1/4] compat/win32/syslog: fix use-after-realloc Johannes Schindelin via GitGitGadget
2022-05-24 12:39 ` Johannes Schindelin
2022-05-24 20:58 ` Junio C Hamano
2022-05-24 0:23 ` [PATCH 2/4] nedmalloc: avoid new compile error Johannes Schindelin via GitGitGadget
2022-05-24 8:00 ` Ævar Arnfjörð Bjarmason
2022-05-24 15:59 ` René Scharfe
2022-05-24 20:46 ` Johannes Schindelin
2022-05-24 21:33 ` Ævar Arnfjörð Bjarmason
2022-05-24 0:23 ` [PATCH 3/4] http.c: avoid danging pointer to local variable `finished` Johannes Schindelin via GitGitGadget
2022-05-24 7:58 ` Ævar Arnfjörð Bjarmason
2022-05-24 20:06 ` Junio C Hamano
2022-05-24 21:15 ` Johannes Schindelin
2022-05-24 21:45 ` Ævar Arnfjörð Bjarmason
2022-05-24 22:38 ` Junio C Hamano
2022-05-25 10:16 ` Johannes Schindelin
2022-05-25 12:48 ` Ævar Arnfjörð Bjarmason
2022-05-24 0:23 ` [PATCH 4/4] dir.c: avoid "exceeds maximum object size" error with GCC v12.x Johannes Schindelin via GitGitGadget
2022-05-24 5:53 ` Ævar Arnfjörð Bjarmason
2022-05-24 21:05 ` Johannes Schindelin
2022-05-25 13:39 ` Derrick Stolee [this message]
2022-05-25 18:27 ` Junio C Hamano
2022-05-24 15:54 ` [PATCH 0/4] ci: fix windows-build " Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7ee0bf0-22bc-d494-2699-7075fc92f28a@github.com \
--to=derrickstolee@github.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.