From: Dan Carpenter <dan.carpenter@linaro.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>,
kernel test robot <lkp@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-hwmon@vger.kernel.org
Subject: Re: [groeck-staging:hwmon-next 13/13] drivers/hwmon/gpio-fan.c:250:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false
Date: Thu, 10 Apr 2025 11:35:28 +0300 [thread overview]
Message-ID: <d80689a3-6055-449d-9475-5e8e4f1ddabf@stanley.mountain> (raw)
In-Reply-To: <20250409160250.GB1506425@ax162>
Another option is Smatch.
https://github.com/error27/smatch
:! ~/progs/smatch/release/smatch_scripts/kchecker drivers/hwmon/gpio-fan.c
CHECK scripts/mod/empty.c
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC drivers/hwmon/gpio-fan.o
CHECK drivers/hwmon/gpio-fan.c
drivers/hwmon/gpio-fan.c:145 set_fan_speed() warn: potential spectre issue 'fan_data->speed' [w] (local cap)
drivers/hwmon/gpio-fan.c:255 pwm1_enable_store() error: uninitialized symbol 'ret'.
I don't think the spectre v1 issue is real but I don't know very much
about spectre.
regards,
dan carpenter
prev parent reply other threads:[~2025-04-10 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 2:11 [groeck-staging:hwmon-next 13/13] drivers/hwmon/gpio-fan.c:250:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false kernel test robot
2025-04-09 2:51 ` Guenter Roeck
2025-04-09 6:50 ` Alexander Stein
2025-04-09 16:02 ` Nathan Chancellor
2025-04-10 8:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d80689a3-6055-449d-9475-5e8e4f1ddabf@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.