From: Eric Blake <eblake@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message
Date: Tue, 9 Jan 2018 13:41:41 -0600 [thread overview]
Message-ID: <d823570c-b4fe-2374-e5b7-7b1be7deb496@redhat.com> (raw)
In-Reply-To: <20180109193745.GA18506@amt.cnet>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On 01/09/2018 01:37 PM, Marcelo Tosatti wrote:
>
> Improve hugepage allocation failure message, indicating
> whats happening to the user.
s/whats/what's/
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/exec.c b/exec.c
> index 4722e521d4..439abedb98 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1643,7 +1643,8 @@ static void *file_ram_alloc(RAMBlock *block,
> block->flags & RAM_SHARED);
> if (area == MAP_FAILED) {
> error_setg_errno(errp, errno,
> - "unable to map backing store for guest RAM");
> + "unable to map backing store for guest RAM, "
> + "falling back to malloc based RAM allocation");
> return NULL;
> }
>
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-01-09 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 19:37 [Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message Marcelo Tosatti
2018-01-09 19:41 ` Eric Blake [this message]
2018-01-09 20:16 ` Haozhong Zhang
2018-01-10 14:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d823570c-b4fe-2374-e5b7-7b1be7deb496@redhat.com \
--to=eblake@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.