From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E5B4C433E2 for ; Thu, 17 Sep 2020 12:24:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1EE1208DB for ; Thu, 17 Sep 2020 12:24:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YSwvclpg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1EE1208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 425B36E22D; Thu, 17 Sep 2020 12:24:34 +0000 (UTC) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by gabe.freedesktop.org (Postfix) with ESMTPS id 573AF6E22D for ; Thu, 17 Sep 2020 12:24:33 +0000 (UTC) Received: by mail-ed1-x534.google.com with SMTP id i1so2344568edv.2 for ; Thu, 17 Sep 2020 05:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=GBPWnK+O45hDPiwD6Yl2FVueQas8+06W2RHndFOU4x0=; b=YSwvclpgwQrjaZJLio4+fZCnlFslcy8Smk4D3Nl1taPur3YUbCtbgZhfm/6+rxDLDb wnpQZk8wKk/ZMKnF8vQJK7jlxVoRuJE6PwMpAZIlrRUdYNDuAbOMf896/BwdweSdvEDR egGfWHIWpyYNDLR+YDZFocW3Spw/+1H3TuHMdAE5hQV4Sa7vq171+oowCUwvVE1XPned BNGCHnafxMkf0uGcmrVb/SW+uYrSjukjUsITqm1O0eLlKXIQ//sx5vYoWXnSP9AjX43r JzICsn9YQNoT2j5O7gynMB4YyLqxhQ4BfDYgM40y/TSWY5dKWblFY0toaz+U49m5h2eD SrPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=GBPWnK+O45hDPiwD6Yl2FVueQas8+06W2RHndFOU4x0=; b=cTD6a5XqIeWvmEyboDvLggkmd//CwFj5alk6KKC/AdinKGtiTYzR5Jis2MKB24sBZK YBUekuGoYIJfn6NLosqE/3Tx0PqbOoby2ktG1MbzVqYtZalgXkcAnVD6alTdr2n5y6HD 28WG5Rb8ENStMJu956kz+q7DvOrfQanif4USPRMKLKjJqfvlnE+xxjYCLqm1oVFstidn TPEFYQgeumxjh3Sg2yNqH8BJeENFX3jhwoau3wPTzat330SVbm7tUysRnDbNUzW44uDL sjuGQ7SpyF5sLshcJRx6vt/7dvJOnzI/Wu7kxY1hqWZDL/SDwq7Mv6TUWbV7KpmUED4s ZyIA== X-Gm-Message-State: AOAM5336cynKoqETsGr09qWV3E+T7QF3uFzU5CoZzljI/AekYKqn+rkG lgSk6AKe6zXToKoGVJLtv7c= X-Google-Smtp-Source: ABdhPJxjg1yiXefIk0NeL3VjLQ2zbCP7yoFRn/H/W2k2rNszWXwepBIqx8bZOzhUQkVeMcmckHNfJw== X-Received: by 2002:a05:6402:1110:: with SMTP id u16mr32547477edv.253.1600345471990; Thu, 17 Sep 2020 05:24:31 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id b5sm16198291edq.69.2020.09.17.05.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2020 05:24:31 -0700 (PDT) Subject: Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap() To: Jason Gunthorpe , christian.koenig@amd.com References: <20200916095359.GD438822@phenom.ffwll.local> <20200916140710.GA8409@ziepe.ca> <8db2474f-ecb7-0e17-5f5b-145708fe44d5@amd.com> <8d8693db-a3f0-4f5f-3e32-57d23ca620f8@amd.com> <20200917113110.GE8409@ziepe.ca> <6fd74b84-959c-8b3b-c27b-e9fbf66396c7@gmail.com> <20200917121858.GF8409@ziepe.ca> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 17 Sep 2020 14:24:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200917121858.GF8409@ziepe.ca> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , Andrew Morton , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" QW0gMTcuMDkuMjAgdW0gMTQ6MTggc2NocmllYiBKYXNvbiBHdW50aG9ycGU6Cj4gT24gVGh1LCBT ZXAgMTcsIDIwMjAgYXQgMDI6MDM6NDhQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToK Pj4gQW0gMTcuMDkuMjAgdW0gMTM6MzEgc2NocmllYiBKYXNvbiBHdW50aG9ycGU6Cj4+PiBPbiBU aHUsIFNlcCAxNywgMjAyMCBhdCAxMDowOToxMkFNICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3Rl Ogo+Pj4KPj4+PiBZZWFoLCBidXQgaXQgZG9lc24ndCB3b3JrIHdoZW4gZm9yd2FyZGluZyBmcm9t IHRoZSBkcm0gY2hhcmRldiB0byB0aGUKPj4+PiBkbWEtYnVmIG9uIHRoZSBpbXBvcnRlciBzaWRl LCBzaW5jZSB5b3UnZCBuZWVkIGEgdG9uIG9mIGRpZmZlcmVudAo+Pj4+IGFkZHJlc3Mgc3BhY2Vz LiBBbmQgeW91IHN0aWxsIHJlbHkgb24gdGhlIGNvcmUgY29kZSBwaWNraW5nIHVwIHlvdXIKPj4+ PiBwZ29mZiBtYW5nbGluZywgd2hpY2ggZmVlbHMgYWJvdXQgYXMgcmlza3kgdG8gbWUgYXMgdGhl IHZtYSBmaWxlCj4+Pj4gcG9pbnRlciB3cmFuZ2xpbmcgLSBpZiBpdCdzIG5vdCBjb25zaXN0ZW50 bHkgYXBwbGllZCB0aGUgcmV2ZXJzZSBtYXAKPj4+PiBpcyB0b2FzdCBhbmQgdW5tYXBfbWFwcGlu Z19yYW5nZSBkb2Vzbid0IHdvcmsgY29ycmVjdGx5IGZvciBvdXIgbmVlZHMuCj4+PiBJIHdvdWxk IHRoaW5rIHRoZSBwZ29mZiBoYXMgdG8gYmUgdHJhbnNsYXRlZCBhdCB0aGUgc2FtZSB0aW1lIHRo ZQo+Pj4gdm0tPnZtX2ZpbGUgaXMgY2hhbmdlZD8KPj4+Cj4+PiBUaGUgb3duZXIgb2YgdGhlIGRt YV9idWYgc2hvdWxkIGhhdmUgb25lIHZpcnR1YWwgYWRkcmVzcyBzcGFjZSBhbmQgRkQsCj4+PiBh bGwgaXRzIGRtYSBidWZzIHNob3VsZCBiZSBsaW5rZWQgdG8gaXQsIGFuZCBhbGwgcGdvZmZzIHRy YW5zbGF0ZWQgdG8KPj4+IHRoYXQgc3BhY2UuCj4+IFllYWgsIHRoYXQgaXMgZXhhY3RseSBsaWtl IGFtZGdwdSBpcyBkb2luZyBpdC4KPj4KPj4gR29pbmcgdG8gZG9jdW1lbnQgdGhhdCBzb21laG93 IHdoZW4gSSdtIGRvbmUgd2l0aCBUVE0gY2xlYW51cHMuCj4gQlRXLCB3aGlsZSBwZW9wbGUgYXJl IGxvb2tpbmcgYXQgdGhpcywgaXMgdGhlcmUgYSB3YXkgdG8gZ28gZnJvbSBhIFZNQQo+IHRvIGEg ZG1hX2J1ZiB0aGF0IG93bnMgaXQ/CgpPbmx5IGEgZHJpdmVyIHNwZWNpZmljIG9uZS4KCkZvciBU VE0gZHJpdmVycyB2bWEtPnZtX3ByaXZhdGVfZGF0YSBwb2ludHMgdG8gdGhlIGJ1ZmZlciBvYmpl Y3QuIE5vdCAKc3VyZSBhYm91dCB0aGUgZHJpdmVycyB1c2luZyBHRU0gb25seS4KCldoeSBhcmUg eW91IGFza2luZz8KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiBKYXNvbgo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gTGluYXJvLW1tLXNpZyBtYWls aW5nIGxpc3QKPiBMaW5hcm8tbW0tc2lnQGxpc3RzLmxpbmFyby5vcmcKPiBodHRwczovL2xpc3Rz LmxpbmFyby5vcmcvbWFpbG1hbi9saXN0aW5mby9saW5hcm8tbW0tc2lnCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D754EC2BBD1 for ; Thu, 17 Sep 2020 12:26:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A278221974 for ; Thu, 17 Sep 2020 12:26:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YSwvclpg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbgIQMY5 (ORCPT ); Thu, 17 Sep 2020 08:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbgIQMYx (ORCPT ); Thu, 17 Sep 2020 08:24:53 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1EDFC061788; Thu, 17 Sep 2020 05:24:34 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id j2so2264531eds.9; Thu, 17 Sep 2020 05:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=GBPWnK+O45hDPiwD6Yl2FVueQas8+06W2RHndFOU4x0=; b=YSwvclpgwQrjaZJLio4+fZCnlFslcy8Smk4D3Nl1taPur3YUbCtbgZhfm/6+rxDLDb wnpQZk8wKk/ZMKnF8vQJK7jlxVoRuJE6PwMpAZIlrRUdYNDuAbOMf896/BwdweSdvEDR egGfWHIWpyYNDLR+YDZFocW3Spw/+1H3TuHMdAE5hQV4Sa7vq171+oowCUwvVE1XPned BNGCHnafxMkf0uGcmrVb/SW+uYrSjukjUsITqm1O0eLlKXIQ//sx5vYoWXnSP9AjX43r JzICsn9YQNoT2j5O7gynMB4YyLqxhQ4BfDYgM40y/TSWY5dKWblFY0toaz+U49m5h2eD SrPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=GBPWnK+O45hDPiwD6Yl2FVueQas8+06W2RHndFOU4x0=; b=NlN69kOP9FDRpkuv6GNSuvUE6DRgjq01q50HJGYBRlV7pWR3hoeypwQelEAo4y+c2d VPSxGvJnZIExFtavV88KyWUL6nkwYT//3lhBkGZaeiEVmzN+wHrRrna2DrC/+HmhvCTv BD6gLeCQdQgV0m1DLeVY4QBm2VPVqawVZilLdsO5F8Ph3iPmwTvXbNijlODZSJf87EoY qcA9m10qEXxLp2YD4ge0oBlYxF6bvbtzoNSa2sF1iEGnQ6y/7V8VFTTDEq6w0zimRxU1 UqURXC10lrqwErD5xUGn3xBEgPrOCJH6dsGKWrTbvAWgIiIQfMiSLLeroLc5tItQQn4I K5BA== X-Gm-Message-State: AOAM5334VeEOwXUhP1mj3IG1clhp9PsF8ld4WXLUSBXWTBoGkByx2Bok eQu4wq9hbQcWjfkAexWLbzgzQAczzdg= X-Google-Smtp-Source: ABdhPJxjg1yiXefIk0NeL3VjLQ2zbCP7yoFRn/H/W2k2rNszWXwepBIqx8bZOzhUQkVeMcmckHNfJw== X-Received: by 2002:a05:6402:1110:: with SMTP id u16mr32547477edv.253.1600345471990; Thu, 17 Sep 2020 05:24:31 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id b5sm16198291edq.69.2020.09.17.05.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Sep 2020 05:24:31 -0700 (PDT) Reply-To: christian.koenig@amd.com Subject: Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap() To: Jason Gunthorpe , christian.koenig@amd.com Cc: Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , Daniel Vetter , Andrew Morton , "open list:DMA BUFFER SHARING FRAMEWORK" References: <20200916095359.GD438822@phenom.ffwll.local> <20200916140710.GA8409@ziepe.ca> <8db2474f-ecb7-0e17-5f5b-145708fe44d5@amd.com> <8d8693db-a3f0-4f5f-3e32-57d23ca620f8@amd.com> <20200917113110.GE8409@ziepe.ca> <6fd74b84-959c-8b3b-c27b-e9fbf66396c7@gmail.com> <20200917121858.GF8409@ziepe.ca> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 17 Sep 2020 14:24:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200917121858.GF8409@ziepe.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Am 17.09.20 um 14:18 schrieb Jason Gunthorpe: > On Thu, Sep 17, 2020 at 02:03:48PM +0200, Christian König wrote: >> Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: >>> On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter wrote: >>> >>>> Yeah, but it doesn't work when forwarding from the drm chardev to the >>>> dma-buf on the importer side, since you'd need a ton of different >>>> address spaces. And you still rely on the core code picking up your >>>> pgoff mangling, which feels about as risky to me as the vma file >>>> pointer wrangling - if it's not consistently applied the reverse map >>>> is toast and unmap_mapping_range doesn't work correctly for our needs. >>> I would think the pgoff has to be translated at the same time the >>> vm->vm_file is changed? >>> >>> The owner of the dma_buf should have one virtual address space and FD, >>> all its dma bufs should be linked to it, and all pgoffs translated to >>> that space. >> Yeah, that is exactly like amdgpu is doing it. >> >> Going to document that somehow when I'm done with TTM cleanups. > BTW, while people are looking at this, is there a way to go from a VMA > to a dma_buf that owns it? Only a driver specific one. For TTM drivers vma->vm_private_data points to the buffer object. Not sure about the drivers using GEM only. Why are you asking? Regards, Christian. > > Jason > _______________________________________________ > Linaro-mm-sig mailing list > Linaro-mm-sig@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-mm-sig