From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DACEC021B3 for ; Fri, 21 Feb 2025 09:39:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 31B458113B; Fri, 21 Feb 2025 09:39:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id iq5oFLg03gIG; Fri, 21 Feb 2025 09:39:15 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 70E2D8113C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1740130755; bh=Y3XbXtPDOSQc3Ud9gYAOTQNFm76FYGOTsYqGLsAJFmI=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=92XaixnY3Oao5xyRP6IQMZNpK8axcjjGx6/yNKVmRjOm9JKy9IxgCmq2GrgGJBzk3 KPV4aei6yXaMNTdFdw+lDyQ+hSHb3GtNPE0REEJubAxUC8GcJlwJiGWHqIXB4irWqZ W1z8EHDOIk3QsGmtAuSRqvLxyxOQ//Payfi9sjZpXLczhhw2ZsezR523492BBZaQMW 6KEG9S0q/oymlNVPvK2lnwnO32iFLvjdK50OWVzhBMorSU+GwX9/3ErPRogrcnNYyd BADx06zo9tRVRPymJIEIjk9iEKmmqDB3BHtw1dp6E+iUJWGPAkYsPfLY2cXTZvoVk3 hCg4oYBBXLQHQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 70E2D8113C; Fri, 21 Feb 2025 09:39:15 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 12EE3194 for ; Fri, 21 Feb 2025 09:39:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0200260703 for ; Fri, 21 Feb 2025 09:39:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id u8jq0KTTs-UR for ; Fri, 21 Feb 2025 09:39:13 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=192.198.163.10; helo=mgamail.intel.com; envelope-from=faizal.abdul.rahim@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1430560619 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1430560619 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1430560619 for ; Fri, 21 Feb 2025 09:39:12 +0000 (UTC) X-CSE-ConnectionGUID: nkg36b2LTeS0hseXIOIJKw== X-CSE-MsgGUID: tX2k6r3rT5a9Wp9egs9Qgg== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="52374636" X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="52374636" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 01:39:12 -0800 X-CSE-ConnectionGUID: sCJgPV6FSh+R2T0LS+EcWA== X-CSE-MsgGUID: BNtqYb15R5CPtswph0+OVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,304,1732608000"; d="scan'208";a="115276416" Received: from mohdfai2-mobl.gar.corp.intel.com (HELO [10.247.60.175]) ([10.247.60.175]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 01:39:09 -0800 Message-ID: Date: Fri, 21 Feb 2025 17:39:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org References: <20250217-igc_mqprio_tx_mode-v1-1-3a402fe1f326@linutronix.de> <6ff37238-ff0e-43c9-a88d-1258fd4ce7ef@linux.intel.com> <87wmdj8ydu.fsf@kurt.kurt.home> Content-Language: en-US From: "Abdul Rahim, Faizal" In-Reply-To: <87wmdj8ydu.fsf@kurt.kurt.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740130753; x=1771666753; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ypHSjeMhvEL6lzT/9gZtGZLdCaUojf6hRPWXsKHq6cA=; b=MtaTkVs2XTGkFiJQ2GLjGnchnSppr0b1CGZ+gDzEmQ4twh/7UFVcz2GM TWsh8P70ad0KjwdM7bN+L9zPjxsBOjHZFBaBJGJEg4/O0my1VchvEOukp Mc9Fql3YND2rA4Xp7N8ywQJtNvjQZQqNARVh4HcPP/YPsqnwj/w0rGwD7 knDX7MDlJ1HYxJWdpgiu7zyM9zJLSL6RmqD9vRL9KrTnhZbGPEgDzp3Ri mFU11BgkUX60kj/imrHm450yDWaOZVYcm5v5ZSmfzPGgsiW5Go2sj3yPH 5S929ppexpIZemUWe6d9EQtnzIrarAbdqsDoLPgH64gzG83sCWACufe8V A==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=MtaTkVs2 Subject: Re: [Intel-wired-lan] [PATCH iwl-next] igc: Change Tx mode for MQPRIO offloading X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" >>> diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c >>> index 1e44374ca1ffbb86e9893266c590f318984ef574..6e4582de9602db2c6667f1736cc2acaa4d4b5201 100644 >>> --- a/drivers/net/ethernet/intel/igc/igc_tsn.c >>> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c >>> @@ -47,7 +47,7 @@ static unsigned int igc_tsn_new_flags(struct igc_adapter *adapter) >>> new_flags |= IGC_FLAG_TSN_QAV_ENABLED; >>> >>> if (adapter->strict_priority_enable) >>> - new_flags |= IGC_FLAG_TSN_LEGACY_ENABLED; >>> + new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >>> >>> return new_flags; >>> } >> >> IGC_FLAG_TSN_QBV_ENABLED is set multiple times in different lines: >> >> if (adapter->taprio_offload_enable) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >> >> if (is_any_launchtime(adapter)) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >> >> if (is_cbs_enabled(adapter)) >> new_flags |= IGC_FLAG_TSN_QAV_ENABLED; >> >> if (adapter->strict_priority_enable) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >> >> return new_flags; >> } >> >> We can combine the conditions to simplify: >> if (adapter->taprio_offload_enable || >> is_any_launchtime(adapter) || >> adapter->strict_priority_enable) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; > > Sure. > > Should I send a v2 or do you want to carry this patch in your next fpe > series? I think you can go ahead with v2. It shouldn’t conflict much with the next fpe series, and if my future series gets stalled, at least yours won’t be affected. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AA33205511 for ; Fri, 21 Feb 2025 09:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740130755; cv=none; b=CuXg0DjgJcRC/zZ2AihUq89RHe8JuPgRt8PNvCFV27xU3ndJtOpqb6D0yiqSk7s+sfJ6+RDeSldolT6w0YTRGomihlQAAs8kfZll2qfh0FPwMEK78C3nOfbBf820BpSmPDJF+LUyx/f2r+6dBrxED8ZXUVIXRJJRCDKWoEiWEe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740130755; c=relaxed/simple; bh=ypHSjeMhvEL6lzT/9gZtGZLdCaUojf6hRPWXsKHq6cA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WNSXqm+JaGXvMN+DPDThSBMjTo0lGz/c2SukgBLwhxTtijCkNPSNPuJ2rikhUJwXe+0O/ctCXf6r0vcwo7VoxmUedO69XRYQk+9JzIevqLSuWbkUItIna1/t4gs7NNmfBUFAGhjMfnYY11s5PZEpLBeDitIG032J8g+wuUaGMuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MtaTkVs2; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MtaTkVs2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740130753; x=1771666753; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ypHSjeMhvEL6lzT/9gZtGZLdCaUojf6hRPWXsKHq6cA=; b=MtaTkVs2XTGkFiJQ2GLjGnchnSppr0b1CGZ+gDzEmQ4twh/7UFVcz2GM TWsh8P70ad0KjwdM7bN+L9zPjxsBOjHZFBaBJGJEg4/O0my1VchvEOukp Mc9Fql3YND2rA4Xp7N8ywQJtNvjQZQqNARVh4HcPP/YPsqnwj/w0rGwD7 knDX7MDlJ1HYxJWdpgiu7zyM9zJLSL6RmqD9vRL9KrTnhZbGPEgDzp3Ri mFU11BgkUX60kj/imrHm450yDWaOZVYcm5v5ZSmfzPGgsiW5Go2sj3yPH 5S929ppexpIZemUWe6d9EQtnzIrarAbdqsDoLPgH64gzG83sCWACufe8V A==; X-CSE-ConnectionGUID: Bo7G0kxmTe6iDX/yVaOxEA== X-CSE-MsgGUID: /dN/9ZMnTcm/WA3YnF8qcw== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="52374633" X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="52374633" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 01:39:12 -0800 X-CSE-ConnectionGUID: sCJgPV6FSh+R2T0LS+EcWA== X-CSE-MsgGUID: BNtqYb15R5CPtswph0+OVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,304,1732608000"; d="scan'208";a="115276416" Received: from mohdfai2-mobl.gar.corp.intel.com (HELO [10.247.60.175]) ([10.247.60.175]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 01:39:09 -0800 Message-ID: Date: Fri, 21 Feb 2025 17:39:06 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-next] igc: Change Tx mode for MQPRIO offloading To: Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org References: <20250217-igc_mqprio_tx_mode-v1-1-3a402fe1f326@linutronix.de> <6ff37238-ff0e-43c9-a88d-1258fd4ce7ef@linux.intel.com> <87wmdj8ydu.fsf@kurt.kurt.home> Content-Language: en-US From: "Abdul Rahim, Faizal" In-Reply-To: <87wmdj8ydu.fsf@kurt.kurt.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >>> diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c >>> index 1e44374ca1ffbb86e9893266c590f318984ef574..6e4582de9602db2c6667f1736cc2acaa4d4b5201 100644 >>> --- a/drivers/net/ethernet/intel/igc/igc_tsn.c >>> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c >>> @@ -47,7 +47,7 @@ static unsigned int igc_tsn_new_flags(struct igc_adapter *adapter) >>> new_flags |= IGC_FLAG_TSN_QAV_ENABLED; >>> >>> if (adapter->strict_priority_enable) >>> - new_flags |= IGC_FLAG_TSN_LEGACY_ENABLED; >>> + new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >>> >>> return new_flags; >>> } >> >> IGC_FLAG_TSN_QBV_ENABLED is set multiple times in different lines: >> >> if (adapter->taprio_offload_enable) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >> >> if (is_any_launchtime(adapter)) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >> >> if (is_cbs_enabled(adapter)) >> new_flags |= IGC_FLAG_TSN_QAV_ENABLED; >> >> if (adapter->strict_priority_enable) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; >> >> return new_flags; >> } >> >> We can combine the conditions to simplify: >> if (adapter->taprio_offload_enable || >> is_any_launchtime(adapter) || >> adapter->strict_priority_enable) >> new_flags |= IGC_FLAG_TSN_QBV_ENABLED; > > Sure. > > Should I send a v2 or do you want to carry this patch in your next fpe > series? I think you can go ahead with v2. It shouldn’t conflict much with the next fpe series, and if my future series gets stalled, at least yours won’t be affected.