From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables
Date: Mon, 27 Feb 2023 16:17:54 +0100 [thread overview]
Message-ID: <d86507fb-f1b1-3d91-e1af-967e6b40d514@suse.com> (raw)
In-Reply-To: <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org>
On 25.02.2023 19:05, Julien Grall wrote:
> On 24/02/2023 15:06, Oleksii Kurochko wrote:
>> @@ -43,6 +45,11 @@ static void __init disable_fpu(void)
>>
>> void __init noreturn start_xen(void)
>> {
>> + unsigned long load_start = (unsigned long)start;
>> + unsigned long load_end = load_start + (unsigned long)(_end - _start);
>
> I am a bit puzzled, on top of load_addr() and linker_addr(), you wrote
> it can't use global variable/function. But here... you are using them.
> So how is this different?
I guess "use" means "access" (i.e. call a function or read/write a
variable). I suppose it does not mean "take the address of".
Jan
next prev parent reply other threads:[~2023-02-27 15:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 15:06 [PATCH v1 0/3] enable MMU for RISC-V Oleksii Kurochko
2023-02-24 15:06 ` [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages Oleksii Kurochko
2023-02-24 15:23 ` Andrew Cooper
2023-02-25 17:53 ` Julien Grall
2023-02-27 16:52 ` Oleksii
2023-02-27 17:36 ` Julien Grall
2023-03-05 16:25 ` Oleksii
2023-03-05 21:28 ` Oleksii
2023-03-21 16:25 ` Julien Grall
2023-03-22 9:14 ` Oleksii
2023-02-27 15:12 ` Jan Beulich
2023-02-27 15:19 ` Jan Beulich
2023-03-06 6:39 ` Oleksii
2023-03-06 6:38 ` Oleksii
2023-02-24 15:06 ` [PATCH v1 2/3] xen/riscv: setup initial pagetables Oleksii Kurochko
2023-02-25 18:05 ` Julien Grall
2023-02-27 15:17 ` Jan Beulich [this message]
2023-02-27 15:36 ` Julien Grall
2023-02-27 17:17 ` Oleksii
2023-02-27 17:45 ` Julien Grall
2023-03-08 14:54 ` Oleksii
2023-03-08 15:17 ` Jan Beulich
2023-03-08 16:16 ` Oleksii
2023-03-09 9:46 ` Jan Beulich
2023-03-09 14:39 ` Oleksii
2023-02-24 15:06 ` [PATCH v1 3/3] automation: update RISC-V smoke test Oleksii Kurochko
2023-02-24 15:27 ` Andrew Cooper
2023-02-24 16:45 ` Oleksii
2023-02-24 15:19 ` [PATCH v1 0/3] enable MMU for RISC-V Oleksii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d86507fb-f1b1-3d91-e1af-967e6b40d514@suse.com \
--to=jbeulich@suse.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=julien@xen.org \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.