Re: [PATCH 2/3] dt-bindings: arm: sunxi: Add Banana Pi P2 Zero v1.1

[Krzysztof Kozlowski <krzk@kernel.org>]

On 18/11/2023 12:14, Pavel Löbl wrote:
> Document binding for Banana Pi P2 Zero v1.1.
> 
> Signed-off-by: Pavel Löbl <pavel@loebl.cz>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 11c5ce941dd7..f3c0511cc133 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -141,6 +141,12 @@ properties:
>            - const: sinovoip,bananapi-m64
>            - const: allwinner,sun50i-a64
>  
> +      - description: BananaPi P2 Zero v1.1
> +        items:
> +          - const: sinovoip,bananapi-p2-zero-v1.1
> +          - const: sinovoip,bananapi-p2-zero

That's not what your DTS is saying.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).



Best regards,
Krzysztof