From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: usb: microchip, usb2514: Add USB2517 compatible
Date: Wed, 31 Jul 2024 10:05:57 +0200 [thread overview]
Message-ID: <d88b8d9e-e005-442a-bbf0-2949dd5dc873@kernel.org> (raw)
In-Reply-To: <6694660.DvuYhMxLoT@steina-w>
On 31/07/2024 09:34, Alexander Stein wrote:
> Am Mittwoch, 31. Juli 2024, 09:32:43 CEST schrieb Krzysztof Kozlowski:
>> On 31/07/2024 09:27, Krzysztof Kozlowski wrote:
>>> On 31/07/2024 09:19, Alexander Stein wrote:
>>>> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
>>>> based on USB vendor & product ID.
>>>>
>>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Of course assuming there is some user? If so, where?
>
> There is: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> introduced by commit ba9943f47dca1 ("arm64: dts: mba93xxla: Add USB support")
Bindings 1.5 years after you added compatible... checkpatch told you
that you miss bindings that time.
This should be explained in commit msg - you add compatible for a
compatible already present in the kernel.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-07-31 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 7:19 [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible Alexander Stein
2024-07-31 7:25 ` Alexander Stein
2024-07-31 7:27 ` Krzysztof Kozlowski
2024-07-31 7:32 ` Krzysztof Kozlowski
2024-07-31 7:34 ` [PATCH 1/1] dt-bindings: usb: microchip, usb2514: " Alexander Stein
2024-07-31 8:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d88b8d9e-e005-442a-bbf0-2949dd5dc873@kernel.org \
--to=krzk@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.