From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E655AC04A6A for ; Thu, 10 Aug 2023 15:27:18 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.582121.911714 (Exim 4.92) (envelope-from ) id 1qU7Z6-0001jF-HA; Thu, 10 Aug 2023 15:27:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582121.911714; Thu, 10 Aug 2023 15:27:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7Z6-0001j8-CU; Thu, 10 Aug 2023 15:27:08 +0000 Received: by outflank-mailman (input) for mailman id 582121; Thu, 10 Aug 2023 15:27:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7Z5-0001j0-6j for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 15:27:07 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c1f2147-3792-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 17:27:04 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 651614EE073F; Thu, 10 Aug 2023 17:27:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c1f2147-3792-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Thu, 10 Aug 2023 17:27:04 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 In-Reply-To: <35c1a691-92a3-0fb1-04f2-f75755a3b5e9@suse.com> References: <37bb5dc6f323bd2dc250c519523d05b66d17fdee.1691567429.git.nicola.vetrini@bugseng.com> <35c1a691-92a3-0fb1-04f2-f75755a3b5e9@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 14:45, Jan Beulich wrote: > On 09.08.2023 09:55, Nicola Vetrini wrote: >> The local variables 'irq_desc' shadow the homonymous global variable, >> declared in 'xen/arch/x86/include/asm/irq.h', therefore they are >> renamed >> 'irqd' for consistency. > > Perhaps with "for consistency" dropped (or else clarified what this > is to be consistent with) ... > >> Signed-off-by: Nicola Vetrini > > Reviewed-by: Jan Beulich > > Jan Good point. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)