From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12D15C4332F for ; Fri, 11 Feb 2022 09:11:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 231A510EA36; Fri, 11 Feb 2022 09:11:39 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F28B10EA1F for ; Fri, 11 Feb 2022 08:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644569161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=JWBBVROHNDyDfUEi5eAEEopZINg2s1HncjBe0675uzx9nZdArY2kqmyW+TUBaiSSRo+lLU FE0P/ZBJ32V9N7pjdgeOhXhGED0I/Du1iLPKMyxGebFqbNY6kWxqOBMJgweOdGfI10InBj JPFP51oRizc8wLb7tvSxBU4beQ+ebVY= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-672-NPrl7Li9OIC4n74ndC1Zrw-1; Fri, 11 Feb 2022 03:46:00 -0500 X-MC-Unique: NPrl7Li9OIC4n74ndC1Zrw-1 Received: by mail-ej1-f70.google.com with SMTP id hp37-20020a1709073e2500b006cd86fa20ffso2838762ejc.5 for ; Fri, 11 Feb 2022 00:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=KLpECcyVZZFso+nWHjm6YCtDQEYOU1gGvhTTWSvqhIN3XS5u8CBgq1h6mgGszqrK+A TfFROE5KbxlkPxpIltFTmpkU0d9D+25peV5bMWNKIo+e77EikxRpuTf9XwDyqDu4fUWc 7ZxGXJLZcuEBo8g1cjmh7dQH5vMzyrcBROQZv1LbXzrRjdhWBXTa9u58Sln6jIU30nXn dH5qbX4i2yhi70kYT3nH9s51Dnl7C/xw32lj40h/utLMzt51eZpo9UIrM5lo77mwTFlP U5CFW8tDKvtXnW76mDPzcfBI2itfoeal8ItxqS4wMX6joziRGDTmWnn5lPBD/DZ+UK0v +9pA== X-Gm-Message-State: AOAM533vwofaLTFftBNpQB0GPSHiLYTejtSSU4xF7lkTAd9eqcovSGVm o8RZUlfZ0IjPbeh1J60AEiRD/LQ1HAcL1AI3t1aUCXOnlEnbfaBmhwLLQ+rZVd53PCTgQLpGn9j 7DI2GDZOMcw0mLBV1sC54p+m8MQ== X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466710ejc.283.1644569159070; Fri, 11 Feb 2022 00:45:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQtGaHy5U9JGMvxdUhyHS51vk9smJiabHDR4QMkXJw//KX0Gh6ttUq7C+QmDdzvWmB7pzNDQ== X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466695ejc.283.1644569158862; Fri, 11 Feb 2022 00:45:58 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id v5sm10859303edb.15.2022.02.11.00.45.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 00:45:58 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 09:45:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached` To: Mario Limonciello , Bjorn Helgaas , Andreas Noever , Mika Westerberg , "open list:PCI SUBSYSTEM" , "open list:THUNDERBOLT DRIVER" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:X86 PLATFORM DRIVERS" References: <20220210224329.2793-1-mario.limonciello@amd.com> <20220210224329.2793-9-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20220210224329.2793-9-mario.limonciello@amd.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 11 Feb 2022 09:11:37 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Jamet , Yehezkel Bernat , Alexander.Deucher@amd.com, Lukas Wunner Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi, On 2/10/22 23:43, Mario Limonciello wrote: > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello Thanks, this looks good to me. I assume that this whole series will be merged in one go through another tree (e.g. the PCI tree), so here is my ack for merging this patch through another tree: Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > > static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9775C433F5 for ; Fri, 11 Feb 2022 08:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348132AbiBKIqG (ORCPT ); Fri, 11 Feb 2022 03:46:06 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348121AbiBKIqD (ORCPT ); Fri, 11 Feb 2022 03:46:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 75B1EE67 for ; Fri, 11 Feb 2022 00:46:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644569161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=JWBBVROHNDyDfUEi5eAEEopZINg2s1HncjBe0675uzx9nZdArY2kqmyW+TUBaiSSRo+lLU FE0P/ZBJ32V9N7pjdgeOhXhGED0I/Du1iLPKMyxGebFqbNY6kWxqOBMJgweOdGfI10InBj JPFP51oRizc8wLb7tvSxBU4beQ+ebVY= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-IsXI8w6UNXOXgKhO4wFLRQ-1; Fri, 11 Feb 2022 03:46:00 -0500 X-MC-Unique: IsXI8w6UNXOXgKhO4wFLRQ-1 Received: by mail-ej1-f69.google.com with SMTP id la22-20020a170907781600b006a7884de505so3799651ejc.7 for ; Fri, 11 Feb 2022 00:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=ihErpbW9PZJc90OvR+BlqZKKzfcflw9ZxHtsNCHqHiW/y1aanveQI8DUi0K2UMpCuC 1/SSmTrWdmLn3RktUpNoQ5T6W4PshCuo4BA/yB8DBU+PSQ8jt3rYKEA0Q/uU/KjHin95 pZscQxZtEgzMSRO73rC+V7ggRzkCzhxvlyJKs+PEzoMeH8G/Jb76TnUa6lF3X6Lu40Fr NyS++TC6byEjN3hi9a6JsImd65eJsJ2D1o6vebhgGcgvLjcYyEei7P/udqRelke4J489 6NtQoVwGepNIHgkMPRCwZDNfWpMH58wi2cUKWVU/oQ/P+SuIM3xX/LzwI/d/exctU1QP qUEA== X-Gm-Message-State: AOAM53335Zm9Q9UqB/zJX2o250aV44vcSCVATDnMfAcougvXBNEQ7FWj pkc3u1QY+AuqNQ66J01kM4cDr3t1UHQj8yo59eV4q2EXehR8OL4MtPKfe6j+zaW/6NFyWO0H0SO 2epjE/mVDpRorfb+EUK2L X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466714ejc.283.1644569159073; Fri, 11 Feb 2022 00:45:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQtGaHy5U9JGMvxdUhyHS51vk9smJiabHDR4QMkXJw//KX0Gh6ttUq7C+QmDdzvWmB7pzNDQ== X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466695ejc.283.1644569158862; Fri, 11 Feb 2022 00:45:58 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id v5sm10859303edb.15.2022.02.11.00.45.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 00:45:58 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 09:45:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached` Content-Language: en-US To: Mario Limonciello , Bjorn Helgaas , Andreas Noever , Mika Westerberg , "open list:PCI SUBSYSTEM" , "open list:THUNDERBOLT DRIVER" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:X86 PLATFORM DRIVERS" Cc: Michael Jamet , Yehezkel Bernat , Lukas Wunner , Alexander.Deucher@amd.com References: <20220210224329.2793-1-mario.limonciello@amd.com> <20220210224329.2793-9-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20220210224329.2793-9-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, On 2/10/22 23:43, Mario Limonciello wrote: > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello Thanks, this looks good to me. I assume that this whole series will be merged in one go through another tree (e.g. the PCI tree), so here is my ack for merging this patch through another tree: Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > > static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17FFFC433F5 for ; Fri, 11 Feb 2022 08:46:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FA3B10EA1F; Fri, 11 Feb 2022 08:46:03 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DDC610EA24 for ; Fri, 11 Feb 2022 08:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644569161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=JWBBVROHNDyDfUEi5eAEEopZINg2s1HncjBe0675uzx9nZdArY2kqmyW+TUBaiSSRo+lLU FE0P/ZBJ32V9N7pjdgeOhXhGED0I/Du1iLPKMyxGebFqbNY6kWxqOBMJgweOdGfI10InBj JPFP51oRizc8wLb7tvSxBU4beQ+ebVY= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-LfOlhUV-PXCPJVbRF_WGHg-1; Fri, 11 Feb 2022 03:46:00 -0500 X-MC-Unique: LfOlhUV-PXCPJVbRF_WGHg-1 Received: by mail-ed1-f70.google.com with SMTP id x6-20020a05640226c600b0040fe1993eebso4232973edd.6 for ; Fri, 11 Feb 2022 00:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=5YIVx8BLB5JuIwj4fae+7haGjSuhRNgmbYFaXk335IBBTTyIs1DxjzQctsL50t36Vl nird188dg67LPanhnrM07IvBy+da3BFN+4bxeBrSqtkP1PoWRybdk6Iv4r4e3irGBy3f jNJza+YAZBPoGibRYgKE8WZR6RH3zsYLafvO7NJhnQJKK19zyajI+EImJjVhWeUxEdTE 5XkLdxWkD4CeNkyQAJiVIqGfpN0WY5GD66oIti5Pp0zg0iBrzCvN52g+xIOtZXdiFBwu 2VRS0/K2uPYn0FySibKLuS3YmMnAomq7eAUICyve1bHtEB6xJ6iblTv3CtArb1clYvW8 1c1g== X-Gm-Message-State: AOAM532v1/8+1FuqLeO6eP1I6Agn94eT98ju37fqFSDiiidW/XuxogFV 2gCcupRgn3xmoZCpOzxWJ+9MbpPLUsHtul+8e/8Sgdj7PRH0zXXrm9JFbluGGwgKJBcHxGXqLQ7 7LstKDVO23BY7yNuTNTjyfhuNDA== X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466717ejc.283.1644569159100; Fri, 11 Feb 2022 00:45:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQtGaHy5U9JGMvxdUhyHS51vk9smJiabHDR4QMkXJw//KX0Gh6ttUq7C+QmDdzvWmB7pzNDQ== X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466695ejc.283.1644569158862; Fri, 11 Feb 2022 00:45:58 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id v5sm10859303edb.15.2022.02.11.00.45.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 00:45:58 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 09:45:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: Mario Limonciello , Bjorn Helgaas , Andreas Noever , Mika Westerberg , "open list:PCI SUBSYSTEM" , "open list:THUNDERBOLT DRIVER" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:X86 PLATFORM DRIVERS" References: <20220210224329.2793-1-mario.limonciello@amd.com> <20220210224329.2793-9-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20220210224329.2793-9-mario.limonciello@amd.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Nouveau] [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached` X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Jamet , Yehezkel Bernat , Alexander.Deucher@amd.com Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hi, On 2/10/22 23:43, Mario Limonciello wrote: > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello Thanks, this looks good to me. I assume that this whole series will be merged in one go through another tree (e.g. the PCI tree), so here is my ack for merging this patch through another tree: Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > > static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0233C433EF for ; Fri, 11 Feb 2022 08:46:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D1E010EA24; Fri, 11 Feb 2022 08:46:05 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id B84B710EA24 for ; Fri, 11 Feb 2022 08:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644569162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=iG/QeERaNs9Sr0kOvajlHT4Cdcd87A8jmtccJKoGpzlUC8YlJl1S6LZ65rtjXW6JmdFPwv V/mmnpQlokDkZyGws5CNluJthiekVZuFrzMDpCy13ySHDwMt3prKEav2J3dzvtNgxldHvu j2kZpMreGqFzfX5ErhqMoD/an4vY1Cw= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-sDg08VwzNBqNFEHm7lDo7Q-1; Fri, 11 Feb 2022 03:46:00 -0500 X-MC-Unique: sDg08VwzNBqNFEHm7lDo7Q-1 Received: by mail-ed1-f70.google.com with SMTP id w3-20020a50c443000000b0040696821132so4911842edf.22 for ; Fri, 11 Feb 2022 00:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NIGJSGdDR+e/0lqDusmjI7J0UIItqFB5EseqZJ+/itg=; b=6Q8mdJz7yXTjvGwMI3HlAxRsJtWIQodwDvIMRYta9sJqwH6K8SJ+2eksQS5Ij/JTtg YIDUxeTR7aC1h1ZvgDw4UD86PD2Ec1pkxQRifw5T9lMmVuAaQL/cBCyl06J6sXgBCGit aREORk1sLUrKxb4uiAGiW7p6Za+ChqnYK4qJLsR9QWFwokzMMbcQJmTJXkCJ4sw/5NrG wwpK+LvwLdYCmzVirC5gr66C3WsdcKSTa2tijtDAv9ru1Q63W4XI2jlGcWb5rDAiUd0g FvX3s+K4OJdaSkLSGZBxR3H6zcY3SgNBIhQWTmJ2QFz0U06rzsxdl367nCb60hnFm5/d EzMg== X-Gm-Message-State: AOAM530Vn72AF4wNNdKLMbjvCNbBRmmXwZBPaeU1f1eEYasozLrGy/8S Y1M1A/nyAi4hNIbCr1OVzfnk92K3QN2sf4RuXMS8X2odh2JU1Gzo30m7gL7f04+u684Npvppv8k oY0Bi/4jw56cZAm3l0GPj4GCiyG3P X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466716ejc.283.1644569159083; Fri, 11 Feb 2022 00:45:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQtGaHy5U9JGMvxdUhyHS51vk9smJiabHDR4QMkXJw//KX0Gh6ttUq7C+QmDdzvWmB7pzNDQ== X-Received: by 2002:a17:907:168a:: with SMTP id hc10mr466695ejc.283.1644569158862; Fri, 11 Feb 2022 00:45:58 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id v5sm10859303edb.15.2022.02.11.00.45.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 00:45:58 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 09:45:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 8/9] platform/x86: amd-gmux: drop the use of `pci_is_thunderbolt_attached` To: Mario Limonciello , Bjorn Helgaas , Andreas Noever , Mika Westerberg , "open list:PCI SUBSYSTEM" , "open list:THUNDERBOLT DRIVER" , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:DRM DRIVERS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:X86 PLATFORM DRIVERS" References: <20220210224329.2793-1-mario.limonciello@amd.com> <20220210224329.2793-9-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20220210224329.2793-9-mario.limonciello@amd.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Jamet , Yehezkel Bernat , Alexander.Deucher@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2/10/22 23:43, Mario Limonciello wrote: > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello Thanks, this looks good to me. I assume that this whole series will be merged in one go through another tree (e.g. the PCI tree), so here is my ack for merging this patch through another tree: Acked-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > > static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) >