From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D596BC433FE for ; Mon, 21 Nov 2022 15:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232240AbiKUPU2 (ORCPT ); Mon, 21 Nov 2022 10:20:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiKUPUO (ORCPT ); Mon, 21 Nov 2022 10:20:14 -0500 Received: from out199-10.us.a.mail.aliyun.com (out199-10.us.a.mail.aliyun.com [47.90.199.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 251C6175B6; Mon, 21 Nov 2022 07:17:18 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VVOOPHM_1669043831; Received: from 30.120.171.189(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VVOOPHM_1669043831) by smtp.aliyun-inc.com; Mon, 21 Nov 2022 23:17:13 +0800 Message-ID: Date: Mon, 21 Nov 2022 23:17:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org 在 2022/11/21 下午6:22, John Garry 写道: > >> >> >> #./perf stat -e FRONTEND_BOUND sleep 1 >> event syntax error: 'FRONTEND_BOUND' > > For metrics, use -M, not -e > > If this doesn't help, verify generated pmu-events/pmu-events.c is same after you make the change to try to use std arch events for metrics. Note that I never tested running my change. > > Thanks, > John > >>                       \___ parser error >> Run 'perf list' for a list of valid events >> >>   Usage: perf stat [] [] >> >>      -e, --event    event selector. use 'perf list' to list available events >> >> >> >> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeli >> index f9fae15..1089ca0 100644 >> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json >> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json >> @@ -6,18 +6,24 @@ >>           "ArchStdEvent": "STALL_BACKEND" >>       }, >>       { >> -        "ArchStdEvent": "STALL_SLOT_FRONTEND" >> +        "ArchStdEvent": "STALL_SLOT_FRONTEND", >> +        "MetricExpr": "STALL_SLOT_FRONTEND - CPU_CYCLES" >>       }, >>       { >> I'm sorry that I misunderstood the purpose of putting metric as arch_std_event at first, and now it works after the modification over your suggestion. But there are also a few questions: 1. The value of the slot in the topdownL1 is various in different architectures, for example, the slot is 5 on neoverse-n2. If I put topdownL1 metric as arch_std_event, then I need to specify the slot to 5 in n2. I can specify slot values in metric like below, but is there any other concise way to do this? diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json index 8ff1dfe..b473baf 100644 --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json @@ -1,4 +1,23 @@ [ + { + "MetricExpr": "5", + "PublicDescription": "A pipeline slot represents the hardware resources needed to process one uOp", + "BriefDescription": "A pipeline slot represents the hardware resources needed to process one uOp", + "MetricName": "slot" + }, + { + "ArchStdEvent": "FRONTEND_BOUND" + }, + { + "ArchStdEvent": "BACKEND_BOUND" + }, + { + "ArchStdEvent": "WASTED" + }, + { + "ArchStdEvent": "RETIRING" + }, 2. Should I add the topdownL1 metric to tools/perf/pmu-event/recommended.json, or create a new json file to place the general metric? Looking forward to your reply. Thanks, Jing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5961C433FE for ; Mon, 21 Nov 2022 15:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0mgb0KK6ul0NIcjcY2//UnNBEer9UJ8QSGTikv6A/RA=; b=FO0DhVOp+n/5R1 lmsfa4OLi7Ez4yN+oXAOTdQSztcK5wZlt/kVIMKP5ZaDKeZpbcjsaHmx9juSVjelP6cf1zEgAtQri FlJFaCapyOp3g6H/mT5Dj3vq6Ospvej9UreufguAQX1e7zTbk0cr0CsrbQwEsH4diM9VDfJKX/4p2 SrADdeh/R1WEjKvEAVMqopIsXaMC+M4Q8cCkf+uTaZg+w5TZjKQluAIDompFlmyhv6DfVsrMf8BXY 1tF7vZlkkhW4o4GTOH8jy1vZfG/FlUyYpdTRNLdjZCmVPICyKsXxG7zTahkhTWmiNeOxdiDb/SJaN NKxwMRzZ1kmQCGyReEfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox8hj-00FB2W-2U; Mon, 21 Nov 2022 15:27:28 +0000 Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox8Y1-00F4t1-Ir for linux-arm-kernel@lists.infradead.org; Mon, 21 Nov 2022 15:17:31 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VVOOPHM_1669043831; Received: from 30.120.171.189(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VVOOPHM_1669043831) by smtp.aliyun-inc.com; Mon, 21 Nov 2022 23:17:13 +0800 Message-ID: Date: Mon, 21 Nov 2022 23:17:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> From: Jing Zhang In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_071725_837288_3BCCFAAA X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrlnKggMjAyMi8xMS8yMSDkuIvljYg2OjIyLCBKb2huIEdhcnJ5IOWGmemBkzoKPiAKPj4KPj4K Pj4gIy4vcGVyZiBzdGF0IC1lIEZST05URU5EX0JPVU5EIHNsZWVwIDEKPj4gZXZlbnQgc3ludGF4 IGVycm9yOiAnRlJPTlRFTkRfQk9VTkQnCj4gCj4gRm9yIG1ldHJpY3MsIHVzZSAtTSwgbm90IC1l Cj4gCj4gSWYgdGhpcyBkb2Vzbid0IGhlbHAsIHZlcmlmeSBnZW5lcmF0ZWQgcG11LWV2ZW50cy9w bXUtZXZlbnRzLmMgaXMgc2FtZSBhZnRlciB5b3UgbWFrZSB0aGUgY2hhbmdlIHRvIHRyeSB0byB1 c2Ugc3RkIGFyY2ggZXZlbnRzIGZvciBtZXRyaWNzLiBOb3RlIHRoYXQgSSBuZXZlciB0ZXN0ZWQg cnVubmluZyBteSBjaGFuZ2UuCj4gCj4gVGhhbmtzLAo+IEpvaG4KPiAKPj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFxfX18gcGFyc2VyIGVycm9yCj4+IFJ1biAn cGVyZiBsaXN0JyBmb3IgYSBsaXN0IG9mIHZhbGlkIGV2ZW50cwo+Pgo+PiDCoCBVc2FnZTogcGVy ZiBzdGF0IFs8b3B0aW9ucz5dIFs8Y29tbWFuZD5dCj4+Cj4+IMKgwqDCoMKgIC1lLCAtLWV2ZW50 IDxldmVudD7CoMKgIGV2ZW50IHNlbGVjdG9yLiB1c2UgJ3BlcmYgbGlzdCcgdG8gbGlzdCBhdmFp bGFibGUgZXZlbnRzCj4+Cj4+Cj4+Cj4+IGRpZmYgLS1naXQgYS90b29scy9wZXJmL3BtdS1ldmVu dHMvYXJjaC9hcm02NC9hcm0vbmVvdmVyc2UtbjIvcGlwZWxpbmUuanNvbiBiL3Rvb2xzL3BlcmYv cG11LWV2ZW50cy9hcmNoL2FybTY0L2FybS9uZW92ZXJzZS1uMi9waXBlbGkKPj4gaW5kZXggZjlm YWUxNS4uMTA4OWNhMCAxMDA2NDQKPj4gLS0tIGEvdG9vbHMvcGVyZi9wbXUtZXZlbnRzL2FyY2gv YXJtNjQvYXJtL25lb3ZlcnNlLW4yL3BpcGVsaW5lLmpzb24KPj4gKysrIGIvdG9vbHMvcGVyZi9w bXUtZXZlbnRzL2FyY2gvYXJtNjQvYXJtL25lb3ZlcnNlLW4yL3BpcGVsaW5lLmpzb24KPj4gQEAg LTYsMTggKzYsMjQgQEAKPj4gwqDCoMKgwqDCoMKgwqDCoMKgICJBcmNoU3RkRXZlbnQiOiAiU1RB TExfQkFDS0VORCIKPj4gwqDCoMKgwqDCoCB9LAo+PiDCoMKgwqDCoMKgIHsKPj4gLcKgwqDCoMKg wqDCoMKgICJBcmNoU3RkRXZlbnQiOiAiU1RBTExfU0xPVF9GUk9OVEVORCIKPj4gK8KgwqDCoMKg wqDCoMKgICJBcmNoU3RkRXZlbnQiOiAiU1RBTExfU0xPVF9GUk9OVEVORCIsCj4+ICvCoMKgwqDC oMKgwqDCoCAiTWV0cmljRXhwciI6ICJTVEFMTF9TTE9UX0ZST05URU5EIC0gQ1BVX0NZQ0xFUyIK Pj4gwqDCoMKgwqDCoCB9LAo+PiDCoMKgwqDCoMKgIHsKPj4KCgpJJ20gc29ycnkgdGhhdCBJIG1p c3VuZGVyc3Rvb2QgdGhlIHB1cnBvc2Ugb2YgcHV0dGluZyBtZXRyaWMgYXMgYXJjaF9zdGRfZXZl bnQgYXQgZmlyc3QsCmFuZCBub3cgaXQgd29ya3MgYWZ0ZXIgdGhlIG1vZGlmaWNhdGlvbiBvdmVy IHlvdXIgc3VnZ2VzdGlvbi4KCkJ1dCB0aGVyZSBhcmUgYWxzbyBhIGZldyBxdWVzdGlvbnM6Cgox LiBUaGUgdmFsdWUgb2YgdGhlIHNsb3QgaW4gdGhlIHRvcGRvd25MMSBpcyB2YXJpb3VzIGluIGRp ZmZlcmVudCBhcmNoaXRlY3R1cmVzLCBmb3IgZXhhbXBsZSwKdGhlIHNsb3QgaXMgNSBvbiBuZW92 ZXJzZS1uMi4gSWYgSSBwdXQgdG9wZG93bkwxIG1ldHJpYyBhcyBhcmNoX3N0ZF9ldmVudCwgdGhl biBJIG5lZWQgdG8Kc3BlY2lmeSB0aGUgc2xvdCB0byA1IGluIG4yLiBJIGNhbiBzcGVjaWZ5IHNs b3QgdmFsdWVzIGluIG1ldHJpYyBsaWtlIGJlbG93LCBidXQgaXMgdGhlcmUgYW55Cm90aGVyIGNv bmNpc2Ugd2F5IHRvIGRvIHRoaXM/CgpkaWZmIC0tZ2l0IGEvdG9vbHMvcGVyZi9wbXUtZXZlbnRz L2FyY2gvYXJtNjQvYXJtL25lb3ZlcnNlLW4yL21ldHJpY3MuanNvbiBiL3Rvb2xzL3BlcmYvcG11 LWV2ZW50cy9hcmNoL2FybTY0L2FybS9uZW92ZXJzZS1uMi9tZXRyaWNzLmpzb24KaW5kZXggOGZm MWRmZS4uYjQ3M2JhZiAxMDA2NDQKLS0tIGEvdG9vbHMvcGVyZi9wbXUtZXZlbnRzL2FyY2gvYXJt NjQvYXJtL25lb3ZlcnNlLW4yL21ldHJpY3MuanNvbgorKysgYi90b29scy9wZXJmL3BtdS1ldmVu dHMvYXJjaC9hcm02NC9hcm0vbmVvdmVyc2UtbjIvbWV0cmljcy5qc29uCkBAIC0xLDQgKzEsMjMg QEAKWworICAgICAgIHsKKyAgICAgICAgICAgICAgICJNZXRyaWNFeHByIjogIjUiLAorICAgICAg ICAgICAgICAgIlB1YmxpY0Rlc2NyaXB0aW9uIjogIkEgcGlwZWxpbmUgc2xvdCByZXByZXNlbnRz IHRoZSBoYXJkd2FyZSByZXNvdXJjZXMgbmVlZGVkIHRvIHByb2Nlc3Mgb25lIHVPcCIsCisgICAg ICAgICAgICAgICAiQnJpZWZEZXNjcmlwdGlvbiI6ICJBIHBpcGVsaW5lIHNsb3QgcmVwcmVzZW50 cyB0aGUgaGFyZHdhcmUgcmVzb3VyY2VzIG5lZWRlZCB0byBwcm9jZXNzIG9uZSB1T3AiLAorICAg ICAgICAgICAgICAgIk1ldHJpY05hbWUiOiAic2xvdCIKKyAgICAgICB9LAorICAgICAgIHsKKyAg ICAgICAgICAgICAgICJBcmNoU3RkRXZlbnQiOiAiRlJPTlRFTkRfQk9VTkQiCisgICAgICAgfSwK KyAgICAgICB7CisgICAgICAgICAgICAgICAiQXJjaFN0ZEV2ZW50IjogIkJBQ0tFTkRfQk9VTkQi CisgICAgICAgfSwKKyAgICAgICB7CisgICAgICAgICAgICAgICAiQXJjaFN0ZEV2ZW50IjogIldB U1RFRCIKKyAgICAgICB9LAorICAgICAgIHsKKyAgICAgICAgICAgICAgICJBcmNoU3RkRXZlbnQi OiAiUkVUSVJJTkciCisgICAgICAgfSwKCgoyLiBTaG91bGQgSSBhZGQgdGhlIHRvcGRvd25MMSBt ZXRyaWMgdG8gdG9vbHMvcGVyZi9wbXUtZXZlbnQvcmVjb21tZW5kZWQuanNvbiwKb3IgY3JlYXRl IGEgbmV3IGpzb24gZmlsZSB0byBwbGFjZSB0aGUgZ2VuZXJhbCBtZXRyaWM/CgpMb29raW5nIGZv cndhcmQgdG8geW91ciByZXBseS4KClRoYW5rcywKSmluZwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=