From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F928946D for ; Thu, 21 Sep 2023 11:13:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF4CC4AF73; Thu, 21 Sep 2023 11:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695294791; bh=iw3ke3UbjDTAN2nBHhwP4e/dfZNBea9LZ0dNzqIP5iw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oVL3zEiZWx1Ni36n69czmH8Rndi0lBbS0Etby6v6VLdrb/eCFWzGQWOcyjO59CZT2 ddokokVjzOBmgBan+iAuFcfs4nHYzcymRO5YV5ArAgGX6r3XCr9Ngdtxza2FsY6oAm CuBGcqIhcCjt1tYjwszkhisv7eUM85hGImAVdBA9WwMbvoZccBPKeJLjXxYh5+haS1 fvXoYM2iWqGeJKJ6Oo75Pl5p3HjJ6WliEv1/7V1lwKsxQJrL4MMQOc7y9ioD46sOxH IEgqLfDj/WDhZn1+1RRKuoeEJ71Q3lzPKuwCwhnNL9PIJfcd1NKxetDhrcgEsfJQfr J4lvP+TUI2bhQ== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qjHcL-00EuE8-4R; Thu, 21 Sep 2023 12:13:09 +0100 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Thu, 21 Sep 2023 12:13:08 +0100 From: Marc Zyngier To: Joey Gouly Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Shameerali Kolothum Thodi , Xu Zhao , Eric Auger Subject: Re: [PATCH v2 03/11] KVM: arm64: vgic-v3: Refactor GICv3 SGI generation In-Reply-To: <20230921094225.GA2926762@e124191.cambridge.arm.com> References: <20230920181731.2232453-1-maz@kernel.org> <20230920181731.2232453-4-maz@kernel.org> <20230921094225.GA2926762@e124191.cambridge.arm.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, shameerali.kolothum.thodi@huawei.com, zhaoxu.35@bytedance.com, eric.auger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On 2023-09-21 10:42, Joey Gouly wrote: > Hi Marc, Oliver, > > On Wed, Sep 20, 2023 at 07:17:23PM +0100, Marc Zyngier wrote: >> As we're about to change the way SGIs are sent, start by splitting >> out some of the basic functionnality: instead of intermingling >> the broadcast and non-broadcast cases with the actual SGI generation, >> perform the following cleanups: >> >> - move the SGI queuing into its own helper >> - split the broadcast code from the affinity-driven code >> - replace the mask/shift combinations with FIELD_GET() >> >> The result is much more readable, and paves the way for further >> optimisations. >> >> Reviewed-by: Joey Gouly > > Want to point out that I didn't review this code, I only reviewed > patches 1-3 > from the original series. Ah crap. I try to make sure I was only tagging the right patches, but obviously failed... :-( Really sorry about that. > https://lore.kernel.org/linux-arm-kernel/20230907100931.1186690-1-maz@kernel.org/ > > Since it seems Oliver is picking it up, can you remove my r-b tag from > this patch. Well, Zenghui has found a couple of issues, so there will be a third revision for sure. I'll amend the patch right away. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72243E7071D for ; Thu, 21 Sep 2023 11:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hElBRYEjSeiIfbHNQZHe6WFq9AHU5+qLX7Yt8Y19C7g=; b=AGXmAL9uvrKVTQNbp9hT86+Kjm +4aYa9x7JhaHC6P3VZY++DJfPByGBVuubcSMDl74V0cOa63Am66n+YwCl4trPhMBtblMkCryfjBi8 0m5q0cv4zomjZi65hWuC5z5YJ+Hl4a5XrGxt9lydnu5hVR3mFgcHXDW/La01i1QbzdG3G2KzP6eHX 17buf/oUUYH9UbCCsRUzuH4u7nyoxKnrw0Igzk3zaLC1baeJYqhYxgnJAJTHpjhPBggPN+fbnC3da jiytf4T12Sj+UfCINsplZ6ZY7tFP0Nl8nlLSMMT6I3K4DgJ/dN3TTmFAx8ZB9gKYgcyPqqlG+Ul6/ nnK0AL2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjHcT-005tOl-34; Thu, 21 Sep 2023 11:13:17 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjHcQ-005tOA-2n for linux-arm-kernel@lists.infradead.org; Thu, 21 Sep 2023 11:13:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2DB7EB81FE5; Thu, 21 Sep 2023 11:13:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF4CC4AF73; Thu, 21 Sep 2023 11:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695294791; bh=iw3ke3UbjDTAN2nBHhwP4e/dfZNBea9LZ0dNzqIP5iw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oVL3zEiZWx1Ni36n69czmH8Rndi0lBbS0Etby6v6VLdrb/eCFWzGQWOcyjO59CZT2 ddokokVjzOBmgBan+iAuFcfs4nHYzcymRO5YV5ArAgGX6r3XCr9Ngdtxza2FsY6oAm CuBGcqIhcCjt1tYjwszkhisv7eUM85hGImAVdBA9WwMbvoZccBPKeJLjXxYh5+haS1 fvXoYM2iWqGeJKJ6Oo75Pl5p3HjJ6WliEv1/7V1lwKsxQJrL4MMQOc7y9ioD46sOxH IEgqLfDj/WDhZn1+1RRKuoeEJ71Q3lzPKuwCwhnNL9PIJfcd1NKxetDhrcgEsfJQfr J4lvP+TUI2bhQ== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qjHcL-00EuE8-4R; Thu, 21 Sep 2023 12:13:09 +0100 MIME-Version: 1.0 Date: Thu, 21 Sep 2023 12:13:08 +0100 From: Marc Zyngier To: Joey Gouly Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Shameerali Kolothum Thodi , Xu Zhao , Eric Auger Subject: Re: [PATCH v2 03/11] KVM: arm64: vgic-v3: Refactor GICv3 SGI generation In-Reply-To: <20230921094225.GA2926762@e124191.cambridge.arm.com> References: <20230920181731.2232453-1-maz@kernel.org> <20230920181731.2232453-4-maz@kernel.org> <20230921094225.GA2926762@e124191.cambridge.arm.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, shameerali.kolothum.thodi@huawei.com, zhaoxu.35@bytedance.com, eric.auger@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230921_041315_210417_D4BC9EA5 X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-09-21 10:42, Joey Gouly wrote: > Hi Marc, Oliver, > > On Wed, Sep 20, 2023 at 07:17:23PM +0100, Marc Zyngier wrote: >> As we're about to change the way SGIs are sent, start by splitting >> out some of the basic functionnality: instead of intermingling >> the broadcast and non-broadcast cases with the actual SGI generation, >> perform the following cleanups: >> >> - move the SGI queuing into its own helper >> - split the broadcast code from the affinity-driven code >> - replace the mask/shift combinations with FIELD_GET() >> >> The result is much more readable, and paves the way for further >> optimisations. >> >> Reviewed-by: Joey Gouly > > Want to point out that I didn't review this code, I only reviewed > patches 1-3 > from the original series. Ah crap. I try to make sure I was only tagging the right patches, but obviously failed... :-( Really sorry about that. > https://lore.kernel.org/linux-arm-kernel/20230907100931.1186690-1-maz@kernel.org/ > > Since it seems Oliver is picking it up, can you remove my r-b tag from > this patch. Well, Zenghui has found a couple of issues, so there will be a third revision for sure. I'll amend the patch right away. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel