From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E5FC04AAC for ; Tue, 21 May 2019 01:32:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B9FC21479 for ; Tue, 21 May 2019 01:32:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="F47/6NMr"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="h307RjJc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727530AbfEUBcb (ORCPT ); Mon, 20 May 2019 21:32:31 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56296 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727043AbfEUBcb (ORCPT ); Mon, 20 May 2019 21:32:31 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8FFEC602B7; Tue, 21 May 2019 01:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558402350; bh=jUBciQwDLO8DI/ZPhk5HhSoTVtSqS/+i48ZqN5DOVwA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F47/6NMrbkhdAJ9MAogrobowwRLAa43aexBQxM2FzC/DbcjHMMhXAkYQDccVcOYrL Lo3XUC5vrv929pXKxtjGzFBzjGWqPA4Q6NYeiNiKz5RG8PmuFZGPXh9hd0kvnjCnZQ DZPNPlNrPDXWPZn7y9rwx811gwG6XSsKuTUSMlf4= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 85C5A602B7; Tue, 21 May 2019 01:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558402349; bh=jUBciQwDLO8DI/ZPhk5HhSoTVtSqS/+i48ZqN5DOVwA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h307RjJc9xkBcbnBvEAcel6wzzP0lSQJmwqychQ0OK2jcvpNKzB+evEcy2FajZfZz y5AWG98+nUS1Kbj6zWQTquwNyIzxv13pm6e252k+Vf0iywk3GTe+Yd8CWLzAjOFcTh M6Fcpp54cyEfJOInaRF0yUB7joAZKpDXbaZREXac= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 20 May 2019 19:32:29 -0600 From: Subash Abhinov Kasiviswanathan To: Alex Elder Cc: arnd@arndb.de, david.brown@linaro.org, agross@kernel.org, davem@davemloft.net, bjorn.andersson@linaro.org, ilias.apalodimas@linaro.org, cpratapa@codeaurora.org, syadagir@codeaurora.org, evgreen@chromium.org, benchan@google.com, ejcaruso@google.com, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header In-Reply-To: <81fd1e01-b8e3-f86a-fcc9-2bcbc51bd679@linaro.org> References: <20190520135354.18628-1-elder@linaro.org> <20190520135354.18628-2-elder@linaro.org> <81fd1e01-b8e3-f86a-fcc9-2bcbc51bd679@linaro.org> Message-ID: X-Sender: subashab@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org >> If the above illustration is supposed to be in network byte order, >> then it is wrong. The documentation has the definition for the MAP >> packet. > > Network *bit* order is irrelevant to the host. Host memory is > byte addressable only, and bit 0 is the low-order bit. > >> Packet format - >> >> Bit             0             1           2-7      8 - 15           16 >> - 31 >> Function   Command / Data   Reserved     Pad   Multiplexer ID    >> Payload length >> Bit            32 - x >> Function     Raw  Bytes > > I don't know how to interpret this. Are you saying that the low- > order bit of the first byte is the command/data flag? Or is it > the high-order bit of the first byte? > > I'm saying that what I observed when building the code was that > as originally defined, the cd_bit field was the high-order bit > (bit 7) of the first byte, which I understand to be wrong. > > If you are telling me that the command/data flag resides at bit > 7 of the first byte, I will update the field masks in a later > patch in this series to reflect that. > Higher order bit is Command / Data. >> The driver was written assuming that the host was running ARM64, so >> the structs are little endian. (I should have made it compatible >> with big and little endian earlier so that is my fault). > > Little endian and big endian have no bearing on the host's > interpretation of bits within a byte. > > Please clarify. I want the patches to be correct, and what > you're explaining doesn't really straighten things out for me. > > -Alex Can't this bitfields just be used similar to how struct tcphdr & iphdr are currently defined. That way, you dont have to make these many changes. diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h index 884f1f5..302d1db 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h @@ -40,9 +40,17 @@ enum rmnet_map_commands { }; struct rmnet_map_header { +#if defined(__LITTLE_ENDIAN_BITFIELD) u8 pad_len:6; u8 reserved_bit:1; u8 cd_bit:1; +#elif defined (__BIG_ENDIAN_BITFIELD) + u8 cd_bit:1; + u8 reserved_bit:1; + u8 pad_len:6; +#else +#error "Please fix " +#endif u8 mux_id; __be16 pkt_len; } __aligned(1); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5C3C04AAC for ; Tue, 21 May 2019 01:32:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B06521479 for ; Tue, 21 May 2019 01:32:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hwz8MzyZ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="F47/6NMr"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="h307RjJc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B06521479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hcBvrVGBsNHoZDXrHyoa3Ot2P8FvUl9zb74Lxz8iKC0=; b=hwz8MzyZQRgIHDMJjApuLmyA1 D3fzV86S9QmiuOKNt2hWcbqWb8iv0hFCGWgT7gJKLkSMvaEWLF5sAlxL8UXjqVb3D4l13SFJIvBaH epama8WHyF41vXKekV+fPcijruCuXpU5ggmsCTUj8tqIMPD2QJkSyboGQ4/fr0Nj6A8WjWQFmqXMY B+41BBH+K8Eg2lfma7FwVq+Zb48DvmVI63qdk82/0y76W2bsZuuTX6yqC2uzcekP2qKJDCfPxcALP ng544pZkAkj9/T/vgPEvoKA7/5lADCKGT4E/+JnkFYI5i2L4lx2RuRvT+/XO2/p0WdCzrot7Pzx5T Tom2j9iEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hStdq-0005Rm-0w; Tue, 21 May 2019 01:32:34 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hStdn-0005RI-07 for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 01:32:32 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 728B3608D4; Tue, 21 May 2019 01:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558402350; bh=jUBciQwDLO8DI/ZPhk5HhSoTVtSqS/+i48ZqN5DOVwA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F47/6NMrbkhdAJ9MAogrobowwRLAa43aexBQxM2FzC/DbcjHMMhXAkYQDccVcOYrL Lo3XUC5vrv929pXKxtjGzFBzjGWqPA4Q6NYeiNiKz5RG8PmuFZGPXh9hd0kvnjCnZQ DZPNPlNrPDXWPZn7y9rwx811gwG6XSsKuTUSMlf4= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 85C5A602B7; Tue, 21 May 2019 01:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558402349; bh=jUBciQwDLO8DI/ZPhk5HhSoTVtSqS/+i48ZqN5DOVwA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h307RjJc9xkBcbnBvEAcel6wzzP0lSQJmwqychQ0OK2jcvpNKzB+evEcy2FajZfZz y5AWG98+nUS1Kbj6zWQTquwNyIzxv13pm6e252k+Vf0iywk3GTe+Yd8CWLzAjOFcTh M6Fcpp54cyEfJOInaRF0yUB7joAZKpDXbaZREXac= MIME-Version: 1.0 Date: Mon, 20 May 2019 19:32:29 -0600 From: Subash Abhinov Kasiviswanathan To: Alex Elder Subject: Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header In-Reply-To: <81fd1e01-b8e3-f86a-fcc9-2bcbc51bd679@linaro.org> References: <20190520135354.18628-1-elder@linaro.org> <20190520135354.18628-2-elder@linaro.org> <81fd1e01-b8e3-f86a-fcc9-2bcbc51bd679@linaro.org> Message-ID: X-Sender: subashab@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_183231_076462_66788407 X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syadagir@codeaurora.org, ejcaruso@google.com, arnd@arndb.de, netdev@vger.kernel.org, ilias.apalodimas@linaro.org, linux-kernel@vger.kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, david.brown@linaro.org, agross@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, davem@davemloft.net, cpratapa@codeaurora.org, benchan@google.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Pj4gSWYgdGhlIGFib3ZlIGlsbHVzdHJhdGlvbiBpcyBzdXBwb3NlZCB0byBiZSBpbiBuZXR3b3Jr IGJ5dGUgb3JkZXIsCj4+IHRoZW4gaXQgaXMgd3JvbmcuIFRoZSBkb2N1bWVudGF0aW9uIGhhcyB0 aGUgZGVmaW5pdGlvbiBmb3IgdGhlIE1BUAo+PiBwYWNrZXQuCj4gCj4gTmV0d29yayAqYml0KiBv cmRlciBpcyBpcnJlbGV2YW50IHRvIHRoZSBob3N0LiAgSG9zdCBtZW1vcnkgaXMKPiBieXRlIGFk ZHJlc3NhYmxlIG9ubHksIGFuZCBiaXQgMCBpcyB0aGUgbG93LW9yZGVyIGJpdC4KPiAKPj4gUGFj a2V0IGZvcm1hdCAtCj4+IAo+PiBCaXTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAxwqDCoMKgwqDCoMKgwqDCoMKgwqAgMi03wqDCoMKgwqDCoCA4IC0g MTXCoMKgwqDCoMKgwqDCoMKgwqDCoCAxNiAKPj4gLSAzMQo+PiBGdW5jdGlvbsKgwqAgQ29tbWFu ZCAvIERhdGHCoMKgIFJlc2VydmVkwqDCoMKgwqAgUGFkwqDCoCBNdWx0aXBsZXhlciBJRMKgwqDC oCAKPj4gUGF5bG9hZCBsZW5ndGgKPj4gQml0wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAzMiAtIHgK Pj4gRnVuY3Rpb27CoMKgwqDCoCBSYXfCoCBCeXRlcwo+IAo+IEkgZG9uJ3Qga25vdyBob3cgdG8g aW50ZXJwcmV0IHRoaXMuICBBcmUgeW91IHNheWluZyB0aGF0IHRoZSBsb3ctCj4gb3JkZXIgYml0 IG9mIHRoZSBmaXJzdCBieXRlIGlzIHRoZSBjb21tYW5kL2RhdGEgZmxhZz8gIE9yIGlzIGl0Cj4g dGhlIGhpZ2gtb3JkZXIgYml0IG9mIHRoZSBmaXJzdCBieXRlPwo+IAo+IEknbSBzYXlpbmcgdGhh dCB3aGF0IEkgb2JzZXJ2ZWQgd2hlbiBidWlsZGluZyB0aGUgY29kZSB3YXMgdGhhdAo+IGFzIG9y aWdpbmFsbHkgZGVmaW5lZCwgdGhlIGNkX2JpdCBmaWVsZCB3YXMgdGhlIGhpZ2gtb3JkZXIgYml0 Cj4gKGJpdCA3KSBvZiB0aGUgZmlyc3QgYnl0ZSwgd2hpY2ggSSB1bmRlcnN0YW5kIHRvIGJlIHdy b25nLgo+IAo+IElmIHlvdSBhcmUgdGVsbGluZyBtZSB0aGF0IHRoZSBjb21tYW5kL2RhdGEgZmxh ZyByZXNpZGVzIGF0IGJpdAo+IDcgb2YgdGhlIGZpcnN0IGJ5dGUsIEkgd2lsbCB1cGRhdGUgdGhl IGZpZWxkIG1hc2tzIGluIGEgbGF0ZXIKPiBwYXRjaCBpbiB0aGlzIHNlcmllcyB0byByZWZsZWN0 IHRoYXQuCj4gCgpIaWdoZXIgb3JkZXIgYml0IGlzIENvbW1hbmQgLyBEYXRhLgoKPj4gVGhlIGRy aXZlciB3YXMgd3JpdHRlbiBhc3N1bWluZyB0aGF0IHRoZSBob3N0IHdhcyBydW5uaW5nIEFSTTY0 LCBzbwo+PiB0aGUgc3RydWN0cyBhcmUgbGl0dGxlIGVuZGlhbi4gKEkgc2hvdWxkIGhhdmUgbWFk ZSBpdCBjb21wYXRpYmxlCj4+IHdpdGggYmlnIGFuZCBsaXR0bGUgZW5kaWFuIGVhcmxpZXIgc28g dGhhdCBpcyBteSBmYXVsdCkuCj4gCj4gTGl0dGxlIGVuZGlhbiBhbmQgYmlnIGVuZGlhbiBoYXZl IG5vIGJlYXJpbmcgb24gdGhlIGhvc3Qncwo+IGludGVycHJldGF0aW9uIG9mIGJpdHMgd2l0aGlu IGEgYnl0ZS4KPiAKPiBQbGVhc2UgY2xhcmlmeS4gIEkgd2FudCB0aGUgcGF0Y2hlcyB0byBiZSBj b3JyZWN0LCBhbmQgd2hhdAo+IHlvdSdyZSBleHBsYWluaW5nIGRvZXNuJ3QgcmVhbGx5IHN0cmFp Z2h0ZW4gdGhpbmdzIG91dCBmb3IgbWUuCj4gCj4gCQkJCQktQWxleAoKQ2FuJ3QgdGhpcyBiaXRm aWVsZHMganVzdCBiZSB1c2VkIHNpbWlsYXIgdG8gaG93IHN0cnVjdCB0Y3BoZHIgJgppcGhkciBh cmUgY3VycmVudGx5IGRlZmluZWQuIFRoYXQgd2F5LCB5b3UgZG9udCBoYXZlIHRvIG1ha2UKdGhl c2UgbWFueSBjaGFuZ2VzLgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3F1YWxj b21tL3JtbmV0L3JtbmV0X21hcC5oIApiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3F1YWxjb21tL3Jt bmV0L3JtbmV0X21hcC5oCmluZGV4IDg4NGYxZjUuLjMwMmQxZGIgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvbmV0L2V0aGVybmV0L3F1YWxjb21tL3JtbmV0L3JtbmV0X21hcC5oCisrKyBiL2RyaXZlcnMv bmV0L2V0aGVybmV0L3F1YWxjb21tL3JtbmV0L3JtbmV0X21hcC5oCkBAIC00MCw5ICs0MCwxNyBA QCBlbnVtIHJtbmV0X21hcF9jb21tYW5kcyB7CiAgfTsKCiAgc3RydWN0IHJtbmV0X21hcF9oZWFk ZXIgeworI2lmIGRlZmluZWQoX19MSVRUTEVfRU5ESUFOX0JJVEZJRUxEKQogICAgICAgICB1OCAg cGFkX2xlbjo2OwogICAgICAgICB1OCAgcmVzZXJ2ZWRfYml0OjE7CiAgICAgICAgIHU4ICBjZF9i aXQ6MTsKKyNlbGlmIGRlZmluZWQgKF9fQklHX0VORElBTl9CSVRGSUVMRCkKKyAgICAgICB1OCAg Y2RfYml0OjE7CisgICAgICAgdTggIHJlc2VydmVkX2JpdDoxOworICAgICAgIHU4ICBwYWRfbGVu OjY7CisjZWxzZQorI2Vycm9yICJQbGVhc2UgZml4IDxhc20vYnl0ZW9yZGVyLmg+IgorI2VuZGlm CiAgICAgICAgIHU4ICBtdXhfaWQ7CiAgICAgICAgIF9fYmUxNiBwa3RfbGVuOwogIH0gIF9fYWxp Z25lZCgxKTsKCgotLSAKUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1i ZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0aXZl IFByb2plY3QKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK