From: Denis Kenzior <denkenz@gmail.com>
To: Greg Depoire--Ferrer <greg@gregdf.com>, ell@lists.linux.dev
Subject: Re: [PATCH 3/3] dhcp-transport: Initialize the udp_fd field
Date: Mon, 6 Jun 2022 13:17:28 -0500 [thread overview]
Message-ID: <d9136de0-9732-d2b6-0243-45509d74db4e@gmail.com> (raw)
In-Reply-To: <20220507235434.11693-4-greg@gregdf.com>
Hi Greg,
On 5/7/22 18:54, Greg Depoire--Ferrer wrote:
> Initialize the udp_fd field to -1 in _dhcp_default_transport_new to
> prevent future mistakes where a random FD is closed when the transport
> is closed before the field is initialized.
> ---
> ell/dhcp-transport.c | 1 +
> 1 file changed, 1 insertion(+)
>
This mailing list isn't quite live yet, so I somehow managed to miss this
series. Sorry about that. Wish I didn't since it would have saved me some time :(
Anyhow, there was a related fix applied as commit:
f5fccbab31e6 ("dhcp-transport: Do not leak fds during bind")
Regards,
-Denis
next prev parent reply other threads:[~2022-06-06 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 23:54 Fix bug when stdin is closed Greg Depoire--Ferrer
2022-05-07 23:54 ` [PATCH 1/3] main: Accept FD 0 as epoll_fd Greg Depoire--Ferrer
2022-05-07 23:54 ` [PATCH 2/3] dhcp6-transport: Remove udp_fd field Greg Depoire--Ferrer
2022-05-07 23:54 ` [PATCH 3/3] dhcp-transport: Initialize the " Greg Depoire--Ferrer
2022-06-06 18:17 ` Denis Kenzior [this message]
2022-06-06 18:18 ` Fix bug when stdin is closed Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9136de0-9732-d2b6-0243-45509d74db4e@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.linux.dev \
--cc=greg@gregdf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.