From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FFBCC369D1 for ; Sat, 26 Apr 2025 08:31:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8avy-00045V-L5; Sat, 26 Apr 2025 04:30:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8avt-00043D-70 for qemu-riscv@nongnu.org; Sat, 26 Apr 2025 04:30:49 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8avq-0004LA-O0 for qemu-riscv@nongnu.org; Sat, 26 Apr 2025 04:30:44 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-736bfa487c3so2584132b3a.1 for ; Sat, 26 Apr 2025 01:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1745656241; x=1746261041; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pXbbJQSWqPpaCc2U+T+WKRvaPpL1EgR83G6V9j6LHHQ=; b=n6Om5nX21Z9ZMF75qgAhPvbDnLJYDSKtyKNfNG8daWU5IgqZSMJtejXtF5CVsxBJYY NAneUPGuUjczZ3snG516d0Z/ZpMI6f2p9aQMTW2xLZI7h6l3KpBtv4psrKERYi9uybfe rmmiFKSNlNFWDLedYQ1vjGSSoH/GKfS8c9FcmwLVATxcwS5MmpYgeRCz3vv9kMIf/OCF NgEqA3iQRTV459zodHAlmXl4+WnVAE1CZnBb54phiJGYOPTklyamqi5TM78DHTF3/+LC KjOegpDnJtU8XbeV5xQE/f9ayV2+z1coCOMELM/jHghg5bjBImUNJFnzLssCv6ItmUfw WINw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745656241; x=1746261041; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pXbbJQSWqPpaCc2U+T+WKRvaPpL1EgR83G6V9j6LHHQ=; b=FBRnLAQ1EsiRlFbWZFEzz95/y4Z/al3w0Z8tpbOjYyVL7segiiFjZtPE4/OdqQwV2L eFy+mv5tClsFxcOjP6xd1BeP4fOTZZDmNRprfxmWxyIKVSQ8x8lf4TlAi3GXYPUP3Qjx WGiX4/Meg8lPqsAyjWCQ4nkVwMJ1+wCXspsBeRMxaVlsJU7PrZg1T4QT1yl6s425CnCJ 0ZNWfO6WHkLNv4iJRfQkdxH5nRiLhKuab2Kv+ehabVdC6kHDLkEyXEFejlu+EJzhG8d3 dO5nHAeK1VL9+mcjqZ0RPSB8JImjxMswifDg1SnuRM0NfeqwIZ6H0ypluF3KGObg/UQr eMAg== X-Gm-Message-State: AOJu0YwLs5jHRhwVmgXzD204VCx/bXzYcSjqRkIUMOUdf1vSkUHfRWW+ 4TDmt8xmX9ix97/+SS43Ew4nuz01lmsUPIlqP1KSBy25a5RujDajQMwwi7mRNk8= X-Gm-Gg: ASbGncu7znYPRwAK1fBwwlgxWeMpp6tPXGQLwiIHXQ4/mJFKAVTz0BrHtfSNv3nfiwK xSojhcPp4WnfPnH6/x5A9FuN4r35QMkXyecg8CKcLVuTNFQ10bot9Xfd7ZBeiruehYun/HUaBq1 d0ryxIfGbcvujUHYm/2WeR6Da42p+ozwJU6h4+FMRSdSi9kTXS70eT8yFL+njakqE5jKoCNyIAo pz5/P8r3zzX9tsUtt11A56YScRDZa/jgmFblPjb+SJzrOHDds0isiqWiNNdDVnvsibtmhn6Q0kn gky0i/XDII0ff2JuA//tOsPG08e/yF0mjcWV4bHWPTS3sZJEYCzNgT8= X-Google-Smtp-Source: AGHT+IEdichjp3aJs5LwTnmSDYswayiBj6itqmJs3n1QWQxjZcTSfMCAT5h7eeVanHpycRuz1KuN5w== X-Received: by 2002:a05:6a21:3296:b0:204:695f:47e1 with SMTP id adf61e73a8af0-2046a58d91cmr2699305637.23.1745656241271; Sat, 26 Apr 2025 01:30:41 -0700 (PDT) Received: from [192.168.68.110] ([152.234.125.33]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a9d44esm4534556b3a.148.2025.04.26.01.30.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Apr 2025 01:30:40 -0700 (PDT) Message-ID: Date: Sat, 26 Apr 2025 05:30:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH alternate 0/2] target/riscv: Fix write_misa vs aligned next_pc To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com References: <20250425165055.807801-1-richard.henderson@linaro.org> <4cfc3a69-bae7-41ae-9f82-13eee8a8164e@linaro.org> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <4cfc3a69-bae7-41ae-9f82-13eee8a8164e@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=dbarboza@ventanamicro.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 4/25/25 7:35 PM, Philippe Mathieu-Daudé wrote: > On 25/4/25 18:50, Richard Henderson wrote: >> This is an alternate, but less exact approach.  It assumes that there >> will never be a 16 or 48-bit csr write instruction.  This feels dirtier, >> but it's a fair assumption involves much less faff. > > I prefer the other safer version which properly propagate $ra, which > could be useful for callees. Both are fine to me. Alistair can pick the one he likes more. Thanks, Daniel