From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A933DC54E41 for ; Thu, 29 Feb 2024 16:21:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.687284.1070517 (Exim 4.92) (envelope-from ) id 1rfj9w-0007eu-F6; Thu, 29 Feb 2024 16:21:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 687284.1070517; Thu, 29 Feb 2024 16:21:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rfj9w-0007en-CD; Thu, 29 Feb 2024 16:21:24 +0000 Received: by outflank-mailman (input) for mailman id 687284; Thu, 29 Feb 2024 16:21:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rfj9v-0007eh-QW for xen-devel@lists.xenproject.org; Thu, 29 Feb 2024 16:21:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 936535ef-d71e-11ee-a1ee-f123f15fe8a2; Thu, 29 Feb 2024 17:21:21 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 4E10D4EE0737; Thu, 29 Feb 2024 17:21:21 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 936535ef-d71e-11ee-a1ee-f123f15fe8a2 MIME-Version: 1.0 Date: Thu, 29 Feb 2024 17:21:21 +0100 From: Nicola Vetrini To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, jbeulich@suse.com, roger.pau@citrix.com, bertrand.marquis@arm.com, julien@xen.org, George Dunlap , Wei Liu Subject: Re: [XEN PATCH 01/10] xen/include: address violations of MISRA C Rule 20.7 In-Reply-To: References: <15d6e4fb5c873e7ea42cfcee2faa0bf33c10d101.1709219010.git.nicola.vetrini@bugseng.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024-02-29 17:10, Andrew Cooper wrote: > On 29/02/2024 3:27 pm, Nicola Vetrini wrote: >> diff --git a/xen/include/xen/kconfig.h b/xen/include/xen/kconfig.h >> index c25dc0f6c2a9..b7e70289737b 100644 >> --- a/xen/include/xen/kconfig.h >> +++ b/xen/include/xen/kconfig.h >> @@ -25,7 +25,7 @@ >> #define __ARG_PLACEHOLDER_1 0, >> #define config_enabled(cfg) _config_enabled(cfg) >> #define _config_enabled(value) >> __config_enabled(__ARG_PLACEHOLDER_##value) >> -#define __config_enabled(arg1_or_junk) ___config_enabled(arg1_or_junk >> 1, 0) >> +#define __config_enabled(arg1_or_junk) ___config_enabled(arg1_or_junk >> (1), (0)) >> #define ___config_enabled(__ignored, val, ...) val > > This one hunk I suggest we deviate rather than adjust.  You've subtly > broken it, and it's extreme preprocessor magic in the first place to > turn an absent symbol into a 0. > How so? I did test this because I was very wary of it, but it seemed to expand fine (either if ((0)) or if ((1)) ). I may of course be wrong, and it could be deviated regardless. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)