From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12B3BC433DB for ; Tue, 12 Jan 2021 11:50:23 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 7BFAD23109 for ; Tue, 12 Jan 2021 11:50:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BFAD23109 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BB3A54B2BE; Tue, 12 Jan 2021 06:50:21 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 56m8rcBJ9z8n; Tue, 12 Jan 2021 06:50:20 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8E7474B2BB; Tue, 12 Jan 2021 06:50:20 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 87EC34B2B9 for ; Tue, 12 Jan 2021 06:50:19 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DgxSoELEzagi for ; Tue, 12 Jan 2021 06:50:18 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 50E1D4B2B5 for ; Tue, 12 Jan 2021 06:50:18 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05C6F23104; Tue, 12 Jan 2021 11:50:17 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kzIBi-006wqv-RB; Tue, 12 Jan 2021 11:50:14 +0000 MIME-Version: 1.0 Date: Tue, 12 Jan 2021 11:50:14 +0000 From: Marc Zyngier To: Suzuki K Poulose Subject: Re: [PATCH v3 09/21] arm64: cpufeature: Add global feature override facility In-Reply-To: References: <20210111132811.2455113-1-maz@kernel.org> <20210111132811.2455113-10-maz@kernel.org> <20210111184154.GC17941@gaia> <129db8bd3913a90c96d4cfe4f55e27a0@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, will@kernel.org, mark.rutland@arm.com, dbrazdil@google.com, alexandru.elisei@arm.com, ardb@kernel.org, jingzhangos@google.com, pajay@qti.qualcomm.com, psodagud@codeaurora.org, sramana@codeaurora.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Prasad Sodagudi , Srinivas Ramana , kernel-team@android.com, Catalin Marinas , linux-kernel@vger.kernel.org, Ard Biesheuvel , Ajay Patil , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgU3V6dWtpLAoKT24gMjAyMS0wMS0xMiAwOToxNywgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToK PiBIaSBNYXJjLAo+IAo+IE9uIDEvMTEvMjEgNzo0OCBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgoK Wy4uLl0KCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9jcHVmZWF0dXJlLmMgCj4+ IGIvYXJjaC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+IGluZGV4IDg5NGFmNjBiOTY2OS4u MDBkOTllNTkzYjY1IDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybTY0L2tlcm5lbC9jcHVmZWF0dXJl LmMKPj4gKysrIGIvYXJjaC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+IEBAIC03NzQsNiAr Nzc0LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IGluaXRfY3B1X2Z0cl9yZWcodTMyIHN5c19yZWcs IAo+PiB1NjQgbmV3KQo+PiAgwqDCoMKgwqAgdTY0IHN0cmljdF9tYXNrID0gfjB4MFVMTDsKPj4g IMKgwqDCoMKgIHU2NCB1c2VyX21hc2sgPSAwOwo+PiAgwqDCoMKgwqAgdTY0IHZhbGlkX21hc2sg PSAwOwo+PiArwqDCoMKgIHU2NCBvdmVycmlkZV92YWwgPSAwLCBvdmVycmlkZV9tYXNrID0gMDsK Pj4gCj4+ICDCoMKgwqDCoCBjb25zdCBzdHJ1Y3QgYXJtNjRfZnRyX2JpdHMgKmZ0cnA7Cj4+ICDC oMKgwqDCoCBzdHJ1Y3QgYXJtNjRfZnRyX3JlZyAqcmVnID0gZ2V0X2FybTY0X2Z0cl9yZWcoc3lz X3JlZyk7Cj4+IEBAIC03ODEsOSArNzgyLDM1IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBpbml0X2Nw dV9mdHJfcmVnKHUzMiBzeXNfcmVnLCAKPj4gdTY0IG5ldykKPj4gIMKgwqDCoMKgIGlmICghcmVn KQo+PiAgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm47Cj4+IAo+PiArwqDCoMKgIGlmIChyZWctPm92 ZXJyaWRlX21hc2sgJiYgcmVnLT5vdmVycmlkZV92YWwpIHsKPj4gK8KgwqDCoMKgwqDCoMKgIG92 ZXJyaWRlX21hc2sgPSAqcmVnLT5vdmVycmlkZV9tYXNrOwo+PiArwqDCoMKgwqDCoMKgwqAgb3Zl cnJpZGVfdmFsID0gKnJlZy0+b3ZlcnJpZGVfdmFsOwo+PiArwqDCoMKgIH0KPj4gKwo+PiAgwqDC oMKgwqAgZm9yIChmdHJwID0gcmVnLT5mdHJfYml0czsgZnRycC0+d2lkdGg7IGZ0cnArKykgewo+ PiAgwqDCoMKgwqDCoMKgwqDCoCB1NjQgZnRyX21hc2sgPSBhcm02NF9mdHJfbWFzayhmdHJwKTsK Pj4gIMKgwqDCoMKgwqDCoMKgwqAgczY0IGZ0cl9uZXcgPSBhcm02NF9mdHJfdmFsdWUoZnRycCwg bmV3KTsKPj4gK8KgwqDCoMKgwqDCoMKgIHM2NCBmdHJfb3ZyID0gYXJtNjRfZnRyX3ZhbHVlKGZ0 cnAsIG92ZXJyaWRlX3ZhbCk7Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIGlmICgoZnRyX21hc2sg JiBvdmVycmlkZV9tYXNrKSA9PSBmdHJfbWFzaykgewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBpZiAoZnRyX292ciA8IGZ0cl9uZXcpIHsKPiAKPiBIZXJlIHdlIGFzc3VtZSB0aGF0IGFsbCB0 aGUgZmVhdHVyZXMgYXJlIEZUUl9MT1dFUl9TQUZFLiBXZSBjb3VsZAo+IHByb2JhYmx5IHVzZSBh cm02NF9mdHJfc2FmZV92YWx1ZShmdHJwLCBmdHJfbmV3LCBmdHJfb3ZyKSBoZXJlID8KPiBUaGF0 IHdvdWxkIGNvdmVyIHVzIGZvciBib3RoIEhJR0hFUl9TQUZFIGFuZCBMT1dFUl9TQUZFIGZlYXR1 cmVzLgo+IEhvd2V2ZXIgdGhhdCBtYXkgYmUgcmVzdHJpY3RpdmUgZm9yIEZUUl9FWEFDVCwgYXMg d2UgdGhlIHNhZmUKPiB2YWx1ZSB3b3VsZCBiZSBzZXQgdG8gImZ0ci0+c2FmZV92YWwiLiBJIGd1 ZXNzIHRoYXQgbWF5IGJlIGJldHRlcgo+IHRoYW4gZm9yY2luZyB0byB1c2UgYW4gdW5zYWZlIHZh bHVlIGZvciB0aGUgYm9vdCBDUFUsIHdoaWNoIGNvdWxkCj4gYW55d2F5IGNvbmZsaWN0IHdpdGgg dGhlIG90aGVyIENQVXMgYW5kIGV2ZW50dWFsbHkgdHJpZ2dlciB0aGUKPiBmdHIgYWx1ZSB0byBi ZSBzYWZlX3ZhbC4KCkkgbGlrZSB0aGUgaWRlYSBvZiB1c2luZyB0aGUgaGVscGVyLCBhcyBpdCBj bGVhbnVwcyB1cCB0aGUgY29kZSBhIGJpdC4KSG93ZXZlciwgbm90IGJlaW5nIHRvIHNldCBhIGZl YXR1cmUgdG8gYSBjZXJ0YWluIHZhbHVlIGNvdWxkIGJlIApyZXN0cmljdGl2ZSwKYXMgaW4gZ2Vu ZXJhbCwgaXQgbWVhbnMgdGhhdCB3ZSBjYW4gb25seSBkaXNhYmxlIGEgZmVhdHVyZSBhbmQgbm90 IAphZGp1c3QKaXRzIGxldmVsIG9mIHN1cHBvcnQuCgpUYWtlIFBNVVZFUiBmb3IgZXhhbXBsZTog d2l0aCB0aGUgaGVscGVyLCBJIGNhbid0IG92ZXJyaWRlIGl0IGZyb20gdjguNCAKdG8KdjguMS4g SSBjYW4gb25seSBnbyB0byB2OC4wLgoKSXMgaXQgc29tZXRoaW5nIHdlIGNhcmUgYWJvdXQ/CgpU aGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMg ZnVubnkuLi4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K a3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8v bGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A8CC433E6 for ; Tue, 12 Jan 2021 11:51:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 769B823107 for ; Tue, 12 Jan 2021 11:51:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 769B823107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4aov1dEAsp3Fp2NX5hwkhAkZpWodJilxBwdzQmEOkmw=; b=Fbmlrxcx3Ky9HC0XrBkwBrd+4 T84V3T04FvJnzP1GSsvmiM1ZecmeLWR9Rw3w0mvhTkalm0KP4wfahIMlpn846/Coig6v5qt16uz2U V36q+dmAHgfJiy1YJah8eLTUgGj8hTK349UzGLMIUwPtXENPX360icy+oii7OM/TQUkPZpxQC9fP6 c5E/Nda6MwmDrl9kgbvwYJnxyW1QznUk/Tk9fWx/IimfSkr0BaCKSH9/LHLRGYnbDUHMPGt0eBxIe kgPLXHal0lAN2ZsTON+RsIFrkBhuADKAndZapbEXwSoGQGUPJYPNE9M3HRgec4QcdPvQe+57wckPJ AjIqZU20w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzIBp-0005ap-Jy; Tue, 12 Jan 2021 11:50:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzIBm-0005Ze-2Q for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 11:50:18 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05C6F23104; Tue, 12 Jan 2021 11:50:17 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kzIBi-006wqv-RB; Tue, 12 Jan 2021 11:50:14 +0000 MIME-Version: 1.0 Date: Tue, 12 Jan 2021 11:50:14 +0000 From: Marc Zyngier To: Suzuki K Poulose Subject: Re: [PATCH v3 09/21] arm64: cpufeature: Add global feature override facility In-Reply-To: References: <20210111132811.2455113-1-maz@kernel.org> <20210111132811.2455113-10-maz@kernel.org> <20210111184154.GC17941@gaia> <129db8bd3913a90c96d4cfe4f55e27a0@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, will@kernel.org, mark.rutland@arm.com, dbrazdil@google.com, alexandru.elisei@arm.com, ardb@kernel.org, jingzhangos@google.com, pajay@qti.qualcomm.com, psodagud@codeaurora.org, sramana@codeaurora.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_065018_283008_24D6F837 X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jing Zhang , Prasad Sodagudi , Srinivas Ramana , kernel-team@android.com, Catalin Marinas , Alexandru Elisei , linux-kernel@vger.kernel.org, Ard Biesheuvel , James Morse , Julien Thierry , Ajay Patil , David Brazdil , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3V6dWtpLAoKT24gMjAyMS0wMS0xMiAwOToxNywgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToK PiBIaSBNYXJjLAo+IAo+IE9uIDEvMTEvMjEgNzo0OCBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgoK Wy4uLl0KCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9jcHVmZWF0dXJlLmMgCj4+ IGIvYXJjaC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+IGluZGV4IDg5NGFmNjBiOTY2OS4u MDBkOTllNTkzYjY1IDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybTY0L2tlcm5lbC9jcHVmZWF0dXJl LmMKPj4gKysrIGIvYXJjaC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+IEBAIC03NzQsNiAr Nzc0LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IGluaXRfY3B1X2Z0cl9yZWcodTMyIHN5c19yZWcs IAo+PiB1NjQgbmV3KQo+PiAgwqDCoMKgwqAgdTY0IHN0cmljdF9tYXNrID0gfjB4MFVMTDsKPj4g IMKgwqDCoMKgIHU2NCB1c2VyX21hc2sgPSAwOwo+PiAgwqDCoMKgwqAgdTY0IHZhbGlkX21hc2sg PSAwOwo+PiArwqDCoMKgIHU2NCBvdmVycmlkZV92YWwgPSAwLCBvdmVycmlkZV9tYXNrID0gMDsK Pj4gCj4+ICDCoMKgwqDCoCBjb25zdCBzdHJ1Y3QgYXJtNjRfZnRyX2JpdHMgKmZ0cnA7Cj4+ICDC oMKgwqDCoCBzdHJ1Y3QgYXJtNjRfZnRyX3JlZyAqcmVnID0gZ2V0X2FybTY0X2Z0cl9yZWcoc3lz X3JlZyk7Cj4+IEBAIC03ODEsOSArNzgyLDM1IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBpbml0X2Nw dV9mdHJfcmVnKHUzMiBzeXNfcmVnLCAKPj4gdTY0IG5ldykKPj4gIMKgwqDCoMKgIGlmICghcmVn KQo+PiAgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm47Cj4+IAo+PiArwqDCoMKgIGlmIChyZWctPm92 ZXJyaWRlX21hc2sgJiYgcmVnLT5vdmVycmlkZV92YWwpIHsKPj4gK8KgwqDCoMKgwqDCoMKgIG92 ZXJyaWRlX21hc2sgPSAqcmVnLT5vdmVycmlkZV9tYXNrOwo+PiArwqDCoMKgwqDCoMKgwqAgb3Zl cnJpZGVfdmFsID0gKnJlZy0+b3ZlcnJpZGVfdmFsOwo+PiArwqDCoMKgIH0KPj4gKwo+PiAgwqDC oMKgwqAgZm9yIChmdHJwID0gcmVnLT5mdHJfYml0czsgZnRycC0+d2lkdGg7IGZ0cnArKykgewo+ PiAgwqDCoMKgwqDCoMKgwqDCoCB1NjQgZnRyX21hc2sgPSBhcm02NF9mdHJfbWFzayhmdHJwKTsK Pj4gIMKgwqDCoMKgwqDCoMKgwqAgczY0IGZ0cl9uZXcgPSBhcm02NF9mdHJfdmFsdWUoZnRycCwg bmV3KTsKPj4gK8KgwqDCoMKgwqDCoMKgIHM2NCBmdHJfb3ZyID0gYXJtNjRfZnRyX3ZhbHVlKGZ0 cnAsIG92ZXJyaWRlX3ZhbCk7Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIGlmICgoZnRyX21hc2sg JiBvdmVycmlkZV9tYXNrKSA9PSBmdHJfbWFzaykgewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBpZiAoZnRyX292ciA8IGZ0cl9uZXcpIHsKPiAKPiBIZXJlIHdlIGFzc3VtZSB0aGF0IGFsbCB0 aGUgZmVhdHVyZXMgYXJlIEZUUl9MT1dFUl9TQUZFLiBXZSBjb3VsZAo+IHByb2JhYmx5IHVzZSBh cm02NF9mdHJfc2FmZV92YWx1ZShmdHJwLCBmdHJfbmV3LCBmdHJfb3ZyKSBoZXJlID8KPiBUaGF0 IHdvdWxkIGNvdmVyIHVzIGZvciBib3RoIEhJR0hFUl9TQUZFIGFuZCBMT1dFUl9TQUZFIGZlYXR1 cmVzLgo+IEhvd2V2ZXIgdGhhdCBtYXkgYmUgcmVzdHJpY3RpdmUgZm9yIEZUUl9FWEFDVCwgYXMg d2UgdGhlIHNhZmUKPiB2YWx1ZSB3b3VsZCBiZSBzZXQgdG8gImZ0ci0+c2FmZV92YWwiLiBJIGd1 ZXNzIHRoYXQgbWF5IGJlIGJldHRlcgo+IHRoYW4gZm9yY2luZyB0byB1c2UgYW4gdW5zYWZlIHZh bHVlIGZvciB0aGUgYm9vdCBDUFUsIHdoaWNoIGNvdWxkCj4gYW55d2F5IGNvbmZsaWN0IHdpdGgg dGhlIG90aGVyIENQVXMgYW5kIGV2ZW50dWFsbHkgdHJpZ2dlciB0aGUKPiBmdHIgYWx1ZSB0byBi ZSBzYWZlX3ZhbC4KCkkgbGlrZSB0aGUgaWRlYSBvZiB1c2luZyB0aGUgaGVscGVyLCBhcyBpdCBj bGVhbnVwcyB1cCB0aGUgY29kZSBhIGJpdC4KSG93ZXZlciwgbm90IGJlaW5nIHRvIHNldCBhIGZl YXR1cmUgdG8gYSBjZXJ0YWluIHZhbHVlIGNvdWxkIGJlIApyZXN0cmljdGl2ZSwKYXMgaW4gZ2Vu ZXJhbCwgaXQgbWVhbnMgdGhhdCB3ZSBjYW4gb25seSBkaXNhYmxlIGEgZmVhdHVyZSBhbmQgbm90 IAphZGp1c3QKaXRzIGxldmVsIG9mIHN1cHBvcnQuCgpUYWtlIFBNVVZFUiBmb3IgZXhhbXBsZTog d2l0aCB0aGUgaGVscGVyLCBJIGNhbid0IG92ZXJyaWRlIGl0IGZyb20gdjguNCAKdG8KdjguMS4g SSBjYW4gb25seSBnbyB0byB2OC4wLgoKSXMgaXQgc29tZXRoaW5nIHdlIGNhcmUgYWJvdXQ/CgpU aGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMg ZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2CCC433E0 for ; Tue, 12 Jan 2021 11:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBD8223104 for ; Tue, 12 Jan 2021 11:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731262AbhALLu6 (ORCPT ); Tue, 12 Jan 2021 06:50:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:38008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730146AbhALLu6 (ORCPT ); Tue, 12 Jan 2021 06:50:58 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05C6F23104; Tue, 12 Jan 2021 11:50:17 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kzIBi-006wqv-RB; Tue, 12 Jan 2021 11:50:14 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 12 Jan 2021 11:50:14 +0000 From: Marc Zyngier To: Suzuki K Poulose Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Will Deacon , Mark Rutland , David Brazdil , Alexandru Elisei , Ard Biesheuvel , Jing Zhang , Ajay Patil , Prasad Sodagudi , Srinivas Ramana , James Morse , Julien Thierry , kernel-team@android.com Subject: Re: [PATCH v3 09/21] arm64: cpufeature: Add global feature override facility In-Reply-To: References: <20210111132811.2455113-1-maz@kernel.org> <20210111132811.2455113-10-maz@kernel.org> <20210111184154.GC17941@gaia> <129db8bd3913a90c96d4cfe4f55e27a0@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, will@kernel.org, mark.rutland@arm.com, dbrazdil@google.com, alexandru.elisei@arm.com, ardb@kernel.org, jingzhangos@google.com, pajay@qti.qualcomm.com, psodagud@codeaurora.org, sramana@codeaurora.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suzuki, On 2021-01-12 09:17, Suzuki K Poulose wrote: > Hi Marc, > > On 1/11/21 7:48 PM, Marc Zyngier wrote: [...] >> diff --git a/arch/arm64/kernel/cpufeature.c >> b/arch/arm64/kernel/cpufeature.c >> index 894af60b9669..00d99e593b65 100644 >> --- a/arch/arm64/kernel/cpufeature.c >> +++ b/arch/arm64/kernel/cpufeature.c >> @@ -774,6 +774,7 @@ static void __init init_cpu_ftr_reg(u32 sys_reg, >> u64 new) >>      u64 strict_mask = ~0x0ULL; >>      u64 user_mask = 0; >>      u64 valid_mask = 0; >> +    u64 override_val = 0, override_mask = 0; >> >>      const struct arm64_ftr_bits *ftrp; >>      struct arm64_ftr_reg *reg = get_arm64_ftr_reg(sys_reg); >> @@ -781,9 +782,35 @@ static void __init init_cpu_ftr_reg(u32 sys_reg, >> u64 new) >>      if (!reg) >>          return; >> >> +    if (reg->override_mask && reg->override_val) { >> +        override_mask = *reg->override_mask; >> +        override_val = *reg->override_val; >> +    } >> + >>      for (ftrp = reg->ftr_bits; ftrp->width; ftrp++) { >>          u64 ftr_mask = arm64_ftr_mask(ftrp); >>          s64 ftr_new = arm64_ftr_value(ftrp, new); >> +        s64 ftr_ovr = arm64_ftr_value(ftrp, override_val); >> + >> +        if ((ftr_mask & override_mask) == ftr_mask) { >> +            if (ftr_ovr < ftr_new) { > > Here we assume that all the features are FTR_LOWER_SAFE. We could > probably use arm64_ftr_safe_value(ftrp, ftr_new, ftr_ovr) here ? > That would cover us for both HIGHER_SAFE and LOWER_SAFE features. > However that may be restrictive for FTR_EXACT, as we the safe > value would be set to "ftr->safe_val". I guess that may be better > than forcing to use an unsafe value for the boot CPU, which could > anyway conflict with the other CPUs and eventually trigger the > ftr alue to be safe_val. I like the idea of using the helper, as it cleanups up the code a bit. However, not being to set a feature to a certain value could be restrictive, as in general, it means that we can only disable a feature and not adjust its level of support. Take PMUVER for example: with the helper, I can't override it from v8.4 to v8.1. I can only go to v8.0. Is it something we care about? Thanks, M. -- Jazz is not dead. It just smells funny...