From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15D2CC3DA6E for ; Wed, 20 Dec 2023 09:10:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.657473.1026322 (Exim 4.92) (envelope-from ) id 1rFsap-0008Vi-0y; Wed, 20 Dec 2023 09:10:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 657473.1026322; Wed, 20 Dec 2023 09:10:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFsao-0008Vb-U2; Wed, 20 Dec 2023 09:10:18 +0000 Received: by outflank-mailman (input) for mailman id 657473; Wed, 20 Dec 2023 09:10:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFsan-0008VT-Hx for xen-devel@lists.xenproject.org; Wed, 20 Dec 2023 09:10:17 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96e29373-9f17-11ee-98eb-6d05b1d4d9a1; Wed, 20 Dec 2023 10:10:16 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id C32AB4EE0C91; Wed, 20 Dec 2023 10:10:15 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96e29373-9f17-11ee-98eb-6d05b1d4d9a1 MIME-Version: 1.0 Date: Wed, 20 Dec 2023 10:10:15 +0100 From: Nicola Vetrini To: Luca Fancellu Cc: Stefano Stabellini , consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org, Jan Beulich Subject: Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json In-Reply-To: References: <664ddc412905546d44d3e311a743ba5217a6243b.1702976486.git.nicola.vetrini@bugseng.com> <055b6cf3-4f29-4f1d-b650-26c6d9be8832@suse.com> <2fd03776043811a8ceae9ae41de5f0fa@bugseng.com> <2c64af71dcb3984f1753ef115868cb7b@bugseng.com> <2F345562-4049-4A50-9793-D0002B239C43@arm.com> <70b0b556-d103-46dd-a69c-004e9adf27bf@suse.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-12-20 09:50, Luca Fancellu wrote: >> On 20 Dec 2023, at 08:41, Jan Beulich wrote: >> >> On 20.12.2023 01:17, Stefano Stabellini wrote: >>> On Tue, 19 Dec 2023, Luca Fancellu wrote: >>>>> On 19 Dec 2023, at 11:05, Nicola Vetrini >>>>> wrote: >>>>> On 2023-12-19 11:51, Nicola Vetrini wrote: >>>>>> On 2023-12-19 11:37, Jan Beulich wrote: >>>>>>> On 19.12.2023 10:02, Nicola Vetrini wrote: >>>>>>>> --- a/docs/misra/exclude-list.json >>>>>>>> +++ b/docs/misra/exclude-list.json >>>>>>>> @@ -209,6 +209,10 @@ >>>>>>>> "rel_path": "include/acpi/acglobal.h", >>>>>>>> "comment": "Imported from Linux, ignore for now" >>>>>>>> }, >>>>>>>> + { >>>>>>>> + "rel_path": "include/acpi/acmacros.h", >>>>>>>> + "comment": "Imported from Linux, ignore for now" >>>>>>>> + }, >>>>>>> Together with what's already there (in context), wouldn't it >>>>>>> better be >>>>>>> the entire directory then which is excluded, or at least all >>>>>>> include/acpi/ac*.h collectively (and perhaps also >>>>>>> include/acpi/platform/ac*.h)? >>>>>>> Jan >>>>>> +Cc Luca Fancellu >>>>>> Sure. I wasn't certain which files are imported from ACPI CA and >>>>>> which aren't. >>>>>> I'm also not sure whether "include/acpi/ac*.h" would be properly >>>>>> recognized by other tooling that uses exclude-list.json (only >>>>>> cppcheck I think). I Cc-ed Luca Fancellu on this. >>>>> >>>>> It occurred to me that it's surely ok to use "include/acpi/ac*" and >>>>> "include/acpi/platform/ac*". >>>> >>>> Yes I think it’s fine, it just come to my mind now that this could >>>> have the risk that if >>>> another file is added with ‘ac' prefix, even if it could be subject >>>> to MISRA compliance, >>>> it will be excluded. >>>> >>>> If that risk is negligible for the maintainer of that part, then >>>> it’s fine. >>> >>> I think it is OK either way, I'll let Jan pick his preference. >> >> It hasn't become clear to me what the benefit would be of omitting the >> trailing .h. > > Yes, with the extension is better, the same as we already do here: > > [...] > { > "rel_path": "common/un*.c”, > "comment": "unlz4.c implementation by Yann Collet, the others un* > are from Linux, ignore for now" > }, > [...] Ok, I'll send a v2 -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)