Re: [PATCH v3 1/1] nvme-pci : Fix EEH failure on ppc after subsystem reset

[Nilay Shroff <nilay@linux.ibm.com>]

On 6/12/24 18:40, Maurizio Lombardi wrote:
> st 12. 6. 2024 v 13:07 odesílatel Nilay Shroff <nilay@linux.ibm.com> napsal:
>> I think for your case you shall consider using nvme_wait_reset() before
>> queuing error recovery work. For instance, it could be done something
>> like below  assuming that all callers of nvme_tcp_error_recovery() are
>> allowed to sleep (not fully tested) :
>>
>> static void nvme_tcp_error_recovery(struct nvme_ctrl *ctrl)
>> {
>>         if (!nvme_wait_reset(ctrl))
>>                 return;
> 
> Nice idea but in this case I don't think it can work
> because socket's callbacks run in interrupt context.
> 
Ok so in that case how about calling nvme_wait_reset() 
from nvme_tcp_error_recovery_work()?

Thanks,
--Nilay