From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52DDC28CBC for ; Wed, 6 May 2020 09:16:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78B5420714 for ; Wed, 6 May 2020 09:16:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J9RunZ3x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ffCmxnVj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78B5420714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=19Esgh4FWX7l0YBIelpbIODyw6L8NF48loUwzmfVOu0=; b=J9RunZ3xSN6yxsPSJgdxtjyLh flKd09qcxyoK6UCx0kx6FCa/s2D6HDJZ/HuD0TFbYkE3yUheGxqb6LF+KYbpzS+EoA/IlFOwWAaIj LZRhjjm9ybpUseEPcTf5rdvs8jgQyQCa4RjJKEza5ChtvwsnJKbMJ1yWvFao0luX/DyxXLkHqaec7 H7TD4c1UlJpTp79qW5kGF+/KpgMtAvAkmx0t+nNWng6WCOtFhqK1D4QjKh3QBAbKf+sHB0It4DHGj if8U0tZq2vEDFW9gVcxLLh/kctBkBen2DJq0OGls1uasUp6kvhvyAB3diBRIes9lrN5RL64tReK4a 1QmJJgi7A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWGAO-0004Ic-Ml; Wed, 06 May 2020 09:16:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWGAL-0004I3-Od for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2020 09:16:35 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D66720714; Wed, 6 May 2020 09:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588756592; bh=zALfP4xVA+WvMHMrj3CUbm45HqoM4nmq5AW9bGrPH2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ffCmxnVjUNbGEYXs7ebndAaB16aD56h/wOafPQ9nhbc3AQTxKanXfu8za8iS2Sj82 bmu9jj4FUSEsJyg0unDcCOcQAysGyMS0gP8Fbht+RdDADAC/HhmXIkK2bKk+Uum8ly YmjKIACtYOKj6oQTAulpDDWFMk09Q1iduE77w1Q8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jWGAI-009tyT-Rk; Wed, 06 May 2020 10:16:30 +0100 MIME-Version: 1.0 Date: Wed, 06 May 2020 10:16:30 +0100 From: Marc Zyngier To: =?UTF-8?Q?Andr=C3=A9_Przywara?= Subject: Re: [PATCH 07/16] arm64: dts: arm: Fix GIC compatible names In-Reply-To: <629da7f9-9cc9-ec9e-f175-ef6c90b5e3f1@arm.com> References: <20200505165212.76466-1-andre.przywara@arm.com> <20200505165212.76466-8-andre.przywara@arm.com> <86lfm6tf1f.wl-maz@kernel.org> <629da7f9-9cc9-ec9e-f175-ef6c90b5e3f1@arm.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: andre.przywara@arm.com, robh@kernel.org, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_021633_842867_7EA8BA2E X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Lorenzo Pieralisi , devicetree@vger.kernel.org, Liviu Dudau , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wNS0wNiAwOTo0NSwgQW5kcsOpIFByenl3YXJhIHdyb3RlOgo+IE9uIDA1LzA1LzIw MjAgMTk6MjUsIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gVHVlLCAwNSBNYXkgMjAyMCAxNzo1 MjowMyArMDEwMCwKPj4gQW5kcmUgUHJ6eXdhcmEgPGFuZHJlLnByenl3YXJhQGFybS5jb20+IHdy b3RlOgo+Pj4gCj4+PiBUaGUgR0lDIERUIGJpbmRpbmcgb25seSBhbGxvd3MgYSBjZXJ0YWluIGNv bWJpbmF0aW9uIG9mIERUIGNvbXBhdGlibGUKPj4+IHN0cmluZ3MsIG1vc3RseSBqdXN0IGNvbnNp c3Rpbmcgb2Ygb25lIG5hbWUuCj4+PiAKPj4+IERyb3AgdGhlIGNvbWJpbmF0aW9uIG9mIG11bHRp cGxlIG5hbWVzIGFuZCBnbyB3aXRoIHRoZQo+Pj4gImFybSxjb3J0ZXgtYTE1LWdpYyIgbmFtZSBm b3IgR0lDdjIsIGFzIHRoaXMgc2VlbXMgdG8gYmUgdGhlIG1vc3QgCj4+PiB3aWRlbHkKPj4+IGFj Y2VwdGVkIHN0cmluZy4gImFybSxnaWMtNDAwIiB3b3VsZCBiZSBtb3JlIGNvcnJlY3QsIGJ1dCB3 YXMgCj4+PiBpbnRyb2R1Y2VkCj4+PiBtdWNoIGxhdGVyIGludG8gdGhlIGtlcm5lbCdzIEdJQyBk cml2ZXIuCj4+PiAKPj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5 d2FyYUBhcm0uY29tPgo+Pj4gLS0tCj4+PiAgYXJjaC9hcm02NC9ib290L2R0cy9hcm0vZm91bmRh dGlvbi12OC1naWN2Mi5kdHNpIHwgMiArLQo+Pj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvYXJtL2p1 bm8tYmFzZS5kdHNpICAgICAgICAgICB8IDIgKy0KPj4+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL2Fy bS9ydHNtX3ZlLWFlbXY4YS5kdHMgICAgICAgfCAyICstCj4+PiAgMyBmaWxlcyBjaGFuZ2VkLCAz IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4+PiAKPj4+IGRpZmYgLS1naXQgYS9hcmNo L2FybTY0L2Jvb3QvZHRzL2FybS9mb3VuZGF0aW9uLXY4LWdpY3YyLmR0c2kgCj4+PiBiL2FyY2gv YXJtNjQvYm9vdC9kdHMvYXJtL2ZvdW5kYXRpb24tdjgtZ2ljdjIuZHRzaQo+Pj4gaW5kZXggMTVm ZTgxNzM4ZTk0Li42MWExNzUwZmNkZDYgMTAwNjQ0Cj4+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3Qv ZHRzL2FybS9mb3VuZGF0aW9uLXY4LWdpY3YyLmR0c2kKPj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9v dC9kdHMvYXJtL2ZvdW5kYXRpb24tdjgtZ2ljdjIuZHRzaQo+Pj4gQEAgLTYsNyArNiw3IEBACj4+ PiAKPj4+ICAvIHsKPj4+ICAJZ2ljOiBpbnRlcnJ1cHQtY29udHJvbGxlckAyYzAwMTAwMCB7Cj4+ PiAtCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgtYTE1LWdpYyIsICJhcm0sY29ydGV4LWE5LWdp YyI7Cj4+PiArCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgtYTE1LWdpYyI7Cj4+PiAgCQkjaW50 ZXJydXB0LWNlbGxzID0gPDM+Owo+Pj4gIAkJI2FkZHJlc3MtY2VsbHMgPSA8Mj47Cj4+PiAgCQlp bnRlcnJ1cHQtY29udHJvbGxlcjsKPj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRz L2FybS9qdW5vLWJhc2UuZHRzaSAKPj4+IGIvYXJjaC9hcm02NC9ib290L2R0cy9hcm0vanVuby1i YXNlLmR0c2kKPj4+IGluZGV4IDNmZWVmZDYxZWI3Ni4uNjIzOTJhYjFmODgwIDEwMDY0NAo+Pj4g LS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9hcm0vanVuby1iYXNlLmR0c2kKPj4+ICsrKyBiL2Fy Y2gvYXJtNjQvYm9vdC9kdHMvYXJtL2p1bm8tYmFzZS5kdHNpCj4+PiBAQCAtNjksNyArNjksNyBA QAo+Pj4gIAl9Owo+Pj4gCj4+PiAgCWdpYzogaW50ZXJydXB0LWNvbnRyb2xsZXJAMmMwMTAwMDAg ewo+Pj4gLQkJY29tcGF0aWJsZSA9ICJhcm0sZ2ljLTQwMCIsICJhcm0sY29ydGV4LWExNS1naWMi Owo+Pj4gKwkJY29tcGF0aWJsZSA9ICJhcm0sY29ydGV4LWExNS1naWMiOwo+PiAKPj4gV2h5PyBH SUMtNDAwIGlzIGRlZmluaXRlbHkgdGhlIG1vc3QgY29ycmVjdCBjb21wYXRpYmxlIHN0cmluZy4g SSdkCj4+IHJhdGhlciBzZWUgdGhpcyBjb21wYXRpYmxlIGJlaW5nIGdlbmVyYWxpc2VkIHRvIHRo ZSBtb2RlbHMgcmF0aGVyIHRoYW4KPj4gb25seSByZWZlcmVuY2luZyB0aGUgQTE1IEdJQy4KPiAK PiBJIGFncmVlIHRoYXQgZ2ljLTQwMCBpcyB0aGUgZmFyIGJldHRlciBuYW1lLCBidXQgaXQgd2Fz IG9ubHkgaW50cm9kdWNlZAo+IGluIHYzLjE2LiBTbyBvbWl0dGluZyBhcm0sY29ydGV4LWExNS1n aWMgd291bGQgYnJlYWsgYW55IGtlcm5lbHMgYmVmb3JlCj4gdGhhdCwgd2hpY2ggSSB3b3VsZCBs aWtlIHRvIGF2b2lkLgoKSSBhbSBub3QgdGFsa2luZyBhYm91dCBkcm9wcGluZyB0aGUgQTE1IEdJ Qy4gSSdtIHNheWluZyB0aGF0IGJvdGggc2hvdWxkCnN0YXkuIElzIHRoZXJlIGFueXRoaW5nIGlu IHRoZSBEVCBiaW5kaW5nIHRoYXQgZm9yYmlkcyBtdWx0aXBsZSBuYW1lcyBpbgp0aGUgY29tcGF0 aWJsZSBwcm9wZXJ0eT8KCj4gSXQncyBhY3R1YWxseSBhIHBpdHkgdGhhdCB3ZSBhcmUgc28gcGlj a3kgYWJvdXQgdGhlIGNvbXBhdGlibGUgCj4gbGlzdGluZ3MsCj4gYmVjYXVzZSB0aGUgZXhpc3Rp bmcgY29tYmluYXRpb24gaXMgYWN0dWFsbHkgcXVpdGUgbmljZTogd2UgZ2V0Cj4gY29tcGF0aWJp bGl0eSB3aXRoIG9sZGVyIERUIGNvbnN1bWVycywgYnV0IHN0aWxsIGNhbiBzYXkgd2hhdCBpdAo+ IGFjdHVhbGx5IGlzLgo+IEkgd29uZGVyIGlmIEkgc2hvdWxkIGludHJvZHVjZSB0aGlzIGNvbWJp bmF0aW9uIHRvIHRoZSBHSUMgRFQgYmluZGluZwo+IGluc3RlYWQsIGl0IHNlZW1zIGxpa2UgdGhl cmUgYXJlIG90aGVyIHVzZXJzIGluIHRoZSB0cmVlIGFzIHdlbGwuCj4gCj4gV2hhdCBkbyB5b3Ug dGhpbms/CgpJJ2Qgc2F5IHRoYXQgaWYgdGhlIGJpbmRpbmcgZm9yYmlkcyBtdWx0aXBsZSBjb21w YXRpYmxlIHN0cmluZ3MsIHRoZQpiaW5kaW5nIGlzIGxpa2VseSB0byBiZSB3cm9uZy4gV2Ugc2hv dWxkIGZpeCBpdCwgYW5kIG5vdCBtYWtlIHRoZSBEVHMKd29yc2UgYXMgYSByZXN1bHQgb2YgYSBi aW5kaW5nIGlzc3VlLgoKVGhhbmtzLAoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRlYWQu IEl0IGp1c3Qgc21lbGxzIGZ1bm55Li4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE69C28CBC for ; Wed, 6 May 2020 09:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFC422075A for ; Wed, 6 May 2020 09:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588756594; bh=zALfP4xVA+WvMHMrj3CUbm45HqoM4nmq5AW9bGrPH2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=FejN1f3AwhVNqYXSJXXR4eUwRh4HNWzVrswMrehiTlRODs8EoteoSAMTjfaPrp9Gm 6E1TI22QR4qSayN+VxR4vUD451H83tm/HRmelodGDJ7uEIKh9kokWeeCa4LCivDexp ly6ul4jHlMZWGQP0nPHTF5YfxQoeQcea5+J9tYWY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728940AbgEFJQd (ORCPT ); Wed, 6 May 2020 05:16:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:40256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728385AbgEFJQd (ORCPT ); Wed, 6 May 2020 05:16:33 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D66720714; Wed, 6 May 2020 09:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588756592; bh=zALfP4xVA+WvMHMrj3CUbm45HqoM4nmq5AW9bGrPH2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ffCmxnVjUNbGEYXs7ebndAaB16aD56h/wOafPQ9nhbc3AQTxKanXfu8za8iS2Sj82 bmu9jj4FUSEsJyg0unDcCOcQAysGyMS0gP8Fbht+RdDADAC/HhmXIkK2bKk+Uum8ly YmjKIACtYOKj6oQTAulpDDWFMk09Q1iduE77w1Q8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jWGAI-009tyT-Rk; Wed, 06 May 2020 10:16:30 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 06 May 2020 10:16:30 +0100 From: Marc Zyngier To: =?UTF-8?Q?Andr=C3=A9_Przywara?= Cc: Rob Herring , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland Subject: Re: [PATCH 07/16] arm64: dts: arm: Fix GIC compatible names In-Reply-To: <629da7f9-9cc9-ec9e-f175-ef6c90b5e3f1@arm.com> References: <20200505165212.76466-1-andre.przywara@arm.com> <20200505165212.76466-8-andre.przywara@arm.com> <86lfm6tf1f.wl-maz@kernel.org> <629da7f9-9cc9-ec9e-f175-ef6c90b5e3f1@arm.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: andre.przywara@arm.com, robh@kernel.org, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-05-06 09:45, André Przywara wrote: > On 05/05/2020 19:25, Marc Zyngier wrote: >> On Tue, 05 May 2020 17:52:03 +0100, >> Andre Przywara wrote: >>> >>> The GIC DT binding only allows a certain combination of DT compatible >>> strings, mostly just consisting of one name. >>> >>> Drop the combination of multiple names and go with the >>> "arm,cortex-a15-gic" name for GICv2, as this seems to be the most >>> widely >>> accepted string. "arm,gic-400" would be more correct, but was >>> introduced >>> much later into the kernel's GIC driver. >>> >>> Signed-off-by: Andre Przywara >>> --- >>> arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi | 2 +- >>> arch/arm64/boot/dts/arm/juno-base.dtsi | 2 +- >>> arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- >>> 3 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi >>> b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi >>> index 15fe81738e94..61a1750fcdd6 100644 >>> --- a/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi >>> +++ b/arch/arm64/boot/dts/arm/foundation-v8-gicv2.dtsi >>> @@ -6,7 +6,7 @@ >>> >>> / { >>> gic: interrupt-controller@2c001000 { >>> - compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; >>> + compatible = "arm,cortex-a15-gic"; >>> #interrupt-cells = <3>; >>> #address-cells = <2>; >>> interrupt-controller; >>> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi >>> b/arch/arm64/boot/dts/arm/juno-base.dtsi >>> index 3feefd61eb76..62392ab1f880 100644 >>> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi >>> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi >>> @@ -69,7 +69,7 @@ >>> }; >>> >>> gic: interrupt-controller@2c010000 { >>> - compatible = "arm,gic-400", "arm,cortex-a15-gic"; >>> + compatible = "arm,cortex-a15-gic"; >> >> Why? GIC-400 is definitely the most correct compatible string. I'd >> rather see this compatible being generalised to the models rather than >> only referencing the A15 GIC. > > I agree that gic-400 is the far better name, but it was only introduced > in v3.16. So omitting arm,cortex-a15-gic would break any kernels before > that, which I would like to avoid. I am not talking about dropping the A15 GIC. I'm saying that both should stay. Is there anything in the DT binding that forbids multiple names in the compatible property? > It's actually a pity that we are so picky about the compatible > listings, > because the existing combination is actually quite nice: we get > compatibility with older DT consumers, but still can say what it > actually is. > I wonder if I should introduce this combination to the GIC DT binding > instead, it seems like there are other users in the tree as well. > > What do you think? I'd say that if the binding forbids multiple compatible strings, the binding is likely to be wrong. We should fix it, and not make the DTs worse as a result of a binding issue. Thanks, M. -- Jazz is not dead. It just smells funny...