From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Sridharan, Ranjani" <ranjani.sridharan@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/9] ASoC: soc-pcm cleanup step6
Date: Mon, 9 Mar 2020 12:15:52 -0500 [thread overview]
Message-ID: <d9ee960e-c47f-e186-9c67-6614aa05da61@linux.intel.com> (raw)
In-Reply-To: <CAFQqKeViGDniocxCScM9KGfawCDiOzMfjK=aAFAnnWV=C3JzXg@mail.gmail.com>
Thanks Morimoto-san,
>> We are using plural form for for_each_xxx() macro.
>> But, for_each_rtd_codec/cpu_dai() are out of this rule.
>> 1) - 7) are for it.
>> 8) - 9) add new for_each_card_xxx() macros.
>>
>> Kuninori Morimoto (9):
>> 1) ASoC: soc.h: add for_each_rtd_codecs/cpus_dai() macro
>> 2) ASoC: Intel: use for_each_rtd_codecs/cpus_dai() macro
>> 3) ASoC: mediatek: use for_each_rtd_codecs/cpus_dai() macro
>> 4) ASoC: meson: use for_each_rtd_codecs/cpus_dai() macro
>> 5) ASoC: qcom: use for_each_rtd_codecs/cpus_dai() macro
>> 6) ASoC: soc: use for_each_rtd_codecs/cpus_dai() macro
>> 7) ASoC: soc.h: remove non plural form for_each_xxx macro
>> 8) ASoC: soc-dapm: add for_each_card_dapms() macro
>> 9) ASoC: soc-dapm: add for_each_card_widgets() macro
>
> LGTM Morimoto-san. I feel like the last 2 patches might be a bit of an
> overkill but then they might make sense to keep the code consistent with
> the use of the for_each*() macros everywhere.
>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
LGTM as well.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
prev parent reply other threads:[~2020-03-09 17:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 4:06 [PATCH 0/9] ASoC: soc-pcm cleanup step6 Kuninori Morimoto
2020-03-09 4:07 ` [PATCH 1/9] ASoC: soc.h: add for_each_rtd_codecs/cpus_dai() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: soc.h: add for_each_rtd_codecs/cpus_dai() macro" to the asoc tree Mark Brown
2020-03-09 4:07 ` [PATCH 2/9] ASoC: Intel: use for_each_rtd_codecs/cpus_dai() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: Intel: use for_each_rtd_codecs/cpus_dai() macro" to the asoc tree Mark Brown
2020-03-09 4:07 ` [PATCH 3/9] ASoC: mediatek: use for_each_rtd_codecs/cpus_dai() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: mediatek: use for_each_rtd_codecs/cpus_dai() macro" to the asoc tree Mark Brown
2020-03-09 4:07 ` [PATCH 4/9] ASoC: meson: use for_each_rtd_codecs/cpus_dai() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: meson: use for_each_rtd_codecs/cpus_dai() macro" to the asoc tree Mark Brown
2020-03-09 4:07 ` [PATCH 5/9] ASoC: qcom: use for_each_rtd_codecs/cpus_dai() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: qcom: use for_each_rtd_codecs/cpus_dai() macro" to the asoc tree Mark Brown
2020-03-09 4:08 ` [PATCH 6/9] ASoC: soc: use for_each_rtd_codecs/cpus_dai() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: soc: use for_each_rtd_codecs/cpus_dai() macro" to the asoc tree Mark Brown
2020-03-09 4:08 ` [PATCH 7/9] ASoC: soc.h: remove non plural form for_each_xxx macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: soc.h: remove non plural form for_each_xxx macro" to the asoc tree Mark Brown
2020-03-09 4:08 ` [PATCH 8/9] ASoC: soc-dapm: add for_each_card_dapms() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: soc-dapm: add for_each_card_dapms() macro" to the asoc tree Mark Brown
2020-03-09 4:08 ` [PATCH 9/9] ASoC: soc-dapm: add for_each_card_widgets() macro Kuninori Morimoto
2020-03-10 13:51 ` Applied "ASoC: soc-dapm: add for_each_card_widgets() macro" to the asoc tree Mark Brown
2020-03-09 17:00 ` [PATCH 0/9] ASoC: soc-pcm cleanup step6 Sridharan, Ranjani
2020-03-09 17:15 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ee960e-c47f-e186-9c67-6614aa05da61@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=ranjani.sridharan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.