From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Greear <greearb@candelatech.com>, netdev <netdev@vger.kernel.org>
Subject: Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+
Date: Tue, 6 Jun 2017 18:34:47 -0600 [thread overview]
Message-ID: <da189b9d-760f-0591-2acf-1a6b7910e227@gmail.com> (raw)
In-Reply-To: <1496795269.736.21.camel@edumazet-glaptop3.roam.corp.google.com>
On 6/6/17 6:27 PM, Eric Dumazet wrote:
> Good catch, but it looks like similar fix is needed a few lines before.
>
> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> index deea901746c8570c5e801e40592c91e3b62812e0..b214443dc8346cef3690df7f27cc48a864028865 100644
> --- a/net/ipv6/ip6_fib.c
> +++ b/net/ipv6/ip6_fib.c
> @@ -372,12 +372,13 @@ static int fib6_dump_table(struct fib6_table *table, struct sk_buff *skb,
>
> read_lock_bh(&table->tb6_lock);
> res = fib6_walk(net, w);
> - read_unlock_bh(&table->tb6_lock);
> if (res > 0) {
> cb->args[4] = 1;
> cb->args[5] = w->root->fn_sernum;
> }
> + read_unlock_bh(&table->tb6_lock);
indeed. tunnel vision on Ben's problem
next prev parent reply other threads:[~2017-06-07 0:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 21:06 Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+ Ben Greear
2017-06-07 0:00 ` David Ahern
2017-06-07 0:27 ` Eric Dumazet
2017-06-07 0:34 ` David Ahern [this message]
2017-06-07 4:19 ` Eric Dumazet
2017-06-08 21:27 ` Ben Greear
2017-06-09 5:55 ` Cong Wang
2017-06-09 13:27 ` David Ahern
2017-06-09 21:25 ` Eric Dumazet
2017-06-13 20:16 ` Ben Greear
2017-06-13 20:28 ` David Ahern
2017-06-13 20:39 ` Ben Greear
2017-06-13 21:42 ` Cong Wang
2017-06-14 2:27 ` David Ahern
2017-06-14 22:23 ` Ben Greear
2017-06-14 22:25 ` David Ahern
2017-06-20 14:12 ` Ben Greear
2017-06-20 18:05 ` Michal Kubecek
2017-06-20 21:41 ` Ben Greear
2017-06-21 3:03 ` David Ahern
2017-06-25 21:59 ` David Ahern
2018-01-24 23:59 ` Ben Greear
2018-04-17 23:29 ` Ben Greear
2018-04-18 0:38 ` David Ahern
2017-06-07 0:48 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da189b9d-760f-0591-2acf-1a6b7910e227@gmail.com \
--to=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.