All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@manguebit.org>
To: Ralph Boehme <slow@samba.org>, smfrench@gmail.com
Cc: Jean-Baptiste Denis <jbdenis@pasteur.fr>,
	Frank Sorenson <sorenson@redhat.com>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Benjamin Coddington <bcodding@redhat.com>,
	Scott Mayhew <smayhew@redhat.com>,
	linux-cifs@vger.kernel.org
Subject: Re: [PATCH v2] smb: client: fix data loss due to broken rename(2)
Date: Tue, 02 Sep 2025 16:09:47 -0300	[thread overview]
Message-ID: <da2380aa8e3718066bfc151bf60e54ea@manguebit.org> (raw)
In-Reply-To: <cd16cf45-efc8-4324-9d40-0b92f15f179a@samba.org>

Hi Ralph,

Ralph Boehme <slow@samba.org> writes:

> Why not simply fail the rename instead of trying to implement some 
> clever but complex and error prone fallback?

We're doing this for SMB1 for a very long time and haven't heard of any
issues so far.  I've got a "safer" version [1] that does everything a
single compound request but then implemented this non-compound version
due to an existing Azure bug that seems to limit the compound in 4
commands, AFAICT.  Most applications depend on such behavior working,
which is renaming open files.

Once we rename the file and then mark it as delete pending, what other
problems do you have in mind that we might have?

  parent reply	other threads:[~2025-09-02 19:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 16:54 [PATCH v2] smb: client: fix data loss due to broken rename(2) Paulo Alcantara
2025-09-02 18:57 ` Ralph Boehme
     [not found]   ` <CAH2r5mvqJXfgQwKLSWrfBDw8Rc88ys8a_cWB5DtD19HSDmFn5w@mail.gmail.com>
2025-09-02 19:05     ` Ralph Boehme
2025-09-02 19:39       ` Paulo Alcantara
2025-09-03 15:48         ` Ralph Boehme
2025-09-03 16:19           ` Paulo Alcantara
2025-09-04  6:04             ` Ralph Boehme
2025-09-02 19:09   ` Paulo Alcantara [this message]
2025-09-03 16:10     ` Ralph Boehme
2025-09-03 18:45       ` Paulo Alcantara
2025-09-03 19:55         ` ronnie sahlberg
2025-09-03 20:10           ` ronnie sahlberg
2025-09-03 20:28             ` Paulo Alcantara
2025-09-03 20:44               ` ronnie sahlberg
2025-09-03 20:55                 ` Paulo Alcantara
2025-09-03 20:18           ` Paulo Alcantara
2025-09-03 19:13       ` Paulo Alcantara
     [not found]   ` <notmuch-sha1-4fd369d43684b0739d61e9e931e63ca8c7e2a82c>
2025-09-02 19:10     ` Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da2380aa8e3718066bfc151bf60e54ea@manguebit.org \
    --to=pc@manguebit.org \
    --cc=bcodding@redhat.com \
    --cc=jbdenis@pasteur.fr \
    --cc=linux-cifs@vger.kernel.org \
    --cc=okorniev@redhat.com \
    --cc=slow@samba.org \
    --cc=smayhew@redhat.com \
    --cc=smfrench@gmail.com \
    --cc=sorenson@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.