All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Martin Kaistra <martin.kaistra@linutronix.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
	Kalle Valo <kvalo@kernel.org>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: RE: [PATCH v2 00/21] wifi: rtl8xxxu: Add concurrent mode for 8188f
Date: Fri, 22 Dec 2023 02:02:14 +0000	[thread overview]
Message-ID: <da461682d3c348dd965a35bb3ceebb2f@realtek.com> (raw)
In-Reply-To: <CAKFoaw2b3ZB9u+jZ0gCCSrxXr1Viq3-3jsvKAgrpwDxvufYydQ@mail.gmail.com>


On Fri, Dec 22, 2023 at 12:44 AM Martin Kaistra
<martin.kaistra@linutronix.de> wrote:
>
> This series adds the possibility to use two virtual interfaces on the
> same channel. Supported combinations are STA+STA and STA+AP. The
> conversion of the driver to support multiple interfaces is split into
> individual patches to hopefully make it easier to understand what is
> going on.
>
> Thanks,
>   Martin
>
> changes for v2:
> - collect reviewed-by tags

Please collect my reviewed-by again by v3. Thanks. 

> - coding style changess
> - ignore CFO for STA+STA
> - extend watchdog_callback to call refresh_rate_mask for both interfaces

As comments, you can decide if extend it to all stations for AP mode.

> - remove port_num check for BEACON change notifications
> - add macids for STA mode
> - add number of sec cam entries to rtl8xxxu_fileops
> - add comment to switch_ports about using the function in the future

A nit comment for this patch. 



      parent reply	other threads:[~2023-12-22  2:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 16:43 [PATCH v2 00/21] wifi: rtl8xxxu: Add concurrent mode for 8188f Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 01/21] wifi: rtl8xxxu: remove assignment of priv->vif in rtl8xxxu_bss_info_changed() Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 02/21] wifi: rtl8xxxu: prepare supporting two virtual interfaces Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 03/21] wifi: rtl8xxxu: support setting linktype for both interfaces Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 04/21] wifi: rtl8xxxu: 8188e: convert usage of priv->vif to priv->vifs[0] Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 05/21] wifi: rtl8xxxu: support setting mac address register for both interfaces Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 06/21] wifi: rtl8xxxu: extend wifi connected check to " Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 07/21] wifi: rtl8xxxu: extend check for matching bssid " Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 08/21] wifi: rtl8xxxu: don't parse CFO, if both interfaces are connected in STA mode Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 09/21] wifi: rtl8xxxu: support setting bssid register for multiple interfaces Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 10/21] wifi: rtl8xxxu: support multiple interfaces in set_aifs() Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 11/21] wifi: rtl8xxxu: support multiple interfaces in update_beacon_work_callback() Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 12/21] wifi: rtl8xxxu: support multiple interfaces in configure_filter() Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 13/21] wifi: rtl8xxxu: support multiple interfaces in watchdog_callback() Martin Kaistra
     [not found]   ` <CAKFoaw3o-LkqADNvfE0TXmvr8_LK19mpVQtUZ66CWS=AN5AkJQ@mail.gmail.com>
2023-12-22  1:45     ` Ping-Ke Shih
2023-12-22  8:05       ` Martin Kaistra
2023-12-22  8:25         ` Martin Kaistra
2023-12-22  8:59           ` Ping-Ke Shih
2023-12-22  9:10             ` Martin Kaistra
2023-12-22 10:12               ` Ping-Ke Shih
2023-12-21 16:43 ` [PATCH v2 14/21] wifi: rtl8xxxu: support multiple interfaces in {add,remove}_interface() Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 15/21] wifi: rtl8xxxu: support multiple interfaces in bss_info_changed() Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 16/21] wifi: rtl8xxxu: support multiple interface in start_ap() Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 17/21] wifi: rtl8xxxu: add macids for STA mode Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 18/21] wifi: rtl8xxxu: remove obsolete priv->vif Martin Kaistra
2023-12-21 16:43 ` [PATCH v2 19/21] wifi: rtl8xxxu: add hw crypto support for AP mode Martin Kaistra
2024-01-12  6:52   ` Ping-Ke Shih
2024-01-15 13:12     ` Martin Kaistra
2024-01-16  1:25       ` Ping-Ke Shih
2023-12-21 16:43 ` [PATCH v2 20/21] wifi: rtl8xxxu: make supporting AP mode only on port 0 transparent Martin Kaistra
2023-12-22  1:54   ` Ping-Ke Shih
2023-12-22  7:49     ` Martin Kaistra
2023-12-22  7:54       ` Ping-Ke Shih
2023-12-21 16:43 ` [PATCH v2 21/21] wifi: rtl8xxxu: declare concurrent mode support for 8188f Martin Kaistra
     [not found] ` <CAKFoaw2b3ZB9u+jZ0gCCSrxXr1Viq3-3jsvKAgrpwDxvufYydQ@mail.gmail.com>
2023-12-22  2:02   ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da461682d3c348dd965a35bb3ceebb2f@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Jes.Sorensen@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.kaistra@linutronix.de \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.