All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	Miguel Ojeda <ojeda@kernel.org>
Cc: "Benno Lossin" <lossin@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"David Gow" <davidgow@google.com>,
	rust-for-linux@vger.kernel.org,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Rae Moar" <raemoar63@gmail.com>,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH] rust: allow `clippy::disallowed_names` for doctests
Date: Mon, 17 Nov 2025 13:13:12 -0800	[thread overview]
Message-ID: <da4877d2-65fd-4ad2-ac31-68d55bda7c07@nvidia.com> (raw)
In-Reply-To: <CANiq72=-w2p8sQgUKYgPG3Tx9GSUNgcVUp24k0ck2RqYgupCVg@mail.gmail.com>

On 11/17/25 1:02 PM, Miguel Ojeda wrote:
> On Mon, Nov 17, 2025 at 9:07 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>>
>> Examples (i.e. doctests) may want to use names such as `foo`, thus the
>> `clippy::disallowed_names` lint gets in the way.
>>
>> Thus allow it for all doctests.
>>
>> In addition, remove it from the existing `expect`s we have in a few
>> doctests.
>>
>> This does not mean that we should stop trying to find good names for
>> our examples, though.
>>
>> Suggested-by: Alice Ryhl <aliceryhl@google.com>
>> Link: https://lore.kernel.org/rust-for-linux/aRHSLChi5HYXW4-9@google.com/
>> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> 
> Applied to `rust-next` -- thanks everyone!
> 

Is rust-next a rebasing branch? I was going to request a non-empty commit
body, in order to make it more immediately clear what this does. Something
like:

The current set of disallowed names is inherited from clippy's defaults [1],
which are "foo", "baz", and "quux". This may be extended via .clipy.toml,
which so far has no entries for disallowed names.

thanks,
-- 
John Hubbard


  reply	other threads:[~2025-11-17 21:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  8:07 [PATCH] rust: allow `clippy::disallowed_names` for doctests Miguel Ojeda
2025-11-17  9:49 ` Alice Ryhl
2025-11-17 15:52 ` Benno Lossin
2025-11-17 21:02 ` Miguel Ojeda
2025-11-17 21:13   ` John Hubbard [this message]
2025-11-17 21:15     ` John Hubbard
2025-11-17 21:24     ` Miguel Ojeda
2025-11-17 21:35       ` John Hubbard
2025-11-17 21:26     ` Miguel Ojeda
2025-11-17 21:37       ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da4877d2-65fd-4ad2-ac31-68d55bda7c07@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=brendan.higgins@linux.dev \
    --cc=dakr@kernel.org \
    --cc=davidgow@google.com \
    --cc=gary@garyguo.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=raemoar63@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.