From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "kas@kernel.org" <kas@kernel.org>,
"yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Cc: "Gao, Chao" <chao.gao@intel.com>,
"Xu, Yilun" <yilun.xu@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Maloor, Kishen" <kishen.maloor@intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"Fang, Peter" <peter.fang@intel.com>,
"artem.bityutskiy@linux.intel.com"
<artem.bityutskiy@linux.intel.com>
Subject: Re: [PATCH 3/6] x86/virt/tdx: Detect if the extensions initialization is required
Date: Fri, 21 Aug 2026 22:22:01 +0000 [thread overview]
Message-ID: <da4cc53825da8edf29bdaaab8352e1fbb60eea15.camel@intel.com> (raw)
In-Reply-To: <aohsoZbDBZ8ZIYez@thinkstation>
On Fri, 2026-08-21 at 16:22 +0100, Kiryl Shutsemau wrote:
> On Fri, Aug 21, 2026 at 11:29:17AM +0800, Xu Yilun wrote:
> > static __init int init_tdx_module(void)
> > {
> > int ret;
> > @@ -1229,6 +1253,10 @@ static __init int init_tdx_module(void)
> > if (ret)
> > goto err_reset_pamts;
> >
> > + ret = init_tdx_module_extensions();
> > + if (ret)
> > + goto err_reset_pamts;
> > +
>
> Hm. Don't we need TDH.SYS.SHUTDOWN/DISABLE on error?
>
> Once TDMRs are initialized the module is functional. Yanking PAMT from
> under it is not safe AFAICS.
If we reset all the memory, how is it different than bailing halfway when
initializing the TDMRs? Some special state changes after the last TDMR is
inited?
next prev parent reply other threads:[~2026-08-21 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 3:29 [PATCH 0/6] Enable TDX module extensions Xu Yilun
2026-08-21 3:29 ` [PATCH 1/6] x86/virt/tdx: Wrap TDH.SYS.CONFIG/UPDATE operations in helpers Xu Yilun
2026-08-21 20:53 ` Edgecombe, Rick P
2026-08-21 3:29 ` [PATCH 2/6] x86/virt/tdx: Configure add-on features on TDX module init and update Xu Yilun
2026-08-21 14:38 ` Dave Hansen
2026-08-21 21:18 ` Edgecombe, Rick P
2026-08-21 22:01 ` Edgecombe, Rick P
2026-08-21 3:29 ` [PATCH 3/6] x86/virt/tdx: Detect if the extensions initialization is required Xu Yilun
2026-08-21 15:22 ` Kiryl Shutsemau
2026-08-21 22:22 ` Edgecombe, Rick P [this message]
2026-08-21 3:29 ` [PATCH 4/6] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-08-21 15:44 ` Kiryl Shutsemau
2026-08-21 3:29 ` [PATCH 5/6] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-08-21 23:55 ` Edgecombe, Rick P
2026-08-21 3:29 ` [PATCH 6/6] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun
2026-08-22 0:01 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da4cc53825da8edf29bdaaab8352e1fbb60eea15.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=adrian.hunter@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.fang@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tony.lindgren@linux.intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.