From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0A8CC79F9E for ; Mon, 7 Sep 2026 06:36:41 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1410581.1641388 (Exim 4.92) (envelope-from ) id 1x3Sy2-00059R-9Q; Mon, 07 Sep 2026 06:36:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1410581.1641388; Mon, 07 Sep 2026 06:36:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x3Sy2-00059K-6c; Mon, 07 Sep 2026 06:36:34 +0000 Received: by outflank-mailman (input) for mailman id 1410581; Mon, 07 Sep 2026 06:36:32 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1x3Sy0-00059A-Hw for xen-devel@lists.xenproject.org; Mon, 07 Sep 2026 06:36:32 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1x3Sxz-00EMRo-Uf for xen-devel@lists.xenproject.org; Mon, 07 Sep 2026 08:36:31 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a9e5b6b-8faa-0a2a0a5109dd-0a2a4506e846-20 for ; Mon, 07 Sep 2026 08:36:31 +0200 Received: from [209.85.221.51] (helo=mail-wr1-f51.google.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a9e5b6f-195a-0a2a45060019-d155dd33b004-3 for ; Mon, 07 Sep 2026 08:36:31 +0200 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4858269e3d9so176705f8f.2 for ; Sun, 06 Sep 2026 23:36:31 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-485885bfdf6sm27364909f8f.34.2026.09.06.23.36.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Sep 2026 23:36:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788762991; x=1789367791; darn=lists.xenproject.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=e7Q7QcH+rs+UC/qC/pvy536BuZ0LaD2I57YR+dceG1E=; b=YzlK2oePPlCwm1nihxNKzk63DedXKfEB4iMEI5Wo7iOhylY/RdhNfzHIeumnkYQ91x +o4n+tgeIsLEfp8NS5vistLmL2HRcuovek1Oup7wIPcBk4SSiWMEjsfUj56+VmNSelWJ ewgiVhTyaq0Wxz3dx4y1q+nTFwTNzenypIRWQsymEHNA0ht7FxCB5W72TvM52d67vonb 7tk/9dxzs4AGvXxj5V6lKZj854sKxQ0VUxhejVBIumJX3XvLYYyZ42aYqvV/NYKiUPyY rA1k5YgaX1w9yAVeaMPrHiJBE+0XpmFu9xd2VmUM+3ftoHlGxr7ZVdJSshsCbOGcsA8D FMKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788762991; x=1789367791; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=e7Q7QcH+rs+UC/qC/pvy536BuZ0LaD2I57YR+dceG1E=; b=pNTkavzR7K02SzYkGzQ4iMogQLhMi320tcy/QdKtz/zPR8A1rlvKK75v7SKGlXR9aJ /xuqPlwot19bY5nxcsvomKd2lQtceuuOC16EbOEAMsk2JtqrTYZaKbI+n1Fz1E8BHcFP mhpK9Rof67SAbzEkIo3jSuU18UiajRz2uYWMKVJBtyL5FldzEgwj2VQu/6sx+fu6UW6I JznGx2pF7/Fy+Wis09c5OaGULCEzU1Iuh0QtWaCSDV434UV5EGIoviRz76538W6qcS4k omHuaNB+/PRZGvYTpPFBamgHucNdDUWMAmnANgbHVLzQRy86i0zfhmuoSHqbzmsE/5Bd gYrg== X-Forwarded-Encrypted: i=1; AKwUvBx0sFKWlON4gcicxKvoUhS1OtIoIZQcRwcQj0uvCNNuoDHh8d/uT9gOmv+G5Z4Fw3eZpzWYutG/oQQ=@lists.xenproject.org X-Gm-Message-State: AFuF++lxsROKwJJs7Taggy6C7t38IMM3Ewxy3rLI9H8J85Ew9/vnsnAI EZEfvzZ5LzKooDDH/WAjWGpMNOpmGCc9WPRvZs5xBlFwQ8xL72/DiS0sEHh1ZF76Zg== X-Gm-Gg: AYBFou2+i37eTHBa4IQSxU2WS0IzM3OQkGd1m3/LJvce/oiFVNklTLX/DkYsQgHcYIB 8EkBHUExTioD+R8aVyayEfSNIu1lTJcxf4WbMk1QmBaLa7l+auT+FOkJoxGr2dcwcoEgk5GP6x5 3TbwXlhJT3E7fgSlxOQkGl/1JLGm/UEQvJyvg+zVU95PAAuVkpTtmTiZgbAXOv523GP/kN/+RJW 6b2mw7Qu7rx8lH5kj9gtbiNwi2oGRV/geXwP3LFLzurdyMDoLFaz5nAwmtCoGYPAgE/0fzPcvZ5 guMDYaIYRIVIfqnp3TVQJWH11IVd9JuGzBNrdWhzTo3+uNwmytGWu6+AnVsEP9YLCa23MhhzqIO IR33txuevWVCiPUMGxsvhYwhStMPGMcVFu5yRvK5daHUKMaDwAaGRL1jMeKn/CAw6tKKwysIhvl t58ll1rRcivvJA+9JiGSvlu9wLqZy04aIVte3l8didt4xSLd4eI0RVhRskxXk6zpUqYCCHIK0Iw bMeeGenDEVSxfxQNb0YLhVDN5nt8zwV+J/ZQyW+IWHKaAuoFAnT X-Received: by 2002:a05:6000:612:b0:485:8e19:1979 with SMTP id ffacd0b85a97d-4858e191d46mr32572561f8f.11.1788762991188; Sun, 06 Sep 2026 23:36:31 -0700 (PDT) Message-ID: Date: Mon, 7 Sep 2026 08:36:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] x86/nSVM: Check injected event consistency To: Abdelkareem Abdelsaamad Cc: andrew.cooper3@citrix.com, roger@xenproject.org, jason.andryuk@amd.com, teddy.astie@vates.tech, xen-devel@lists.xenproject.org References: <20260906131117.3121334-1-abdelkareem.abdelsaamad@citrix.com> <20260906132248.3121411-1-abdelkareem.abdelsaamad@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260906132248.3121411-1-abdelkareem.abdelsaamad@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-16d1c6/1788762991-F72C677B-E0406677/0/0 X-purgate-type: clean X-purgate-size: 1750 On 06.09.2026 15:22, Abdelkareem Abdelsaamad wrote: >>>> @@ -320,6 +320,44 @@ void svm_vmcb_dump(const char *from, const struct vmcb_struct *vmcb) >>>> svm_dump_sel(" TR", &vmcb->tr); >>>> } >>>> >>>> +static bool is_valid_injected_exception_vector(const struct vmcb_struct *vmcb, >>>> + uint8_t vmcb_injected_vector) >>>> +{ >>>> + switch ( vmcb_injected_vector ) >>>> + { >>>> + case X86_EXC_DE: >>>> + case X86_EXC_DB: >>>> + case X86_EXC_BP: >>>> + case X86_EXC_UD: >>>> + case X86_EXC_NM: >>>> + case X86_EXC_DF: >>>> + case X86_EXC_TS: >>>> + case X86_EXC_NP: >>>> + case X86_EXC_SS: >>>> + case X86_EXC_GP: >>>> + case X86_EXC_PF: >>>> + case X86_EXC_MF: >>>> + case X86_EXC_AC: >>>> + case X86_EXC_MC: >>> >>> Is #MC valid to inject without CR4.MCE set? >> The testing I performed (see previous comment) does not show that set CR4.MCE >> is required for the valid injection. >>>> + case X86_EXC_XM: >>> >>> As before: Doesn't #XM (AMD: #XF) require CR4.OSXMMEXCPT to be set? >> The testing I performed (see previous comment) does not show that set CR4.MCE >> is required for the valid injection. > I meant ..does not show that set CR4.OSXMMEXCPT is required. >>> >>> Again as before: Is #SX really permitted without any constraints? You did >>> reply to both comments on v3, but that outcome isn't reflected here. The >>> more that what you said there could equally apply ... >> The testing I performed (see the first comment) does not show that set CR4.MCE >> is required for the valid injection. > I meant ..does not show that any CR4 bit is required. And I didn't mention CR4. I intentionally said "without any constraints". Jan