All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Marie" <cedric.marie@openmailbox.org>
To: buildroot@busybox.net
Subject: [Buildroot] ninja/python-meson packages
Date: Thu, 10 Nov 2016 11:05:30 +0100	[thread overview]
Message-ID: <da5fab995f80d9aefa53ab856d999f4c@openmailbox.org> (raw)
In-Reply-To: <20161110091808.06ceb521@free-electrons.com>

Hi,

Le 2016-11-10 09:18, Thomas Petazzoni a ?crit?:
> On Thu, 10 Nov 2016 06:42:45 +0200, Baruch Siach wrote:
>> Does that mean that we won't be able to use the host distro installed 
>> cmake?
>> Not so good in terms of build time. I guess it offsets most of the 
>> build time
>> gain in moving to ninja, if not more.
> 
> This is one of the reasons why I want to have this as an option, at
> least initially. We clearly want to keep the nice benefit of using the
> system-provided CMake.

I was not aware of the new possibility to use cmake from the host 
(support/dependencies/check-host-cmake.mk). But it is not a problem.

There is a misunderstanding, I need to clarify:
I'm not changing anything in cmake package, I'm only modifying 
pkg-cmake.mk.
CMake (either from your host, or host-cmake from buildroot) has support 
for both make and ninja backend, it is not an option at compilation 
time.
It is a "configure option" to set in pkg-cmake.mk ($(2)_CONF_OPTS += -G 
Ninja), in the configure step of each package based on cmake infra.

Yet you're right as far as "make" is concerned.
Buildroot and CMake use "make" from your host distro. If we switch to 
ninja, it implies that an extra package needs to be built: host-ninja.
So the benefit of ninja is only:
- if you have several packages using CMake (I can't say how many are 
necessary to cancel out host-ninja build time...)
- if you rebuild CMake packages regularly - in development mode, which 
is not what buildroot is designed for, in the first place.
- if another package uses meson: host-ninja is required anyway... (but 
this is the future ;))

-- 
C?dric

  reply	other threads:[~2016-11-10 10:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 15:26 [Buildroot] ninja/python-meson packages Cédric Marie
2016-11-09 20:28 ` Thomas Petazzoni
2016-11-09 22:01   ` Cédric Marie
2016-11-09 22:13     ` Thomas Petazzoni
2016-11-10 10:28       ` Thijs Vermeir
2016-11-10 20:49         ` Cédric Marie
2016-11-13 21:24         ` Arnout Vandecappelle
2016-11-10  4:42     ` Baruch Siach
2016-11-10  8:18       ` Thomas Petazzoni
2016-11-10 10:05         ` Cédric Marie [this message]
2017-03-22 12:53 ` Fatih Aşıcı
2017-07-03 15:17   ` Vicente Olivert Riera
2017-07-03 22:08     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da5fab995f80d9aefa53ab856d999f4c@openmailbox.org \
    --to=cedric.marie@openmailbox.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.