From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Max Staudt <max@enpas.org>
Cc: axboe@kernel.dk, linux-ide@vger.kernel.org,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
glaubitz@physik.fu-berlin.de, schmitzmic@gmail.com,
geert@linux-m68k.org
Subject: Re: [PATCH v4] ata/pata_buddha: Probe via modalias instead of initcall
Date: Mon, 12 Aug 2019 14:15:05 +0200 [thread overview]
Message-ID: <da84c857-2c2d-29ec-5e72-e719277faa2d@samsung.com> (raw)
In-Reply-To: <27f3bb2f-e4b8-cfc9-26da-d0984f1bf37b@enpas.org>
On 8/12/19 12:55 PM, Max Staudt wrote:
> Hi Bartlomiej,
>
> Thanks for your feedback!
Hi Max,
> On 08/12/2019 12:42 PM, Bartlomiej Zolnierkiewicz wrote:
>>
>> ide/buddha driver cannot be unloaded currently (it lacks module_exit()).
>>
>> [... snip ...]
>>
>> It should work exactly like the old code in case of X-Surf,
>> what do we need to release?
>
>
> So what shall I do? Once an X-Surf has been detected, we refuse to
> unload, and therefore we never have to release X-Surf resources?
> That would simplify things a lot.
Yes, it seems to be a simplest solution.
> What's a good way to do that, given that we now have module_exit()> defined and an exit function is void?
What about something like this:
static bool xsurf_present;
...
static int __init pata_buddha_late_init(void)
...
if (pata_buddha_probe(z, &xsurf_ent) == 0 &&
xsurf_present == false)
xsurf_present = true;
...
static void __exit pata_buddha_exit(void)
...
if (xsurf_present)
return -EBUSY;
...
?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2019-08-12 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-11 15:36 [PATCH v4] ata/pata_buddha: Probe via modalias instead of initcall Max Staudt
2019-08-11 15:40 ` Max Staudt
2019-08-11 19:28 ` Max Staudt
2019-08-12 10:42 ` Bartlomiej Zolnierkiewicz
2019-08-12 10:55 ` Max Staudt
2019-08-12 12:15 ` Bartlomiej Zolnierkiewicz [this message]
2019-08-12 14:26 ` Max Staudt
2019-08-12 15:01 ` Bartlomiej Zolnierkiewicz
2019-08-12 15:39 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da84c857-2c2d-29ec-5e72-e719277faa2d@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=max@enpas.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.