From: Jens Axboe <axboe@kernel.dk>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-block <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 2/2] loop: use task_work for autoclear operation
Date: Wed, 22 Dec 2021 08:56:50 -0700 [thread overview]
Message-ID: <da951c17-8a2f-4731-c34d-e08921824414@kernel.dk> (raw)
In-Reply-To: <9eff2034-2f32-54a3-e476-d0f609ab49c0@i-love.sakura.ne.jp>
On 12/22/21 8:27 AM, Tetsuo Handa wrote:
> The kernel test robot is reporting that xfstest can fail at
>
> umount ext2 on xfs
> umount xfs
>
> sequence, for commit 322c4293ecc58110 ("loop: make autoclear operation
> asynchronous") broke what commit ("loop: Make explicit loop device
> destruction lazy") wanted to achieve.
>
> Although we cannot guarantee that nobody is holding a reference when
> "umount xfs" is called, we should try to close a race window opened
> by asynchronous autoclear operation.
>
> Try to make the autoclear operation upon close() synchronous, by calling
> __loop_clr_fd() from current thread's task work rather than a WQ thread.
Doesn't this potentially race with fput?
--
Jens Axboe
next prev parent reply other threads:[~2021-12-22 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 15:26 [PATCH 1/2] block: export task_work_add() Tetsuo Handa
2021-12-22 15:27 ` [PATCH 2/2] loop: use task_work for autoclear operation Tetsuo Handa
2021-12-22 15:56 ` Jens Axboe [this message]
2021-12-23 7:01 ` Tetsuo Handa
2021-12-23 14:13 ` Jens Axboe
2021-12-23 15:28 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da951c17-8a2f-4731-c34d-e08921824414@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.